832f79ac93
chore: apply code style
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-30 19:04:59 +07:00
3646da59f3
fix: Fix copying to the root of another mountpoint
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-04-28 10:23:21 +07:00
cae5c4f02b
fix(objectstorage): add retry attempts to S3 connection
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2025-04-23 18:40:07 +07:00
e08afe0849
Merge pull request #52184 from nextcloud/backport/51020/stable30
2025-04-17 11:38:34 +07:00
9bed21a8d7
fix: Transfer ownership with S3 as primary
...
When using S3 as primary storage, transferring ownership with the `--move` option fail with the following error:
`SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '8-45b963397aa40d4a0063e0d85e4fe7a1' for key 'fs_storage_path_hash'`
The `--move` option moves the entire home folder from one account to another.
The error means that the move failed because the destination folder already exist in `oc_filecache`.
- With S3 as primary storage, folders only exists as entries in `oc_filecache`.
- With S3 as primary storage, `moveFromStorage(...)` only moves the cache entry, as nothing needs to be moved on disk. This cache move does not delete potentially pre-existing destination folder.
- With Local storage, `moveFromStorage(...)` calls `rename(...)` which delete pre-existing folder.
- `transfer(...)`: 687a4d9ac7/apps/files/lib/Service/OwnershipTransferService.php (L112)687a4d9ac7/lib/private/Files/SetupManager.php (L261-L262)687a4d9ac7/lib/private/Files/ObjectStore/ObjectStoreStorage.php (L91-L135)687a4d9ac7/lib/private/Files/ObjectStore/ObjectStoreStorage.php (L635-L636)
2025-04-16 16:18:42 +07:00
a4d2af5155
fix: only do cache copy in updater if the parent folder should be in cache
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-04-15 18:05:36 +07:00
d38a431030
fix: Catch old cached paths and fetch the new one
...
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2025-04-08 12:44:02 +07:00
af1112dac3
fix: Proper order for checking path prefix for getting file by id from cache
...
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2025-04-08 12:44:01 +07:00
d0402dee06
fix(IFilenameValidator): correctly handle case insensitivity
...
- forbidden names and forbidden base names are case **insensitive**
so we need to check all lowercase here.
- add test that config value is also read case insensitive.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-24 11:46:43 +07:00
552c5e8cef
fix(files): Make sure file pointer exists
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-03-17 16:04:47 +07:00
acf19f7880
Revert "Revert "[stable30] fix: Handle copy of folders containing live photos""
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-03-05 13:45:23 +07:00
c6ca459b40
fix: No IFactory in constructor
...
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2025-03-05 11:34:03 +07:00
259919e9fd
fix(files): Don't do session related work in the constructor of the View
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-03-05 11:34:03 +07:00
682c8e6a61
Merge pull request #50796 from nextcloud/backport/50781/stable30
...
[stable30] perf(files): faster query to fetch incomplete directories
2025-02-17 19:15:58 +07:00
33fb176651
fix: make locked exception path relative to the view
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-15 14:42:51 +07:00
765b4921ff
perf(files): faster query to fetch incomplete directories
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2025-02-14 10:57:26 +07:00
7bf1126b1f
Merge pull request #49657 from nextcloud/backport/48769/stable30
...
[stable30] Fix incorrect permissions when copying shared files
2025-02-14 10:30:46 +07:00
a663b3e0cd
fix(files): Correctly copy the cache information on copy operations
...
Needed to copy the `encrypted` flag of encrypted files when those files are two level down in a moved folder.
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-02-13 23:35:59 +07:00
9f1666ef3d
fix: use scan_permissions when copying cache items
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-13 18:17:31 +07:00
5c9a3a2423
fix: store unmaked source permissions as scan_permissions when loading share cache items
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-13 18:17:31 +07:00
da334737e4
fix: rework move into object store to better preserve fileids
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-13 17:31:51 +07:00
e85d5df5f0
fix: preserve fileid when moving from objectstore to non-objectstore
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-13 17:31:51 +07:00
9fd7dfd1c2
fix: ensure source folder is removed from cache when moving to objectstore
...
otherwise this causes confusion down the line as it's contents will be moved to the new cache
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-13 17:31:51 +07:00
094ea5c885
Merge pull request #50761 from nextcloud/backport/50324/stable30
...
[stable30] fix: don't use cached root info from shared cache if the watcher has detected an update
2025-02-13 16:43:50 +07:00
3bfcd8371b
fix: don't use cached root info from shared cache if the watcher has detected an update
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-11 16:21:37 +07:00
86408a5be7
fix: psalm and OCP @since declarations
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2025-02-06 15:15:41 +07:00
80a4cb586f
fix: make sure we process mime extensions as string
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-06 15:15:41 +07:00
5d094feee0
fix: explicitly ignore nested mounts when transfering ownership
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-05 09:09:04 +07:00
6cf97e929b
fix: translate mount move error messages
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-05 09:09:03 +07:00
68829ad47c
fix: improve checks for moving shares/storages into other mounts
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-05 09:08:58 +07:00
b081f3b7c4
fix(s3): treat empty sse_c_key as not set
...
Co-authored-by: Christian Becker <christian@dabecka.de>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-01-29 17:34:47 +07:00
67e0ef5b72
fix(files): Do not array access null value
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 20:51:42 +07:00
474d93625b
fix: Metadata field search
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-01-27 18:57:00 +07:00
1c99b367be
Merge pull request #49991 from nextcloud/backport/49887/stable30
2025-01-20 17:28:02 +07:00
a2bcf725a6
chore: psalm fixes
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-01-20 15:31:05 +07:00
1efa72d91a
fix(TemplateManager): Remove warning message
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-01-20 13:41:38 +07:00
2f9b54ab38
fix: don't skip scanner users filesystem if they have a mountpoint at /<user>/files/
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-01-20 14:27:24 +07:00
5cc14e2618
fix(View): Catch exceptions when executing mkdir for non-existent parents
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-12-17 09:40:42 +07:00
28c6c63cc5
fix(TemplateManager): Make sure TemplateFolder is a Folder
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-12-16 06:05:23 +07:00
cabedbf9c3
Revert "[stable30] fix: Handle copy of folders containing live photos"
2024-12-12 14:28:09 +07:00
d8c3425878
Merge pull request #49650 from nextcloud/backport/49293/stable30
...
[stable30] fix: Handle copy of folders containing live photos
2024-12-12 14:19:55 +07:00
d108a12b0e
Merge pull request #49794 from nextcloud/backport/40394/stable30
...
[stable30] fix mimetype not being updated when changing file extention on objectstore
2024-12-12 13:19:59 +07:00
c3a2d789f1
fix: fix mimetype not being updated when changing file extention on object store
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-12-11 09:00:44 +07:00
9ff3ba7ce0
fix: Correctly create NonExistingFolder during copy
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-12-05 10:35:42 +07:00
46ed8cdfde
fix: don't propagate future mtimes
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-12-04 19:14:51 +07:00
44727d4862
fix: fix availability wrapper not applying
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-11-26 18:50:00 +07:00
3522819624
fix: throw correct exception type when we can't verify if an s3 bucket exists
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-11-26 18:49:56 +07:00
003bb0aca4
fix(storage): Try to delete existing target
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-11-21 07:44:43 +07:00
1fc1543a8b
fix: Clean-up some remaining readdir calls with undesirable false evaluation potential
...
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-11-13 09:11:17 +07:00
e1df152eb9
Fix Undefined variable: response notice in case of non-404 error
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-08 16:14:47 +07:00
Ferdinand Thiessen
Côme Chilliet
Anna Larch
Louis
Robin Appelman
Julius Knorr
Git'Fellow
Marcel Müller
Joas Schilling
Andy Scherzinger
Benjamin Gaussorgues
John Molakvoæ
skjnldsv
Richard Steinmetz
Kate
provokateurin
Josh Richards
Victor Dubiniuk