Commit Graph

15128 Commits (00a84d28d8fc2ffe612f445a26b3c4ca56ba43f7)

Author SHA1 Message Date
Ferdinand Thiessen 832f79ac93
chore: apply code style
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-30 19:04:59 +07:00
John Molakvoæ c4865cb7a4
Merge pull request #52523 from nextcloud/fixIncParam30 2025-04-30 12:24:19 +07:00
Luka Trovic 03d11b3980 feat(admin_audit): write admin audit log for login failed
Signed-off-by: Luka Trovic <luka@nextcloud.com>
2025-04-29 20:07:19 +07:00
Git'Fellow b751eea309 fix(JSResourceLocator): fix incorrect parameter being used
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-04-29 19:08:23 +07:00
Ferdinand Thiessen 588b191f3d fix(32bit): use `PHP_INT_MAX` where needed
* Typo from https://github.com/nextcloud/server/pull/52392

`0xFFFF` is only 2 bytes, but we need either `0xFFFFFFFF` or maybe a bit
easier to read `PHP_INT_MAX`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-28 19:23:37 +07:00
Ferdinand Thiessen b27d92537e fix(32bit): make `pack` compatible with 32bit PHP
The `P` formatter is 64bit only - we need to manually pack the 64bit.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-28 19:23:37 +07:00
Côme Chilliet 3646da59f3 fix: Fix copying to the root of another mountpoint
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-04-28 10:23:21 +07:00
Joas Schilling c0072b8f10 fix(config): Censor more app configs in system report
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-04-25 11:03:57 +07:00
Benjamin Gaussorgues b6b9c3d211
Merge pull request #52232 from nextcloud/backport/52223/stable30 2025-04-24 14:23:20 +07:00
Benjamin Gaussorgues db71a2b2c9
feat(ip): add configurable IPv6 subnet for BFP and throttling
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2025-04-24 09:41:32 +07:00
Andy Scherzinger 344e282039
Merge pull request #52381 from nextcloud/backport/52361/stable30
[stable30] fix(objectstorage): add retry attempts to S3 connection
2025-04-23 22:55:18 +07:00
Andy Scherzinger 7322e16eb2
Merge pull request #52386 from nextcloud/backport/51994/stable30
[stable30] fix(federation): allows equal signs in federation id
2025-04-23 22:53:54 +07:00
Andy Scherzinger 0e7f928ccc
Merge pull request #52238 from nextcloud/backport/50465/stable30
[stable30] fix: Check that user actually can validate password for js
2025-04-23 22:32:49 +07:00
Maxence Lange c3f431d4fe fix(federation): allows equal signs in federation id
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2025-04-23 19:23:40 +07:00
Anna Larch cae5c4f02b fix(objectstorage): add retry attempts to S3 connection
Signed-off-by: Anna Larch <anna@nextcloud.com>
2025-04-23 18:40:07 +07:00
Louis e08afe0849
Merge pull request #52184 from nextcloud/backport/51020/stable30 2025-04-17 11:38:34 +07:00
zorn-v 7bdbb3cfad Check that user actually can validate password for js
Signed-off-by: zorn-v <zorn7@yandex.ru>
2025-04-17 07:16:15 +07:00
Louis Chemineau 9bed21a8d7 fix: Transfer ownership with S3 as primary
When using S3 as primary storage, transferring ownership with the `--move` option fail with the following error:

`SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '8-45b963397aa40d4a0063e0d85e4fe7a1' for key 'fs_storage_path_hash'`

The `--move` option moves the entire home folder from one account to another.
The error means that the move failed because the destination folder already exist in `oc_filecache`.

- With S3 as primary storage, folders only exists as entries in `oc_filecache`.
- With S3 as primary storage, `moveFromStorage(...)` only moves the cache entry, as nothing needs to be moved on disk. This cache move does not delete potentially pre-existing destination folder.
- With Local storage, `moveFromStorage(...)` calls `rename(...)` which delete pre-existing folder.

- `transfer(...)`: 687a4d9ac7/apps/files/lib/Service/OwnershipTransferService.php (L112)
- `oneTimeUserSetup(...)`: 687a4d9ac7/lib/private/Files/SetupManager.php (L261-L262)
- `mkdir(...)`: 687a4d9ac7/lib/private/Files/ObjectStore/ObjectStoreStorage.php (L91-L135)
- `moveFromStorage(...)`: 687a4d9ac7/lib/private/Files/ObjectStore/ObjectStoreStorage.php (L635-L636)

Delete pre-existing folder in `moveFromStorage(...)`

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-04-16 16:18:42 +07:00
Robin Appelman a4d2af5155 fix: only do cache copy in updater if the parent folder should be in cache
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-04-15 18:05:36 +07:00
Julius Knorr 37da5ff519
Merge pull request #52040 from nextcloud/backport/52008/stable30
[stable30] fix: Proper order for checking path prefix for getting file by id from cache
2025-04-15 12:10:27 +07:00
Maxence Lange 20ed42a7d7 fix(setup): ignore missing theming app
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2025-04-14 21:53:36 +07:00
John Molakvoæ 2f1949a57e fix(tests): Share manager error message from #52076
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2025-04-14 18:09:23 +07:00
Ferdinand Thiessen f724102518
Merge pull request #52042 from nextcloud/backport/52013/stable30
[stable30] fix: Handle missing share providers when promoting reshares
2025-04-14 17:19:00 +07:00
Joas Schilling 32d30f8f67
fix(federation): Fix returning "no display name" after cache result
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-04-10 12:37:59 +07:00
Joas Schilling 2593702243
fix(federation): Don't load the addressbook when resolving a cloud ID
Instead we delay the lookup of the display name until it is actually used

Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-04-09 13:57:24 +07:00
Daniel Calviño Sánchez c002b78a6e fix: Handle missing share providers when promoting reshares
The provider for mail shares is not available when the "sharebymail" app
is disabled, and in that case a "ProviderException" is thrown when
trying to get it.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2025-04-08 13:33:57 +07:00
Julius Knorr d38a431030 fix: Catch old cached paths and fetch the new one
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2025-04-08 12:44:02 +07:00
Julius Knorr af1112dac3 fix: Proper order for checking path prefix for getting file by id from cache
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2025-04-08 12:44:01 +07:00
Benjamin Gaussorgues bad8f54232
feat(ip): use larger IPv6 range by default
Some providers assign `/48` IPv6 blocks instead of `/64` so it sounds safer
to use this mask by default.

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2025-04-08 11:30:15 +07:00
provokateurin d44b42fd24
Revert "refactor: add migration for email setting"
This reverts commit e7859f0dac.

Signed-off-by: provokateurin <kate@provokateurin.de>
2025-04-07 10:23:23 +07:00
Ferdinand Thiessen 8a0bc2422d
fix: ensure enabled themes are set on the template
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-04 10:10:25 +07:00
Ferdinand Thiessen 8ab28350f9 refactor: add migration for email setting
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-03 16:12:55 +07:00
provokateurin 8a8d6addfb fix(settings): Handle email change restriction separately from display name change restriction
Co-authored-by: provokateurin <kate@provokateurin.de>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Louis <louis@chmn.me>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-03 16:12:55 +07:00
Christoph Wurst 181561771b
fix(session): Only mark sessions of permanent tokens as app passwords
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2025-04-03 10:15:11 +07:00
Louis Chemineau 84b59c48b6 fix: Use login name to check the password
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-04-02 17:21:06 +07:00
Andy Scherzinger 0ef3932ad2
Merge pull request #51868 from nextcloud/backport/51866/stable30
[stable30] fix: use proper migration sorting when checking if a migration needs to be executed
2025-04-02 18:41:38 +07:00
Robin Appelman 2708a2b622 fix: use proper migration sorting when checking if a migration needs to be executed
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-04-02 12:52:40 +07:00
Richard Steinmetz 550d8d9fce
fix(oauth2): retain support for legacy ownCloud clients
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-04-02 12:23:45 +07:00
Côme Chilliet 107c18dff2
chore: Remove now unused methods from User manager
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-31 15:39:35 +07:00
Côme Chilliet d3bc8b771c
fix: Correctly count disabled users for SAML groups subadmins
If too many users return -1 as for LDAP so that link is shown

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-31 15:39:05 +07:00
Louis Chemineau 822761af70 chore: Refactor callForSeenUsers to use getSeenUsers
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-03-31 11:00:59 +07:00
Louis Chemineau 97d1295ff2 feat: Implement getSeenUsers to iterate over users
This method uses an iterator.
This is lighter on resources and gives more control to the caller

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-03-31 11:00:59 +07:00
Julius Knorr c59a2e6316 fix: filter out contacts with invalid email addresses in sharee completion
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2025-03-30 01:35:25 +07:00
Andy Scherzinger 5ebcf9b72b
Merge pull request #51327 from nextcloud/backport/51130/stable30
[stable30] fix: Do not build encrypted password if there is none
2025-03-28 16:19:52 +07:00
Kate 0b2bd3b615
Merge pull request #51717 from nextcloud/backport/51433/stable30
[stable30] fix(GenerateBlurhashMetadata): Suppress imagescale errors
2025-03-28 16:18:00 +07:00
Julius Knorr ebe943207d fix: Do not build encrypted password if there is none
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2025-03-28 15:18:03 +07:00
Kate 559d6e8639
Merge pull request #51523 from nextcloud/backport/51389/stable30
[stable30] fix: skip caching lastSeenQuotaUsage for remote shares
2025-03-28 15:14:48 +07:00
umgfoin 36aa350d9e fix(GenerateBlurhashMetadata): Suppress imagescale errors
Suppress errors in imagescale during file-scans:
Most of these errors are caused by out of range x/y-dims.

Triggering un unhandled exception, metadata-generation aborts at this point  (e.g. occ files:scan --generate-metadata), effectively preventing these images from being added to photos or maps.

This problem might be the root cause for an issue described here:
https://github.com/nextcloud/photos/issues/2768

Signed-off-by: umgfoin <umgfoin@users.noreply.github.com>
2025-03-28 14:44:20 +07:00
Ferdinand Thiessen 5468a8f1f4
Merge pull request #51754 from nextcloud/backport/50121/stable30
[stable30] fix(theming): enforce theme also for login
2025-03-28 14:42:07 +07:00
Ferdinand Thiessen 69274eba66 fix(theming): enforce theme also for login
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-27 11:15:44 +07:00