98ed72b3ed
Revert "fix(performance): Do not set up filesystem on every call"
2023-02-21 07:36:43 +07:00
614981ae9a
feat(directediting): Allow opening by file id
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-20 12:16:34 +07:00
5d4efb4d5f
Do not set up filesystem on every call
...
Also remove old Oc_FileChunking logis that produced GC- collectable chunks
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-02-17 19:18:37 +07:00
47bc024885
Revert the token scope to not end up with storing the user used in the session
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-17 10:18:18 +07:00
90d2cb09b1
Merge pull request #36396 from nextcloud/fix/cors
2023-02-17 09:42:08 +07:00
f655f83c84
fix(CORS): CORS should only be bypassed on `PublicPage` if not logged in to prevent CSRF attack vectors
...
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-16 22:55:18 +07:00
98b998a2de
Merge pull request #36735 from nextcloud/fix/32635/fix-vcf-contacts
...
fix the contacts-menu vcf-contact avatars
2023-02-16 14:01:19 +07:00
b38d2daede
fix the contacts-menu vcf-contact avatars
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-02-15 23:16:43 +07:00
5f90b8eb11
Change X-Robots-Tag header from "none" to "noindex, nofollow"
...
While "none" is indeed equivalent to "noindex, nofollow" for Google, but seems to be not supported by Bing and probably other search engines.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta/name#other_metadata_names
https://developers.google.com/search/docs/crawling-indexing/robots-meta-tag?hl=de#comma-separated-list
https://www.bing.com/webmasters/help/which-robots-metatags-does-bing-support-5198d240
Signed-off-by: MichaIng <micha@dietpi.com>
2023-02-15 20:16:51 +07:00
a705132c8d
Merge pull request #36656 from nextcloud/route-instrumentation
2023-02-14 10:12:19 +07:00
b911da3e1e
DI for Router
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-02-13 22:51:14 +07:00
936f634069
Merge pull request #36643 from nextcloud/fs-setup-instrimuntion
...
more filesystem setup performance instrumentation
2023-02-13 14:37:57 +07:00
91d5f6a826
more filesystem setup performance instrumentation
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-02-10 11:11:13 +07:00
c77998209f
Port user menu to Vue
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-02-09 17:54:59 +07:00
a81d8ecef5
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-09 16:15:47 +07:00
08802ad13f
Merge pull request #36566 from nextcloud/mount-find-by-numeric-id
2023-02-08 20:04:57 +07:00
dcfc96f0cc
Merge pull request #36417 from nextcloud/fix/psr-container
...
Make the container fully fulfill PSR container interface
2023-02-07 20:38:19 +07:00
9f3dbb699a
fix tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-02-07 15:50:10 +07:00
892e6c642a
Skip buggy tests for 32bits CI
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:33 +07:00
77c8c9c805
Improve error output on failed Router test
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:31 +07:00
94ecae4ade
Add helper to cast to int|float, fix MemoryInfo on 32bits
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:29 +07:00
0f8c34cdc6
Fix filesize return type error in ViewTest
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:29 +07:00
5cfab229db
Improve test failure output for RouterTest.php
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:29 +07:00
2d8e696c24
Add apcu and ffmpeg to have less skipped tests
...
Also exclude test groups which rely on a service
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:28 +07:00
59578817f5
Merge pull request #36489 from nextcloud/bugfix/noid/brute-force-protection-password-reset
...
Add bruteforce protection to password reset page
2023-02-06 22:12:25 +07:00
ba8a50c059
fix: Throw `NotFoundExceptionInterface` to fulfill PSR container interface if class not found
...
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-06 14:16:35 +07:00
875e6cf7e6
fix(CI): Adjust expected result
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-06 11:26:38 +07:00
88d116ba84
fix(client-login-flow): Handle missing stateToken gracefully
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-02-06 09:42:15 +07:00
47880b143d
Remove failing test that works with mocks only anyway
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-02 18:06:31 +07:00
dde5c46a3e
Migrate to Symfony Mailer
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-02 10:30:06 +07:00
1a655e88d9
use php8.0 images
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-01-31 15:44:12 +07:00
c246edece6
tests(oci): Test where statement on longtext column
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
test: try with just passing the type to eq which should also cast
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-01-31 11:57:54 +07:00
2f3007205d
Merge pull request #35160 from nextcloud/artonge/feat/version_naming_backend
...
Allow to name a version
2023-01-30 10:40:49 +07:00
959e2aaa17
fix(tests): Fix method name in unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-30 09:12:50 +07:00
20e00cdf17
feat(app-framework): Add UseSession attribute to replace annotation
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-27 09:40:35 +07:00
8d9af3e262
feat(app-framework): Add support for global middlewares
...
This allows apps to register middlewares that always register, not just
for the app's own requests
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-26 11:54:28 +07:00
d8b479752d
Fix hookconnector tests
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-01-26 10:12:23 +07:00
907ff68bfc
perf(app-framework): Make the app middleware registration lazy
...
Before this patch, app middlewares were registered on the dispatcher for
every app loaded in a Nextcloud process. With the patch, only
middlewares belonging to the same app of a dispatcher instance are
loaded.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-25 09:27:24 +07:00
0236c9e8cd
Port files sharing selector
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-01-24 17:40:17 +07:00
003cc2b45a
Fix tests failures (number of calls differed with last rebase)
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-24 09:38:20 +07:00
a23cd7b961
Fix a bunch of deprecation in the phpunit for core
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2023-01-24 09:34:09 +07:00
1c099c7f17
Fix broken user:setting command unit test
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-23 07:01:22 +07:00
f5c361cf44
composer run cs:fix
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:45:08 +07:00
89dbc629ff
Fix integrity check
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-20 11:22:11 +07:00
de68fc6347
Update test file for mimetypes
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:22:11 +07:00
b22b6431d2
Fix gzip mimetype mapping
...
PHP now detects it as application/gzip and not application/x-gzip anymore
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:22:11 +07:00
7ebbb6b2ca
Remove workarounds specific to 7.4
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:22:08 +07:00
1e2441ff6b
Disable unreliable acceptance tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-19 09:21:33 +07:00
20fcfb5739
feat(app framework)!: Inject services into controller methods
...
Usually Nextcloud DI goes through constructor injection. This has the
implication that each instance of a class builds the full DI tree. That
is the injected services, their services, etc. Occasionally there is a
service that is only needed for one controller method. Then the DI tree
is build regardless if used or not.
If services are injected into the method, we only build the DI tree if
that method gets executed.
This is also how Laravel allows injection.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-18 14:00:38 +07:00
f22101d421
Fix login loop if login CSRF fails and user is not logged in
...
If CSRF fails but the user is logged in that they probably logged in in
another tab. This is fine. We can just redirect.
If CSRF fails and the user is also not logged in then something is
fishy. E.g. because Nextcloud contantly regenrates the session and the
CSRF token and the user is stuck in an endless login loop.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-18 09:39:17 +07:00
Joas Schilling
Julius Härtl
Anna Larch
Ferdinand Thiessen
Louis
Simon L
MichaIng
Robin Appelman
Christopher Ng
Joas Schilling
Côme Chilliet
Christoph Wurst
Maxence Lange
Louis Chemineau
Carl Schwan