Commit Graph

528 Commits (00a7478d8df2007697d5caf2e0cb1c298afbb3fd)

Author SHA1 Message Date
Joas Schilling 98ed72b3ed
Revert "fix(performance): Do not set up filesystem on every call" 2023-02-21 07:36:43 +07:00
Julius Härtl 614981ae9a
feat(directediting): Allow opening by file id
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-20 12:16:34 +07:00
Anna Larch 5d4efb4d5f
Do not set up filesystem on every call
Also remove old Oc_FileChunking logis that produced GC- collectable chunks

Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-02-17 19:18:37 +07:00
Julius Härtl 47bc024885
Revert the token scope to not end up with storing the user used in the session
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-17 10:18:18 +07:00
Robin Appelman 4532e52787 remove explicit setup when getting storage info
the implicit setup gets enough data without having to do a full setup.

Saves having to do a full fs setup for the files webui template

Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-02-08 13:47:55 +07:00
Simon L 078203afea
Merge pull request #35935 from EWouters/patch-1
[Fix]: scan-app-data conversion
2023-01-23 17:43:14 +07:00
John Molakvoæ b9906fb21e
feat(files): Quota in navigation
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-01-17 18:30:41 +07:00
John Molakvoæ 7339355dde
Fix favourite opening
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-01-04 16:46:16 +07:00
John Molakvoæ 0a3ef8b74b
Fixing tests
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-01-04 16:46:16 +07:00
John Molakvoæ 5b9a8f0407
Add component testing
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-01-04 16:46:14 +07:00
John Molakvoæ 5c987a0ff4
Port settings to Modal
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-01-04 16:45:52 +07:00
John Molakvoæ 887c9e05de
Port Files navigation to vue
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-01-04 16:45:41 +07:00
EWouters 3a9173cbac
[Fix]: scan-app-data conversion
Adapted from sugestions by @Hiyoal in #34283 and @st3iny in #35935.

See https://github.com/nextcloud/server/issues/34283#issuecomment-1288075064
and https://github.com/nextcloud/server/pull/35935#discussion_r1059905594.

Closes #34283.

Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: EWouters <6179932+EWouters@users.noreply.github.com>
2023-01-03 13:52:34 +07:00
Julius Härtl 6abb37317f
Do not setup a session when not required on WebDAV requests
If basic auth is used on WebDAV endpoints, we will not setup a session
by default but instead set a test cookie. Clients which handle session
cookies properly will send back the cookie then on the second request
and a session will be initialized which can be resued for
authentication.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-12-21 21:17:16 +07:00
Côme Chilliet cbbb0712db
Merge pull request #34807 from nextcloud/fix/compute-notification-parsed-subject
Compute notification parsed subject from rich subject when possible
2022-12-19 10:46:39 +07:00
Côme Chilliet a0f6a6545b
Use TimedJob from OCP instead of OC
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-12-05 10:13:34 +07:00
Côme Chilliet d9151ff35c Get rid of all useless calls to setParsedSubject now that setRichSubject is able to do it
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-29 14:36:29 +07:00
Markus Zeller 15289f9737
Cast to int #32837
Signed-off-by: Markus Zeller <git@markuszeller.com>
2022-11-07 16:44:47 +07:00
Joas Schilling edb64b193c
Also throttle on expiration
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-10-12 13:01:19 +07:00
Joas Schilling 9b204649e4
Fix psalm error on migration
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-10-12 11:55:04 +07:00
Joas Schilling 9c5fef35c7
Add a background job to delete expired tokens
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-10-12 11:43:00 +07:00
Joas Schilling c167fb5ccb
Also remove token when we successfully validated
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-10-11 20:39:39 +07:00
Joas Schilling cfbbace450
Require a token for "Edit locally"
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-10-11 20:15:26 +07:00
Carl Schwan 54b6d0708b Allow scanning for metadata with occ scan:file --generate-metadata
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-10-11 10:41:17 +07:00
Anna Larch 25409cb66c Url encode the web dav url for copying
Signed-off-by: Anna Larch <anna@nextcloud.com>
2022-10-02 08:46:16 +07:00
luz paz 9d26671f05 Fix typos in apps/ subdirectory
Found via `codespell -q 3 -S l10n,./apps/files_external/3rdparty -L adn,ba,boxs,keypair,jus,optionel,ressource,tabel ./apps/`

Signed-off-by: luz paz <luzpaz@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-09-05 12:59:54 +07:00
Carl Schwan b888c61463
Merge pull request #33047 from nextcloud/fix/ijob-logger-deprecated
Deprecated ILogger from IJob
2022-08-23 16:55:42 +07:00
Joas Schilling 7e11778190
Use user name cache in activity providers
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-08-19 10:48:32 +07:00
Vincent Petry fbc48db507
Remove redundant events
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-15 19:20:42 +07:00
Daniel Calviño Sánchez 4c837dadf2 Show usage percenteage in the tooltip
The tooltip of the initial quota display showed the usage percenteage
and the total available space. However, the total available space was
redundant, as it was shown just below. The tooltip of the updated quota
display showed the usage percenteage, but based on the quota rather than
the total available space, so there was a mismatch between the tooltip
and the bar below. Now the tooltip of the initial and the updated quota
display both show just the usage percenteage based on the total
available space.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-08-10 11:23:27 +07:00
Daniel Calviño Sánchez f6bdaac88e Use total available space rather than quota when updating the display
The initial quota display uses the total available space rather than the
quota. Moreover, the relative usage is based on the total space rather
than the quota. Due to this now the total available space is also used
when updating the quota display.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-08-10 11:22:50 +07:00
Carl Schwan 48d9c4d2b0
Port existing server code to new interface
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-08 17:03:19 +07:00
Simon L de82d4f67c
Merge pull request #32874 from bill-mcgonigle/patch-1
Mention missing files subdir
2022-06-17 12:12:25 +07:00
Côme Chilliet c54fb5f9e6
Use {$var} instead of ${var} for PHP 8.2 compatibility
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-06-14 15:12:28 +07:00
Bill McGonigle ad60b3b479
Mention missing files subdir
Many users are getting confused by the inaccurate error message "Home storage for user $user not writable" because the storage *is* writable.  The actual issue is a missing files/ subdirectory.  cf. https://help.nextcloud.com/t/home-storage-for-user-not-writable/10831/7
By mentioning the possible cause in the error message, users are going to be able to rapidly solve their problem rather than bang their heads against the screen, Google, and eventually forums to find out that the error message is wrong in their case.
Yes, it would be better to detect and precisely describe the fault, or fix the problem automatically, but until then, be kind to the users for the next however many years.
2022-06-14 07:10:29 +07:00
Vincent Petry e6e1862000
Merge pull request #32059 from cld4h/patch-1
Fix issue #31692 of occ files:scan
2022-06-10 16:20:00 +07:00
Julius Härtl 61056587c9
Only load direct editing capabilities when required
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-06-03 07:15:17 +07:00
John Molakvoæ 18f2340a40
Merge pull request #32149 from nextcloud/fix-transferring-groupfolders 2022-05-11 08:40:28 +07:00
Carl Schwan f945c0cbc6 Add a public replacement for OC::$server->get
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-10 18:51:12 +07:00
Vanessa Pertsch c714c3380a fix for transferring ownership of groupfolders
Signed-off-by: Vanessa Pertsch <vanessa.pertsch@nextcloud.com>
2022-05-10 16:54:22 +07:00
cld4h 553239c083 Fix issue #31692 of occ files:scan
occ files:scan reports error "Implicit conversion from float XXX to int loses precision"

Signed-off-by: cld4h <20869428+cld4h@users.noreply.github.com>
2022-04-26 14:22:41 +07:00
Robin Appelman 7eca0a2553
don't force a full setup for getting storage stats
the auto-setup is good enough

Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-06 13:13:37 +07:00
Côme Chilliet ea23523c70
Adapt more code to migration to LoggerInterface
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-24 16:21:25 +07:00
Carl Schwan 028ca0935c Don't redirect when loading files index page
Currently we are redirecting from ?dir=/&fileid=2 to ?dir=/. This is an
issue because we then need to load two pages with full file system setup
and authentification instead of one and the assets won't start loading
until the second page is delivered to the user.

Additionally when loading ?dir=/, we then change the url back to
?dir=/&fileid=2 (without reload) so that the next time we load the page
again we do the same thing again.

Depending on the speed of the server and internet connection we can save
100ms to 400ms, improving the user experience.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-02-17 17:06:33 +07:00
Vincent Petry 62d47100ec
Merge pull request #30953 from nextcloud/feat/init-storage-when-transferring-ownership
Init user's file system if not existing on ownership transfer
2022-02-10 18:13:43 +07:00
Vincent Petry 1a9e6f1571
Merge pull request #31097 from nextcloud/bugfix/31096/fix-shares-transfer-guest-to-nonguest
Fix path handling when transferring incoming shares
2022-02-10 17:47:41 +07:00
Vincent Petry 7858fee5b5
Fix path handling when transferring incoming shares
When transferring incoming shares from a guest user without specifying a
path, the $path is empty.
The fix properly handles that situation to avoid looking for shares in a
path with doubled slashes which failed to find shares to transfer.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-02-10 09:50:21 +07:00
Joas Schilling 5f5142ff58
Don't provide favorite activity settings
Since mails and notifications are only available for actions of other users
it does not make sense to allow changing this.
It also prevents the common misunderstanding with
"file was changed inside a favorited folder"

Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-02-09 10:49:32 +07:00
Carl Schwan 02da4ce1b0 Init user's file system if not existing on ownership transfer
This makes it a bit easier to transfer ownership when the new user
hasn't already logged in. This still doesn't support encrypted
storages because the keys are not generated yet.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-02-01 13:26:41 +07:00
Julien Veyssier b67b4b160b
[files] new internal link GET param to avoid setting 'openfile' on redirect
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2022-01-14 10:50:13 +07:00