Commit Graph

243 Commits (00a24106319ede2d9244b495c880be834817afa4)

Author SHA1 Message Date
Carl Schwan 89d109a4d9
Merge pull request #30508 from nextcloud/fix/psaml-bin
Fix psalm not running
2022-01-13 09:51:04 +07:00
Carl Schwan aeecb72e96
Fix a few psalm issues and moved back to psalm/phar 4.18
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-12 20:03:06 +07:00
MichaIng 79cdb565dc Avoid zero division in setup checks
Fixes: https://github.com/nextcloud/server/issues/30532

Signed-off-by: MichaIng <micha@dietpi.com>
2022-01-11 10:26:57 +07:00
MichaIng 82c1beaacb Enhance and complement OPcache setup checks
The current OPcache recommendations match the PHP defaults, but the values are much higher than required to run Nextcloud, even with a high number of installed apps. On the other hand, when other applications use the same OPcache instance, the recommended values might not be sufficient. Accurate recommendations need to take into account actual OPcache usage.

With this commit, recommendations are shown to raise the config value if more than 90% of max cache size or number of keys is used.

The checks whether the module is loaded and whether the OPcache is properly configured have been merged into a single function. This allowed to reduce the overhead of OPcache configuration checks when the module is not loaded.

A check has been added whether Nextcloud is permitted to use the OPcache API. Without this, inconsistencies during core or app upgrades may cause errors and OPcache usage cannot be determined for the new usage based checks.

OPcache usage based checks are skipped when Nextcloud is not permitted to use the API.

Signed-off-by: MichaIng <micha@dietpi.com>
2021-12-19 23:38:21 +07:00
Joas Schilling 19d070850b
Make sure trusted_proxies is an array
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-09 15:13:24 +07:00
Christopher Ng 50a6612c1f Refine profile backend for frontend visibility requirements
- Provide metadata
  - Dynamic displayId
  - Add appId
- Filter out unused parameter config properties from the existing profile config

Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-11-04 00:17:29 +07:00
Vitor Mattos 6f7ca3432c
show warning on personal settings page
Signed-off-by: Vitor Mattos <vitor@php.rio>
2021-10-23 00:54:51 +07:00
Vitor Mattos e55ceb2bb1
Show warning on admin settings page
Signed-off-by: Vitor Mattos <vitor@php.rio>
2021-10-23 00:54:50 +07:00
John Molakvoæ b2c32b7e6c
Merge pull request #27731 from ZitronePlus/master 2021-10-22 12:04:07 +07:00
John Molakvoæ c98039c1df
Merge pull request #26725 from nextcloud/fix-federated-scope-not-shown-when-public-addressbook-upload-is-disabled 2021-10-22 11:52:56 +07:00
Julien Veyssier 0bef570fe9
Merge pull request #29256 from nextcloud/fix/noid/harmonize-appstoreenabled-check
Fix appstoreenabled check
2021-10-21 12:42:14 +07:00
Pytal f7b3d521f8
Merge pull request #28751 from nextcloud/feat/28139/profile-page 2021-10-18 23:03:58 +07:00
Christopher Ng 309354852f Profile backend
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-10-19 04:59:35 +07:00
Christoph Wurst f432dd2e2e
Add scheduling availability settings
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-10-18 20:21:51 +07:00
Julien Veyssier facb50ebcc
fix appstoreenabled check in Fetcher so it's coherent with AppSettingsController
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2021-10-18 12:39:43 +07:00
Christoph Wurst 4b8f8c5203
Deprecate PHP7.3 for Nextcloud 23
* 7.3 reaches EOL shortly after the release of 23.0.0
* Nextcloud 24 will require PHP7.4

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-10-18 09:15:54 +07:00
Bjoern Schiessle 664bd5802f add 'supported'-label to all supported apps, also if they are not downloaded yet
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2021-10-06 22:17:50 +07:00
Joas Schilling 0dae8805c2
Improve icon and section title of "Admin privileges"
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2021-10-06 19:13:16 +07:00
Carl Schwan 6958d8005a
Add admin privilege delegation for admin settings
This makes it possible for selected groups to access some settings
pages.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-09-29 21:43:31 +07:00
szaimen d253d52007
Merge pull request #28837 from nextcloud/show-warning-if-sharing-app-disabled
Show warning on the share settings when the File Shares app is disabled
2021-09-20 12:11:42 +07:00
szaimen 3eb1d23720
Merge pull request #28838 from stefan-schilling/enh/16719-integrity-check-temp-dir
Issue 16719: CheckSetupController.php now checks configured temporary directory for existence and if it's writable
2021-09-17 18:19:22 +07:00
Stefan eb46011680 Issue 16719: CheckSetupController.php: now injecting reference to ITempManager, rather than obtaining using it manually
Signed-off-by: Stefan <Stefan.Schilling@EXXETA.com>
2021-09-17 13:32:42 +07:00
Stefan 8758b36ebb Issue 16719: CheckSetupController.php now checks configured temporary directory for existence and if it's writable
Signed-off-by: Stefan <Stefan.Schilling@EXXETA.com>
2021-09-17 13:32:42 +07:00
Thomas Citharel b3c7927260
Show warning on the share settings when the File Shares app is disabled
Closes #3706

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2021-09-15 16:33:03 +07:00
Arthur Schiwon d93e2548f0
only offer to set locally verified mails as primary
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-15 15:38:49 +07:00
Arthur Schiwon fe5e672654
let user choose notification email in user settings
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-15 15:38:40 +07:00
Arthur Schiwon 27865d03c0
use specific email getter where necessary
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-09 19:23:05 +07:00
Christoph Wurst 506b411dfc
Merge pull request #28332 from nextcloud/work/carl/argon2i2
Only recommand for php-sodium on >= PHP 7.4
2021-08-31 08:59:27 +07:00
Christopher Ng cc5815dcd0 Provide initial state
- camelCase language strings

Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-08-27 05:06:12 +07:00
Christopher Ng d4d59493a2 Provide initial state
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-08-23 21:29:47 +07:00
Daniel Calviño Sánchez 1e19b1cc99 Hide "federated" scope when Federation app is disabled
If the Federation app is disabled it is not possible to synchronize the
users from a different server.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-08-18 19:56:10 +07:00
Julius Härtl f49a751283
Do not retain VerifyUserData job when lookup server is not available
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-08-17 11:39:24 +07:00
Carl Schwan 07ccccecad
Only recommand for php-sodium on >= PHP 7.4
This is because php-sodium will solve the missing PASSWORD_ARGON2I
constant problem only on >= php 7.4, previously argon2 wasn't part of
the standard extension and was disabled on Centos/RHEL.

So installing php-sodium on php 7.2 for example wouldn't hide the
message. Tested on Fedora with php 7.4, Centos 7 with php 7.2,
Centos 8 with php 7.2 and openSUSE with php 7.4.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-08-06 14:22:09 +07:00
Christoph Wurst 43e41ca532
Merge pull request #28259 from nextcloud/work/carl/sodium-check
Check that php was compiled with argon2 support or that the php-sodium extensions is installed
2021-07-30 17:34:10 +07:00
Carl Schwan 8e51a5feda
Check that php was compiled with argon2 support or that the php-sodium
extensions is installed

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-07-30 15:11:55 +07:00
Julien Veyssier 416d10f76c refs #21045 add app config to disable unlimited quota and to set max quota
avoid unlimited quota as default_quota fallback value if unlimited quota is not allowed
avoid getting/setting/displaying unlimited default quota if not allowed
implement tests for unlimited quota restrictions

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-07-29 19:31:36 +07:00
Marco Ambrosini a4d1c55624 Allow to disable group change notification
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
2021-07-28 12:23:47 +07:00
Joas Schilling f86f594a3a
Merge pull request #27860 from J0WI/alphanumeric-rnd
Introduce ISecureRandom::CHAR_ALPHANUMERIC
2021-07-16 12:46:20 +07:00
Christopher Ng 74aa115125 Refine unsupported federation scope checks
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-07-16 05:46:04 +07:00
Christopher Ng ef41d5977a
Provide initial state
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-07-15 10:16:06 +07:00
J0WI 3b656446af Introduce ISecureRandom::CHAR_ALPHANUMERIC
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-07-08 15:11:31 +07:00
Gary Kim b78f3a57d1
Migrate HintException to OCP
Signed-off-by: Gary Kim <gary@garykim.dev>
2021-06-30 15:28:02 +07:00
ZitronePlus 1d0a40a4a6
Fix for #26526
fix for sql query
replaced double quotes with single quotes.
Query should now also work for dbs with sql_mode including "ANSI" and "ANSI_QUOTES"
2021-06-30 14:52:48 +07:00
Lukas Reschke 25ab4059c6 Add security.txt
Ref https://securitytxt.org

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-06-23 13:58:47 +07:00
John Molakvoæ (skjnldsv) 215aef3cbd
Update php licenses
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +07:00
Valdnet 9c6b01abeb
l10n: Spelling unification
Spelling unification in Transifex.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-06-02 17:49:32 +07:00
Arthur Schiwon 847ed37afc
do not use private AccountManager in UsersController
- extends IAccountProperty for verificationData getters and setters
- implementation thereof ^
- and of course adaption of UsersController

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-05-25 14:35:38 +07:00
Morris Jobke f1dbabd910
Merge pull request #26727 from nextcloud/group-exclude-link-share
Add option to exclude groups from creating link shares
2021-05-21 15:35:39 +07:00
Roeland Jago Douma 4a2775a442 Harden apptoken check
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-05-17 16:05:45 +07:00
blizzz b8b2e796bf
Merge pull request #26959 from nextcloud/techdebt/noid/verifiyuserdata-iaccountmanager
VerifyUserData shall use IAccountManager, not private API
2021-05-12 23:35:39 +07:00