Commit Graph

15 Commits (stable21)

Author SHA1 Message Date
Jonas Meurer 02ce5c8f7d
Respect user enumeration settings in user status lists
So far, the functions to find user statuses listed didn't respect user
enumeration settings (`shareapi_allow_share_dialog_user_enumeration`
and `shareapi_restrict_user_enumeration_to_group` core app settings).

Fix this privacy issue by returning an empty list in case
`shareapi_allow_share_dialog_user_enumeration` is unset or
`shareapi_restrict_user_enumeration_to_group` is set.

In the long run, we might want to return users from common groups if
`shareapi_restrict_user_enumeration_to_group` is set. It's complicated
to implement this in a way that scales, though. See the discussion at
https://github.com/nextcloud/server/pull/27879#pullrequestreview-753655308
for details.

Also, don't register the user_status dashboard widget at all if
`shareapi_allow_share_dialog_user_enumeration` is unset or
`shareapi_restrict_user_enumeration_to_group` is set.

Fixes: #27122

Signed-off-by: Jonas Meurer <jonas@freesources.org>
2021-10-25 10:05:33 +07:00
Joas Schilling d06f3cc51a Don't update statuses to offline again and again
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-07 10:14:35 +07:00
Morris Jobke 2adfb27007
Merge pull request #23129 from nextcloud/enh/noid/tests-user-status
More tests for user_status
2020-10-06 22:13:44 +07:00
Christoph Wurst d9015a8c94
Format code to a single space around binary operators
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-05 20:25:24 +07:00
Daniel Kesselberg 00bca0fe3e
Another test for user live status listener
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-10-01 21:27:45 +07:00
Roeland Jago Douma 5451dcbec5
Merge pull request #23112 from nextcloud/bugfix/noid/increase-timeout-of-statuses
Increase the timeout of statuses
2020-10-01 11:43:36 +07:00
Joas Schilling 0c7c358d13
Increase the timeout of statuses
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-01 08:54:35 +07:00
Joas Schilling 32b577a5df
Reset the user status when clearing the custom message
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-30 14:12:02 +07:00
Daniel Kesselberg a61394d528
Add test case for getDefaultStatusById
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-09-24 22:32:27 +07:00
Georg Ehrke 5be49491d3
Do not display Offline statuses in the Dashboard widget
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-09-07 11:30:15 +07:00
Georg Ehrke 7fedd33825
Better cleanup routine for statuses
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-09-07 09:22:38 +07:00
Georg Ehrke a352a7c7f3
Introduce consts for statuses
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-09-07 09:22:34 +07:00
Georg Ehrke bd6a6cf3bf
Add Status Dashboard
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-08-20 15:43:34 +07:00
Georg Ehrke 0e0e0d19e8
Provide a PHP Api for UserStatus
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-08-05 13:48:46 +07:00
Georg Ehrke 0fad921840
Add user-status app
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-07-31 16:45:27 +07:00