The loading order can have side effects in the way how apps register
plugins, listeners, etc.
Recently the order had been changed as part of cleaning up old code, but
caused apps to break.
This brings back the old app loading order to guarantee that apps won't
break, even though it might not semantically make sense.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
The appframework has been the default for quite some time now. So time
to take proper advantage of it.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Only OCS exceptions have a getResult method. Any other exception will
cause another error due to this invalid method call.
This splits the catch into a specific one for OCS and then a generic one
for anything else that can't be handled.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.
This also removes and empty lines from method/function bodies at the
beginning and end.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Just to avoid users from trying this with a to new (untested) php version
* Moved the check logic to 1 place
* All directly callable scripts just require this on top
* exit hard (-1) so we know scripts won't continue
* Return status 500 so no sync clients will try fancy stuff
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
This is not intended anymore, since it falls back to force english
when the header is not set. Also 0228bc6e66
makes clear that the order should be:
1. User setting
2. Accept language
3. Admin default
This is the case since the commit from above, unless via OCS and DAV.
Both forced to accept-language falling back to english.
By removing the force, it now also matches the w3 priority list:
https://www.w3.org/International/questions/qa-lang-priorities
Signed-off-by: Joas Schilling <coding@schilljs.com>
Single user mode basically disables WebDAV, OCS and cron execution. Since
we heavily rely on WebDAV and OCS also in the web UI it's basically useless.
An admin only sees a broken interface and can't even change any settings nor
sees any files. Also sharing is not possible.
As this is at least the case since Nextcloud 9 and we haven't received any
reports for this it seems that this feature is not used at all so I removed it.
The encryption commands now rely on the well tested maintenance mode.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Côme Chilliet
provokateurin
Andy Scherzinger
Joas Schilling
Maxence Lange
Christoph Wurst
John Molakvoæ (skjnldsv)
Roeland Jago Douma
Vincent Petry
Julius Härtl
Morris Jobke
Robin Appelman
Vincent Petry
Lukas Reschke
Roeland Jago Douma
Christoph Wurst
Lukas Reschke
Joas Schilling
Thomas Müller