660f3f6fd1
refactor: use logical `&&` `||` instead of weak `and` `or` operators
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-09-27 23:02:18 +07:00
b7c15949ce
chore: Get rid of AppLocator helper
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-08-18 17:09:40 +07:00
24bc1d606e
feat(core): add human readable mimes
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2025-05-14 22:55:06 +07:00
cdd00bf803
fix: Report duplicated extra files in integrity check
...
The `array_diff` is not comparing the array keys. This means that an extra key with an expected hash will not be reported. Using `array_diff_assoc` will report such files.
For example, copying `status.php` to `status 2.php`, will only be reported with the new version.
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-02-26 10:28:39 +07:00
606241caeb
chore(legacy): Introduce public version ct plass and drop version methods from OC_Util
...
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2024-09-20 14:53:34 +07:00
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-19 14:21:20 +07:00
76f2bc0bfc
fix: Replace OC_App::getAllApps with a method in AppManager
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-13 10:08:44 +07:00
8fc498fb82
fix(IntegrityCheck): Ensure the check is run if no results are available
...
If there are no cached results the current implementation was also returning an empty array,
but this was the same as when there was a successful run.
So to distinguish this we return `null` if there are *no* results.
In this case we need to rerun the integrity checker.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-03 11:37:49 +07:00
dae7c159f7
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-24 13:11:22 +07:00
0a79884abf
feat(appconfig): switching integrity check to lazy config values
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-03-11 10:59:43 +07:00
6c49e9c68a
Revert "switching to new IAppConfig"
...
This reverts commit c693c58d25
2024-01-30 18:37:09 +07:00
c693c58d25
switching to new IAppConfig
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-30 18:33:50 +07:00
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-23 10:36:13 +07:00
e7cc7653b8
Refactors "strpos" calls in lib/private to improve code readability.
...
Signed-off-by: Faraz Samapoor <fsamapoor@gmail.com>
2023-05-15 15:17:19 +07:00
c7bb540d08
Merge pull request #36895 from apasov/patch-1
...
Fix json_decode expecting a string
2023-05-08 21:20:38 +07:00
426c0341ff
Use typed version of IConfig::getSystemValue as much as possible
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-05 12:50:08 +07:00
3a11f91dee
Update Checker.php
...
Signed-off-by: Ilya Apasov <apasov@users.noreply.github.com>
2023-02-28 13:39:02 +07:00
f5c361cf44
composer run cs:fix
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:45:08 +07:00
50ed84fe17
Simlify tests for integrity check on modified mimetype lists
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-06-07 21:54:27 +07:00
215aef3cbd
Update php licenses
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +07:00
fcbbcacab4
Also load CA properly in integrity check
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-20 10:57:41 +07:00
90c3013d40
Cleanup the constructor
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-18 11:32:50 +07:00
f319660f60
Force run the verification of the signature on occ
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-18 11:32:50 +07:00
d89a75be0b
Update all license headers for Nextcloud 21
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-16 18:48:22 +07:00
cb057829f7
Update license headers for 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-29 11:57:22 +07:00
28f8eb5dba
Add visibility to all constants
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:54:27 +07:00
caff1023ea
Format control structures, classes, methods and function
...
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.
This also removes and empty lines from method/function bodies at the
beginning and end.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +07:00
2fbad1ed72
Fix (array) indent style to always use one tab
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 10:16:08 +07:00
5bf3d1bb38
Update license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-05 15:38:45 +07:00
ea2d75c2b4
Remove empty lines
...
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
2019-07-04 09:38:30 +07:00
9211e34aec
Added Tests for modified mimetypelist
...
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
2019-07-04 09:35:36 +07:00
1d434cbac6
Update lib/private/IntegrityCheck/Checker.php
...
Co-Authored-By: Morris Jobke <hey@morrisjobke.de>
2019-05-31 17:04:04 +07:00
9a7e19771f
Fix indentation
...
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
2019-05-29 22:52:45 +07:00
d227f4d34c
Do not fail integrity check if mimetype list is changed
...
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
2019-05-29 22:43:23 +07:00
c6a69ba925
Remove the upload and memory setting
...
* Remove unneeded private method phpFileSize()
* Bump autoloader
* Remove setUploadLimit tests
* Remove integrity check hacks for upload limit
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-03-04 12:14:22 +07:00
72e745be26
Handle strict typing in Checker and fix tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-21 21:09:08 +07:00
4d5f2e64a5
Make OC\IntegrityCheck strict
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-21 13:27:29 +07:00
d2d73f1ce8
Also replace all other occurences
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-12-18 20:57:11 +07:00
0eebff152a
Update license headers
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-11-06 16:56:19 +07:00
5a6e29e4a8
Remove ownCloud Root Authority as per todo
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-03-22 08:54:40 +07:00
091bf07385
Merge pull request #2724 from nextcloud/fix-23591
...
[downstream] Report failures for SignApp and SignCore
2016-12-21 13:03:13 +07:00
3eb3e437c8
Add proper tests
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-12-19 15:35:31 +07:00
852de31ecb
Consider all channel except blank and git to be signed
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-12-16 18:07:30 +07:00
876754a5a5
Check return value for file_put_contents. Add return value to the commands
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-12-16 17:50:58 +07:00
a3c8534b7b
Make sure memory limit is > post size and upload filesize
2016-09-13 16:50:36 +07:00
fb4850ffa8
Fix intergrity checker
...
* Set salt length to 0
See https://tools.ietf.org/html/rfc3447#page-38
* Fix tests for new phpunit
2016-09-07 22:09:29 +07:00
ba87db3fcc
Fix others
2016-07-21 18:13:57 +07:00
19f770d0db
Port 2d373416d8 to master
2016-07-21 01:43:32 +07:00
977db0a162
Use proper certificates
...
Ports bcf693539b
2016-07-21 01:34:11 +07:00
e677ad56fd
Make code integrity check work when OC is not installed yet
2016-06-24 10:24:41 +07:00
Ferdinand Thiessen
Côme Chilliet
John Molakvoæ (skjnldsv)
Louis Chemineau
Julius Knorr
provokateurin
Andy Scherzinger
Maxence Lange
Joas Schilling
Faraz Samapoor
Arthur Schiwon
Ilya Apasov
Roeland Jago Douma
Christoph Wurst
Xheni Myrtaj
Morris Jobke
Lukas Reschke
Victor Dubiniuk
Vincent Petry