600381f82a
Make the migration template typed
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-15 16:08:50 +07:00
d9015a8c94
Format code to a single space around binary operators
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-05 20:25:24 +07:00
634c051be6
add size index for filecache
...
improves performance of #23004
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-09-22 15:15:34 +07:00
99c9423766
Remove @suppress SqlInjectionChecker
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-16 15:53:56 +07:00
2a054e6c04
Update the license headers for Nextcloud 20
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-24 14:54:25 +07:00
0157e30ad4
Merge pull request #21599 from nextcloud/debt/noid/type-to-types
...
Replace TYPE with TYPES
2020-07-02 12:21:01 +07:00
87dd760a89
Replace TYPE with TYPES
...
As TYPE::* is deprecated.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-06-30 23:46:22 +07:00
ab21d69903
Add return value to all commands
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-26 14:54:51 +07:00
6e28c2807b
Add index to properties table
...
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2020-04-30 23:04:15 +07:00
cb057829f7
Update license headers for 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-29 11:57:22 +07:00
caff1023ea
Format control structures, classes, methods and function
...
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.
This also removes and empty lines from method/function bodies at the
beginning and end.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +07:00
14c996d982
Use elseif instead of else if
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 10:35:09 +07:00
41b5e5923a
Use exactly one empty line after the namespace declaration
...
For PSR2
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 11:48:10 +07:00
bc6a5ef5c4
Merge pull request #19890 from nextcloud/enh/comments-reference-id
...
Add optional comments reference_id
2020-04-02 11:34:21 +07:00
1a9330cd69
Update the license headers for Nextcloud 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-31 14:52:54 +07:00
720dc4e93d
Add optional column oc_comments.reference_id
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-03-31 10:51:15 +07:00
6127c288e8
Fix license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-01-13 14:23:49 +07:00
6a017eb205
Introduce new variable with the default answer to allow option --no-interaction for command occ db:convert-type
...
Variable is set to true for --no-interaction and false otherwise
Signed-off-by: Bernhard Ostertag <bernieo.code@gmx.de>
2019-12-29 11:03:51 +07:00
fe0e47bf5e
enable option '--no-interaction' for db:convert-type
...
Signed-off-by: Bernhard Ostertag <bernieo.code@gmx.de>
2019-12-27 07:50:30 +07:00
1b46621cd3
Update license headers for 18
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-20 09:23:25 +07:00
699f3a6817
Convert various columns in oc_mounts to bigint
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-12-09 14:13:18 +07:00
5bf3d1bb38
Update license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-05 15:38:45 +07:00
279c0cb2ed
Merge pull request #18098 from nextcloud/fix/migration_import_order
...
Fix the import order of new migrations
2019-11-25 14:11:09 +07:00
c7d5b8fc49
Merge pull request #18079 from nextcloud/fixes/phpcs
...
Some php-cs fixes
2019-11-25 14:07:00 +07:00
20ec763337
Merge pull request #18027 from str0g/fix/14920/convert_type_boolean
...
Incorrect integer value: '' for column 'password_invalid' while migra…
2019-11-25 11:37:45 +07:00
f79d98e089
Fix the import order of new migrations
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-25 09:46:39 +07:00
68748d4f85
Some php-cs fixes
...
* Order the imports
* No leading slash on imports
* Empty line before namespace
* One line per import
* Empty after imports
* Emmpty line at bottom of file
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-22 20:52:10 +07:00
decdb6b40f
Convert more columns to bigint
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-20 19:31:17 +07:00
23084558a6
Incorrect integer value: '' for column 'password_invalid' while migrating from pg to mysql #14920
...
Signed-off-by: Łukasz Buśko <busko.lukasz@pm.me>
2019-11-20 14:01:46 +07:00
68cf47e947
Check and add index on principaluri for schedulingobjects table
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2019-10-08 10:25:56 +07:00
90e5850cc4
Add index on calendarid for calendarobject_props table
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2019-10-07 22:03:15 +07:00
592093079f
Deduplicate index names
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-03-27 13:32:59 +07:00
274658629d
Make sure all tables have named indexes
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-03-27 13:32:59 +07:00
8002779200
add support for boolean default
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
code cleaning
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
code cleaning
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2019-01-09 11:21:14 +07:00
16cc68a2fe
Add twofactor_providers_uid index
...
Fixes #12943
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-12-21 13:03:02 +07:00
17b2827bbf
Add setup check for pending bigint conversion
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-12-05 13:42:31 +07:00
f57e334f83
Fix bigint conversion on SQLite
...
* on SQLite primary keys can't be bigint - see https://stackoverflow.com/a/18835967/520507
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-12-05 00:35:09 +07:00
d3b4127164
Show columns to update in CLI interface
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-12-05 00:35:09 +07:00
bb352fb667
Use the defined func()->count() instead of manual counting
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-11-08 15:44:45 +07:00
4d20c4272f
Fix index names
...
* see #11527
2018-11-06 15:21:16 +07:00
b82cbe04df
Add uid_owner and uid_initiator share tabe indices
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-01 23:59:36 +07:00
c5cd8d9166
Improve class import and strict typing for generated migration class
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-09-07 09:22:57 +07:00
eada4cccfc
Fix generated migration class code
...
The `@since` documentation is out of place here.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-08-21 07:50:12 +07:00
7da815bb04
Merge pull request #10298 from nextcloud/bugfix/talk-714/only-migrate-the-schema-when-moving-database
...
Only create the schema when moving between databases
2018-07-24 16:14:05 +07:00
91d3e48ab3
Add filecache index on mtime
...
Gives searching by mtime and "recent" a proper index to use
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-07-19 17:43:20 +07:00
891de38080
Only create the schema when moving between databases
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-19 15:32:36 +07:00
2f59f389d2
Add parent index to share table
...
Fixes #9327
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-03 13:36:02 +07:00
b40629ac8c
Add human readable description to migration steps
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-05-30 21:28:05 +07:00
80cc8d0028
Emit event when running ./occ db:add-missing-indices
...
This allows apps to listen to this event in order to also update
indecies there.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-24 18:03:10 +07:00
f772b7b4dd
Add autocomplete to migration commands
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-05-03 16:52:56 +07:00
3be2c558a5
Add mtime and storage_mtime to db:convert-filecache-bigint
2018-02-17 09:27:25 +07:00
4a5282ba21
Fix the type hints of migrations and correctly inject the wrapped schema into migrations
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-17 11:37:36 +07:00
41ee23a054
make occ command more generic
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2017-12-18 21:14:45 +07:00
fda98ee917
add occ command to add a index to share_with at the share table
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2017-12-18 21:14:45 +07:00
0eebff152a
Update license headers
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-11-06 16:56:19 +07:00
6acf1d9524
Also update the activity table with this
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-10-13 11:46:50 +07:00
e2ec6b33ea
Add a command to manually migrate to big ints
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-10-13 11:42:15 +07:00
d5c2b98207
Fix missing "unsigned" on integer columns
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-09-19 20:09:10 +07:00
f877096a28
Fix typo in template for migration generation
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-08-09 11:01:08 +07:00
b729cc2a02
Add *lob support for all tables
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-07-25 12:49:15 +07:00
087138f228
use template placeholders instead of html
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-07-25 12:49:15 +07:00
e023899078
Always order by all values, to make sure all entries are copied correctly
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-07-25 12:49:15 +07:00
1b7c1ad5c0
Only migrate to the current state
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-07-25 12:49:15 +07:00
10d7cbb71f
Use order by to avoid problems when chunking finds a same item again...
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-07-25 12:49:12 +07:00
0a0dbbdf15
Remove generate change script which doesnt work with migrations anymore
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-07-25 12:47:39 +07:00
3fedfe67b9
Use default connection parameters for utf8 4byte support
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-07-25 12:47:39 +07:00
42ed7a18cc
Skip migrations table because it was already done when creating the schema
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-07-25 12:47:39 +07:00
1d56b52761
Use migrations on convert
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-07-25 12:47:39 +07:00
9307aaee49
Core is converted, so this is dead code
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-07-25 12:47:39 +07:00
f6c48b1548
Add a script to generate a migration from database.xml
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-07-25 12:45:38 +07:00
3d2600b039
Add Phan plugin to check for SQL injections
...
This adds a phan plugin which checks for SQL injections on code using our QueryBuilder, while it isn't perfect it should already catch most potential issues.
As always, static analysis will sometimes have false positives and this is also here the case. So in some cases the analyzer just doesn't know if something is potential user input or not, thus I had to add some `@suppress SqlInjectionChecker` in front of those potential injections.
The Phan plugin hasn't the most awesome code but it works and I also added a file with test cases.
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2017-07-20 22:48:13 +07:00
0f275b1550
Only create the migration directory when necessary
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-07-06 09:58:39 +07:00
5d9d1b1cb5
Allow to check the schema in pre and post as well
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-07-05 13:01:19 +07:00
817783e4c7
Add a version to migrations, so parallel legacy branches can also have migrations
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-07-05 13:01:19 +07:00
df6b839b23
Add author and copyright
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-07-05 13:01:19 +07:00
8c39e66619
Do not allow to go back on productive systems
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-07-05 13:01:19 +07:00
194ef1a171
Adjust the code to use our interface and abstract
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-07-05 13:01:19 +07:00
15eec7b83c
Start migrations
...
Fixme:
- Install and update of apps
- No revert on live systems (debug only)
- Service adjustment to our interface
- Loading via autoloader
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-07-05 13:01:19 +07:00
43427e26d7
Add console command to migrate the charset
2017-04-28 09:35:36 +07:00
75eee315a3
Use false because null crashes the cache
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-03-26 22:43:19 +07:00
2961c735e3
Make sure blob columns are correctly converted as parameters
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-03-26 17:11:57 +07:00
8a4466f9ae
Improve error message of charset convert script and behaviour
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-03-23 15:36:22 +07:00
3329f44a76
Address comments
...
* fix URL to documentation
* improve logic of UTF8mb4 check
* fix connection parameter creation - it's done already in ConnectionFactory::createConnectionParams
* remove unused attributes of MDB2SchemaReader
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-03-21 16:42:42 +07:00
713f684a8b
Adding tests for 4 byte unicode characters
...
* success on SQLite and Postgres
* failure on MySQL due to the limited charset that only supports up to 3 bytes
Add config option to update charset of mysql to utf8mb4
* fully optional
* requires additional options set in the database
only disable unicode test on mysql
Fixing ctor call
Adding docker based unit test execution for mysql utf8mb4
Add mysqlmb4 test configuration to Jenkinsfile
fix collation on utf8mb4
Properly setup charset and collation in the doctrine connection
Allow files containing 4-byte chars in case the database supports it
During setup of a mysql database we try to detect if charset 'utf8mb4' can be used
Fix mysql settings
Add console command to migrate the charset
Set ROW_FORMAT before setting collation to mb4
Also select tables with wrong collation
Faster MySQL docker
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-03-21 16:42:12 +07:00
8906b1cc95
Add autocomplete for db:* and log:*
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-09-29 15:57:10 +07:00
4b8de8ba8e
Fix dbconvert
2016-09-06 21:20:02 +07:00
3101f9e234
Rebranded to Nextcloud for the occ command line tool
2016-07-30 15:39:32 +07:00
ba87db3fcc
Fix others
2016-07-21 18:13:57 +07:00
df4d6063d0
Chunk the "db:convert-type" select queries, to not run out of memory so fast
2016-05-13 10:04:10 +07:00
a4b19a5b1e
Rename files to be PSR-4 compliant
2016-04-06 11:00:52 +07:00
Joas Schilling
Christoph Wurst
Robin Appelman
Morris Jobke
Roeland Jago Douma
Daniel Kesselberg
Mario Danic
Joas Schilling
Bernhard Ostertag
Georg Ehrke
Roeland Jago Douma
Łukasz Buśko
Thomas Citharel
Maxence Lange
Alecks Gates
Bjoern Schiessle
Lukas Reschke
Thomas Müller
Sander Ruitenbeek
Joas Schilling
Lukas Reschke