Commit Graph

13584 Commits (feat/database/query-result-fetch-associative-fetch-num)

Author SHA1 Message Date
Daniel 51833a50b8
Merge pull request #39723 from nextcloud/removed-apc-extension-version-check
chore: remove version check for apc extension
2023-08-10 18:17:31 +07:00
Daniel Kesselberg 7cab58237d chore: remove version check for apc extension
APC is gone since PHP 7.0.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-08-10 15:02:19 +07:00
Daniel Kesselberg 32303b6ed5 docs: remove superfluous phpdocs
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-08-10 15:01:56 +07:00
Daniel Calviño Sánchez 41f2d912d2 Allow "wasm-unsafe-eval" in CSP
If a page has a Content Security Policy header and the `script-src` (or
`default-src`) directive does not contain neither `wasm-unsafe-eval` nor
`unsafe-eval` loading and executing WebAssembly is blocked in the page
(although it is still possible to load and execute WebAssembly in a
worker thread).

Although the Nextcloud classes to manage the CSP already supported
allowing `unsafe-eval` this affects not only WebAssembly, but also the
`eval` operation in JavaScript.

To make possible to allow WebAssembly execution without allowing
JavaScript `eval` this commit adds support for allowing
`wasm-unsafe-eval`.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2023-08-10 02:38:41 +07:00
Simon L 46dfb84bca log imaginary errors as info to not spam the server logs
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-08-09 16:10:27 +07:00
Julius Härtl fca1c309a0
feat: Add delete task API
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-08-07 13:27:53 +07:00
Julien Veyssier 05a6a799a7
change sql where order to match index order
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2023-08-07 13:27:53 +07:00
Julien Veyssier 41b19cf969
allow anon text processing scheduling
add a textprocessing_tasks index
convert anotations to method attributes
refactor TP manager
add mapper methods

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2023-08-07 13:27:53 +07:00
Julien Veyssier 9986e02097
start implementing ocs endpoint to get task list from user+appId+identifier
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2023-08-07 13:27:53 +07:00
John Molakvoæ b27a2e9ec5
Merge pull request #39698 from joshtrichards/invalid-source-storage-path-catch 2023-08-05 12:17:33 +07:00
John Molakvoæ 7b7d1e3c09
fix: simplify `sourceData` check
Co-authored-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2023-08-05 12:05:36 +07:00
Joas Schilling 44b4c16a09
Merge pull request #39605 from nextcloud/bugfix/noid/final-events-cleanup
fix!: Final round of moving to IEventDispatcher
2023-08-04 10:39:57 +07:00
Josh Richards deecb48e54
Catch more invalid cache source storage paths
OC\Files\Cache\Cache::get can return string|false|null, not just string|false.

- nextcloud/server#26270 added handling of false, but null is needed too.
- Well, or we change the default $resullt to false, but I'm not sure if that has other ramifications and the real need here is to simply catch situations where the cache source storage path is not valid for whatever reason

Related: nextcloud/server#19009

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2023-08-03 09:53:46 +07:00
Marcel Klehr ad3f353335
Migration: Drop llm_tasks table and add textprocessing_tasks
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-08-02 12:37:36 +07:00
Marcel Klehr 2a3ef102f7
AI admin settings: Use config values in AI feature managers
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-08-02 12:37:35 +07:00
Daniel Kesselberg f1d4f7c7e4
fix: copy-and-delete fallback should use unlink
because rmdir does not work for files.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-07-31 21:41:25 +07:00
Daniel Kesselberg b4ff557b8c fix(storage): fallback to copy and unlink when rename fails
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-07-31 18:54:21 +07:00
Julius Härtl 286cceebc3
Merge pull request #39629 from ir0nhide/fix/sse-c 2023-07-31 18:05:48 +07:00
jld3103 38db3873a2
provisioning_api: Add OpenAPI spec
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-07-31 10:29:08 +07:00
Tobias Zimmerer 23f85b5ac2 fix(s3): add SSE-C parameters to headObject call
Signed-off-by: Tobias Zimmerer <3228193+ir0nhide@users.noreply.github.com>
2023-07-30 22:54:58 +07:00
Robin Appelman fda820a64d
expose MovableMount in public interface
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-07-28 14:42:09 +07:00
Joas Schilling 3962cd0aa8
fix!: Move getEventDispatcher usage to IEventDispatcher
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:22 +07:00
Joas Schilling b9e2f494a1
chore!: Remove legacy SymfonyAdapter
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:22 +07:00
Joas Schilling 0c5d0c2127
fix: Migrate collaboration listener and remove legacy adapter
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:21 +07:00
Joas Schilling cebf93d4d2
fix: Remove legacy dispatcher from share manager
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:20 +07:00
Joas Schilling 22e033b628
feat!: Migrate Share accepted event to typed event
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:20 +07:00
Joas Schilling 8ad94cbfda
feat!: Migrate unShare events to typed events
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:20 +07:00
Joas Schilling 44b810bfbd
feat!: Migrate Sharing events to typed events
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:19 +07:00
Joas Schilling 68fc9b48c2
feat!: Migrate AccountManager event to typed event
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:19 +07:00
Joas Schilling 53392861ff
Merge pull request #39473 from nextcloud/fix/parallel-aware-job
fix(IParallelAwareJob): Check for other reserved jobs before setting new ones as reserved
2023-07-28 13:15:10 +07:00
Arthur Schiwon ff2b36ad52
Merge pull request #37624 from nextcloud/fix/logging-for-failed-fopen
fix: log fopen calls when stream isn't available
2023-07-28 12:59:52 +07:00
Marcel Klehr 9f4b3de03c Fix ParallelAwareJob tests
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-28 11:12:32 +07:00
Joas Schilling 80f79e170d
fix!: Remove symfony EventDispatcherInterface from Group
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 23:13:37 +07:00
Joas Schilling ad12a740cb
fix!: Remove symfony EventDispatcherInterface from User
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 23:13:37 +07:00
Joas Schilling 6b7221756c
Merge pull request #39571 from nextcloud/bugfix/noid/move-lib-to-IEventDispatcher
Move lib/ events to IEventDispatcher where possible
2023-07-27 18:59:42 +07:00
Marcel Klehr 424937fd39 fix(SystemTagManager): Use truncated tagName in getTag and updateTag
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-27 13:56:11 +07:00
Joas Schilling 35c313e280
fix!: Remove User events which have a typed event replacement
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:54 +07:00
Joas Schilling c67c067ee7
fix: Move Sharing events to IEventDispatcher
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:53 +07:00
Joas Schilling 44a0a62107
fix: Move Node HookConnecter events to IEventDispatcher
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:53 +07:00
Joas Schilling 6953e14580
fix: Move SystemTags events to IEventDispatcher
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:52 +07:00
Joas Schilling dac31ad101
fix!: Remove legacy event dispatching Symfony's GenericEvent from 2FA Manager
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:52 +07:00
Joas Schilling 1b387bb341
fix!: Remove legacy event dispatching Symfony's GenericEvent from AdditionalScripts
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:52 +07:00
Joas Schilling 5bb6a7804f
fix: Move AppManager events to IEventDispatcher
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:51 +07:00
Joas Schilling 4f7de8ed60
fix!: Remove legacy event dispatching Symfony's GenericEvent
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:51 +07:00
Joas Schilling 7548e62181
Merge pull request #39506 from nextcloud/techdebt/39488/ensure-index-name-uniqueness
feat(db): Ensure that index names are unique across the database
2023-07-24 14:44:37 +07:00
Marcel Klehr 7c80d66ee5
Merge pull request #38854 from nextcloud/enh/llm-api 2023-07-21 11:20:31 +07:00
Benjamin Gaussorgues e9b8a34cce
Merge pull request #39264 from nextcloud/feat/add-instance-category
Add instance category while checking new updates
2023-07-21 11:04:32 +07:00
Anna af6bb98b14
Merge pull request #39504 from nextcloud/fix/caldav/access-typed-searchquery-property-without-init
fix(caldav): Assign initial value to typed CalendarQuery properties
2023-07-20 23:49:12 +07:00
Robin Appelman 31f1ff87d0
Merge pull request #39367 from nextcloud/s3-fopen-exception
handle more exceptions in AmazonS3::fopen
2023-07-20 19:32:03 +07:00
Robin Appelman 70a9d66aa8
Merge pull request #39275 from nextcloud/log-backtrace
Add optional to add backtrace to log items
2023-07-20 19:30:21 +07:00
Robin Appelman c912a3f0f6
Merge pull request #38860 from nextcloud/scanner-change-summary
add summary of detected changes to files:scan output
2023-07-20 18:37:07 +07:00
Anna Larch 70a6eeed3e fix: log fopen calls when stream isn't available
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-07-20 17:28:25 +07:00
Hamid Dehnavi 495683c358 Make adjustments based on the review
Co-authored-by: Faraz Samapoor <f.samapoor@gmail.com>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
2023-07-20 16:22:10 +07:00
Joas Schilling 0bf738d8cb
feat(db): Ensure that index names are unique across the database
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-20 14:27:26 +07:00
Christoph Wurst 2d3d396dd3
fix(caldav): Assign initial value to typed CalendarQuery properties
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-07-20 13:28:52 +07:00
Joas Schilling a4dd35e442
Merge pull request #39490 from nextcloud/bugfix/noid/fix-loading-infoxml
fix(apps): Fix loading info.xml file
2023-07-20 12:08:18 +07:00
Julius Härtl 77f249726d
Merge pull request #38934 from nextcloud/bugfix/noid/ssec-multipart 2023-07-20 11:00:08 +07:00
Joas Schilling 2014e7b836
fix(apps): Fix loading info.xml file
Ref: https://bugs.php.net/bug.php?id=62577

Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-20 10:40:09 +07:00
Marcel Klehr fd0fd97a65 Fix tests: Adjust constructor signature
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-19 17:32:28 +07:00
Marcel Klehr 7389567c7d Remove Task::factory method
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-19 13:15:14 +07:00
Benjamin Gaussorgues 31f1354777
Add instance category while checking new updates
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-07-18 15:39:23 +07:00
Ferdinand Thiessen 3b057600d0 fix: Correctly add `module` content type to script tags when scripts with versions are used
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-07-18 13:10:37 +07:00
Johannes 6d150c0700
Merge pull request #38907 from nextcloud/mail/fix/8551/contact-manager-search
Fix: ContactManager search with fullmatch
2023-07-18 10:40:43 +07:00
Côme Chilliet de4c2196a1
Merge pull request #39309 from nextcloud/bug/35766/fix-get-uid-on-nullable
fix(profile): fix getUID on nullable user variable
2023-07-17 14:45:00 +07:00
Marcel Klehr 590eefea70
Apply suggestions from code review
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-17 11:11:16 +07:00
Marcel Klehr ffe27ce14c Massive refactoring: Turn LanguageModel OCP API into TextProcessing API
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-14 16:00:31 +07:00
Anna 49b6541498
Merge branch 'master' into fix/correct-exceptions-for-SAB 2023-07-14 14:08:57 +07:00
Marcel Klehr 1d40f86d58
Merge pull request #39339 from nextcloud/fix/noid/d404-nosearch 2023-07-13 16:09:45 +07:00
Robin Appelman b0e663fa28
fix SeekableHttpStream::stream_stat errors on failed open
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-07-13 15:38:58 +07:00
Faraz Samapoor d1673ca3b8
Update lib/private/Profile/Actions/FediverseAction.php
Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-07-13 09:17:57 +07:00
jld3103 1be836273d
core: Add OpenAPI spec
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-07-13 07:24:15 +07:00
Arthur Schiwon f2642fcceb
fix(node): non-existing folder is not searchable
the previosuly introduced searchBySystemTag was not overwritten in
NonExistingFolder and could run the inherited method.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-07-13 00:01:32 +07:00
Thomas Citharel cd9dac1d20
fix(profile): fix getUID on nullable user variable
As per method signature, $visitingUser is nullable, so we can't be sure calling getUid() on it will
work.

Closes #35766

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2023-07-11 14:41:58 +07:00
Robin Appelman 61167e3149
Add optional to add backtrace to log items
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-07-10 15:27:31 +07:00
Marcel Klehr a4578cd995 cs:fix
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
Marcel Klehr 8f1a4f4255 LLM OCP API: Avoid using OC in OCP
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
Marcel Klehr 9ccc65d68c LLM OCP API: Simplify TaskBackgroundJob#run catch block
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
Marcel Klehr e810a8b66b LLM OCP API: Explain TaskBackgroundJob#setAllowParallelRuns
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
Marcel Klehr 05fcf31987 LLM OCP API: Don't lose trace of wrapped exceptions
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
Marcel Klehr 945522768e LLM OCP API: Simplify LanguageModelManager#canHandleTask
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
Marcel Klehr d56286b8ac LLM OCP API: s/getAvailableTasks/getAvailableTaskClasses/
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
Marcel Klehr a28d8fac2f LLM OCP API: Add missing copyright and strict types
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
Marcel Klehr 95d2bd50da Apply suggestions from code review
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
Marcel Klehr 0a0e812453 LLM OCP API: Fix psam error
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
Marcel Klehr f6f8cb4331 LLM OCP API: Add identifier param
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
Marcel Klehr fb657bfff8 cs:fix
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
Marcel Klehr 1747068e51 Fix LanguageModelManager#runTask: Insert task into db if it doesn't exist
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
Marcel Klehr 66c0e6b9f7 Make tests pass
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
Marcel Klehr 1623ad9eda TaskMapper#update: Use time factory
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
Marcel Klehr cb0f918d21 Add tasks::last_updated column and vacate tasks after a week
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
Marcel Klehr b00a9a6eae LLM OCP API: Use OCP\Common\Exception\NotFoundException
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
Marcel Klehr 8e4aa92167 Apply suggestions from code review
Co-authored-by: Daniel <mail@danielkesselberg.de>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
Marcel Klehr fac83ce4b6 LLM OCP API: Fix static analysis
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
Marcel Klehr b6941aa5c3 LLM OCP API: cs:fix
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
Marcel Klehr 795b097122 LLM OCP API: Implement ocs API
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
Marcel Klehr 82d3b00ab1 LLM OCP API: Add to RegistrationContext
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
Marcel Klehr 6fc4cb63ef LLM OCP API: Add db migration
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
Marcel Klehr 3413873653 LLM OCP API: Implement private backend code + add ILanguageModelTask
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
Anna 42aabd2d8b
Merge branch 'master' into fix/correct-exceptions-for-SAB 2023-07-07 12:45:31 +07:00
Benjamin Gaussorgues 45b3f6e2b3
Migrate federated file sharing to PSR LoggerInterface
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-07-07 09:00:35 +07:00
Hamid Dehnavi d0b20534b9 Refactor "substr" calls to improve code readability
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
2023-07-07 04:54:20 +07:00
Christoph Wurst 14719110b9 chore: Replace \OC::$server->query with \OCP\Server::get in /lib
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-07-06 15:21:22 +07:00
Anna Larch 558e386e46 fix(CardDAV): catch right exception when checking for federated app classes
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-07-06 13:07:14 +07:00
Arthur Schiwon 86e7af1d82
Merge pull request #38978 from fsamapoor/refactor_lib_private_accounts
Refactors lib/private/Accounts classes
2023-07-05 15:52:34 +07:00
Joas Schilling 75a15dcfe4
Merge pull request #38955 from nextcloud/bugfix/noid/dont-use-or
fix(eventdispatcher): Don't use all evaluating "or"
2023-07-05 14:40:10 +07:00
Faraz Samapoor 0133515644 Renames the property to improve the code readbility/clarity.
Based on:
 https://github.com/nextcloud/server/pull/38978#pullrequestreview-1514202944

Co-authored-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-07-05 14:23:09 +07:00
Arthur Schiwon c5285d68b1
Merge pull request #39086 from nextcloud/bugfix/noid/migrate-admin_audit-to-IEventDispatcher
feat(admin_audit): Migrate to non-deprecated IEventDispatcher
2023-07-05 12:05:11 +07:00
Arthur Schiwon 74d78fb656
Merge pull request #39012 from fsamapoor/refactor_lib_private_security_part2
[2/3] Refactors lib/private/Security
2023-07-05 12:02:27 +07:00
Joas Schilling 21821d8303
Merge pull request #38910 from nextcloud/fix/nullish-trim-deprecation-warning
Cast string type for trim()
2023-07-05 07:53:25 +07:00
Richard Steinmetz c4eccbb304
fix(sse): don't update uncached files
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2023-07-04 12:42:29 +07:00
Joas Schilling eb09053897
feat(admin_audit): Migrate to non-deprecated IEventDispatcher
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-04 12:36:30 +07:00
Joas Schilling 75d5fa4115
Merge pull request #39089 from nextcloud/bugfix/39087/fix-2fa-event-names
Fix event names of 2FA related typed events
2023-07-03 15:38:28 +07:00
Joas Schilling 05aa39d777
Fix event names of 2FA related typed events
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-03 14:25:01 +07:00
Christoph Wurst 67709b390a
Merge pull request #39057 from nextcloud/feat/ocp/type-icapabilities
feat(ocp): More specific type for ICapabilities::getCapabilities
2023-07-03 11:29:58 +07:00
Côme Chilliet b2f01b72fe
Merge pull request #34443 from nextcloud/feat/add-enabled-user-backend
Add IProvideEnabledStateBackend interface
2023-07-03 10:19:32 +07:00
Christoph Wurst 95145ee0c9
feat(ocp): More specific type for ICapabilities::getCapabilities
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-07-03 10:03:45 +07:00
Faraz Samapoor 8cb078b58c Fixes testcase errors.
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-07-02 12:01:11 +07:00
Faraz Samapoor a1acacf032 Fixes Psalm error.
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-07-01 13:57:46 +07:00
Faraz Samapoor ed972439fc Refactors lib/private/Accounts.
Mainly using PHP8's constructor property promotion.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-07-01 13:57:46 +07:00
Git'Fellow 9d70fd3e64
Silent imagecreatefromstring() errors
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-06-30 21:58:44 +07:00
jld3103 b0001c6010
Add template types to responses
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-06-30 09:33:29 +07:00
Faraz Samapoor b4dd68f5b3 Refactors lib/private/Profile.
Mainly using PHP8's constructor property promotion.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-29 22:51:54 +07:00
Johannes Merkel 846754ed1a
fix(mail): ContactManager search with fullmatch
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
2023-06-29 16:48:56 +07:00
Arthur Schiwon 7b7148c206
Merge pull request #35915 from nextcloud/enh/noid/display-name-federated-shares
display displayname on federated shares
2023-06-29 14:40:26 +07:00
Daniel Kesselberg 3757f390c3
feat: replace id3parser with mp3info
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-06-28 14:58:59 +07:00
Maxence Lange d2efd0e03c displayname on federated shares
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-06-28 09:28:03 +07:00
Joas Schilling fbc63fe57c
Merge pull request #38613 from nextcloud/feat/35959/async-guzzle-requests
feat(HTTPClient): Provide wrapped access to Guzzle's asyncRequest()
2023-06-28 09:04:36 +07:00
Faraz Samapoor 9fa9975bc9 Refactors lib/private/Log.
Mainly using PHP8's constructor property promotion.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-28 09:29:45 +07:00
Julius Härtl eddb64f8c3
Merge pull request #37969 from nextcloud/poc/noid/systemtags-perf-tag-endpoint 2023-06-28 07:53:35 +07:00
Faraz Samapoor 57ff06576a Fixes psalm errors: RedundantCondition and TypeDoesNotContainNull.
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-27 21:21:21 +07:00
Pytal fa37574006
Merge pull request #39020 from fsamapoor/refactor_lib_private_mail 2023-06-27 10:18:03 +07:00
Joas Schilling ec6728d710
feat(HTTPClient): Provide wrapped access to Guzzle's asyncRequest()
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-06-27 15:53:57 +07:00
Christoph Wurst 266436b767
Merge pull request #38990 from fsamapoor/refactor_lib_private_calendar
Refactor lib/private/Calendar
2023-06-27 13:38:59 +07:00
Faraz Samapoor a449bd1a0c Adds same object return annotations.
Based on: https://github.com/nextcloud/server/pull/38987#discussion_r1241866676

Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-27 10:45:39 +07:00
Côme Chilliet 2d81c04514
Merge pull request #38881 from nextcloud/fix/logcondition-user
Fix user log.condition feature
2023-06-26 17:25:45 +07:00
Robin Appelman 39a0554c09
Merge pull request #38858 from nextcloud/scanner-performance3
file scanner performance improvements
2023-06-26 17:01:18 +07:00
Daniel 9751303182
Merge pull request #38679 from nextcloud/feat/add-spec-to-preview-fetched-event
feat: add width, height, crop and mode to BeforePreviewFetchedEvent
2023-06-26 13:53:27 +07:00
Faraz Samapoor e73757b4a5 Refactors lib/private/Security.
Mainly using PHP8's constructor property promotion.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-26 15:03:13 +07:00
Simon L f7183c9dcf
Merge pull request #38958 from nextcloud/enh/noid/use-getsystemvalue-mailer
use getsystemvalue-functions in Mailer.php
2023-06-26 10:23:29 +07:00
Côme Chilliet 8ed6086a82
Fix user log.condition feature
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-06-26 10:07:22 +07:00
F. E Noel Nfebe 2de859d6c7
Merge pull request #38987 from fsamapoor/refactor_lib_private_mail
Refactors lib/private/Mail.
2023-06-25 18:56:10 +07:00
Faraz Samapoor c6ebdca488 Refactors lib/private/Calendar.
Mainly using PHP8's constructor property promotion.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-25 13:58:30 +07:00
Faraz Samapoor dd67635560 Refactors lib/private/Avatar.
Mainly using PHP8's constructor property promotion.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-25 13:36:36 +07:00
Faraz Samapoor ba4f998b53 Refactors lib/private/Mail.
Mainly using PHP8's constructor property promotion.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-25 13:18:09 +07:00
Faraz Samapoor 9f2487d14b Refactors lib/private/Contacts.
Mainly using PHP8's constructor property promotion.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-25 11:56:58 +07:00
Arthur Schiwon 17515995fa
Merge pull request #38625 from nextcloud/fix/noid/querysearchehelper-narrow-type
fix: expect interface, not a specific implementation
2023-06-24 00:13:43 +07:00
Daniel Kesselberg 440f882322
feat: add width, height, crop and mode to BeforePreviewFetchedEvent
user_usage_report keeps a counter for files read.

The app uses

- OC_Filesystem::read hook
- Event listener (the legacy one) for IPreview::EVENT

Request for previews do not trigger the hook, hence the additional event listener.
The thumbnails for a list or grid view should not count, so we need the width and height.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-06-23 16:27:35 +07:00
Robin Appelman 493e151be0
dav: clean path before putting it in the statcache
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-06-23 14:39:17 +07:00
Simon L 76bedb8843 use getsystemvalue-functions in Mailer.php
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-06-23 11:16:02 +07:00
Joas Schilling 19a0425aeb
fix(eventdispatcher): Don't use all evaluating "or"
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-06-23 09:14:34 +07:00
Robin Appelman 7fa941e76f
Merge pull request #38945 from nextcloud/dav-meta-directory-content
implement optimized getDirectoryContent for DAV
2023-06-22 18:14:24 +07:00
Robin Appelman 279822c217
implement optimized getDirectoryContent for DAV
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-06-22 16:34:32 +07:00
Arthur Schiwon a0f9556f7c
fix: cominbation of small fixes
- possible null return
- parameter name mismatch in implementation
- incomplete unit test

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-06-21 20:28:01 +07:00
Arthur Schiwon 49db546f78
fix: include invisible tags for admins
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-06-21 20:28:01 +07:00
Julius Härtl ea575e342f
fix(s3): Pass SSE-C parameters for multipart upload
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-06-21 18:32:24 +07:00
Arthur Schiwon 221562d45d
feat: add searchBySystemTag as PHP API
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-06-21 18:19:09 +07:00
Arthur Schiwon 783e32a64d
fix: favorites view and universal search against tags
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-06-21 18:19:08 +07:00
Arthur Schiwon b0d1cf5730
fix: change if with conditionless else to switch; and a parameter value
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-06-21 18:19:08 +07:00
Arthur Schiwon 58f7fd2370
use efficient tag retrieval on DAV report request
- uses DAV search approach against valid files joined by systemtag selector
- reduced table join for tag/systemtag search
- supports pagination
- no changes to the output formats or similar

Example request body:

<?xml version="1.0"?>
<oc:filter-files xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns" xmlns:nc="http://nextcloud.org/ns" xmlns:ocs="http://open-collaboration-services.org/ns">
  <d:prop>
    <d:getcontentlength/>
    <d:getcontenttype/>
    <d:getetag/>
    <d:getlastmodified/>
    <d:resourcetype/>
    <nc:face-detections/>
    <nc:file-metadata-size/>
    <nc:has-preview/>
    <nc:realpath/>
    <oc:favorite/>
    <oc:fileid/>
    <oc:permissions/>
    <nc:nbItems/>
  </d:prop>
  <oc:filter-rules>
    <oc:systemtag>32</oc:systemtag>
  </oc:filter-rules>
  <d:limit>
    <d:nresults>50</d:nresults>
    <nc:firstresult>0</nc:firstresult>
  </d:limit>
</oc:filter-files>

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-06-21 18:19:08 +07:00
Arthur Schiwon 088a0eea29
ci: pro forma check of existence of internal method
createNode() is protected and used by Folder, but being an internal-only
method it shall not be exposed in the Folder or IRootFolder interface.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-06-21 16:53:20 +07:00
Arthur Schiwon 71e41ffeeb
refactor: declare getMount() and getMountsIn() at IRootFolder
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-06-21 16:53:20 +07:00
Arthur Schiwon f6ac874dbf
chore: ugly type juggling
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-06-21 16:53:20 +07:00
Arthur Schiwon 167a5f394d
fix: add typehine for IRootFolder
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-06-21 16:53:19 +07:00
Arthur Schiwon eb50b6c6aa
fix: expect interface, not a specific implementation
- fixes a regression when deleting folders while music app was enabled,
  for a LazyRoot was passed to this method.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-06-21 16:53:13 +07:00
Joas Schilling ab8205fd35
fix(l10n): Fix plural issue with different locale and language
We need to use the language code here instead of the locale,
because Symfony does not distinguish between the two and would
otherwise e.g. with locale "Czech" and language "German" try to
pick a non-existing plural rule, because Czech has 4 plural forms
and German only 2.

Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-06-21 07:14:56 +07:00
dartcafe 2211721c2b
fixed quotes
Signed-off-by: dartcafe <github@dartcafe.de>
2023-06-20 18:35:10 +07:00
dartcafe ed294f6e43
add type #38909
Signed-off-by: dartcafe <github@dartcafe.de>
2023-06-20 18:35:10 +07:00
Côme Chilliet d1d2542c79
Throw if creation date is read before inserting into database
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: dartcafe <github@dartcafe.de>
2023-06-20 18:35:10 +07:00
Carl Schwan 8f94fd0102
Cleanup comments code
- Fix various psalm issues
- Add as much typing as possible while preserving stable API

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: dartcafe <github@dartcafe.de>
2023-06-20 18:35:09 +07:00
Côme Chilliet 1603cdc8d2
Fix since annotations and add boolean return type for setUserEnabled
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-06-20 15:10:39 +07:00
Côme Chilliet 7aa97dcc23
Throw if creation date is read before inserting into database
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-06-20 12:14:57 +07:00
Carl Schwan 9725d00329
Cleanup comments code
- Fix various psalm issues
- Add as much typing as possible while preserving stable API

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2023-06-20 10:55:20 +07:00
Robin Appelman de85610385 use source cache when listing folder during recursive copy
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-06-19 16:40:15 +07:00
Robin Appelman 292c0e53f8
add summary of detected changes to files:scan output
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-06-16 17:56:34 +07:00
Robin Appelman 561536fc58
file scanner performance improvements
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-06-16 16:31:48 +07:00
Robin Appelman d9fa7b1e28
emit an event when a message is logged
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-06-13 18:45:48 +07:00
Kate 38d64f45be
Merge pull request #38745 from nextcloud/feature/ocs-xml-stdclass
Allow stdClass in XML responses
2023-06-13 13:30:55 +07:00
jld3103 7f4651637a
Allow stdClass in XML responses
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-06-13 11:44:47 +07:00
Dominik Fuchß e3f6a13e14 Fix deprecated method call
Signed-off-by: Dominik Fuchß <develop@fuchss.org>
2023-06-13 10:31:33 +07:00
Dominik Fuchß a4a57409db Changes after code review.
Signed-off-by: Dominik Fuchß <develop@fuchss.org>
2023-06-13 10:31:33 +07:00
Dominik Fuchß c3ba871f36 Add config variable for curl timeout
Add the config variable for curl calls ("remote_curl_timeout"). E.g., needed for nextcloud federation.

Signed-off-by: Dominik Fuchß <develop@fuchss.org>
2023-06-13 10:31:33 +07:00
Christoph Wurst b8c61b3515 fix(caching): Avoid checking existence before fetching
The cache might expire between checking for key existence and fetching
the value. In this rare case the code continues with a null value when
it doesn't expect one.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-12 09:44:48 +07:00
Robin Appelman 3ef5090084
Merge pull request #38226 from nextcloud/file-object-utils
add utility command for object store objects
2023-06-09 20:53:29 +07:00
Robin Appelman ea88ec1350
add utility command for object store objects
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-06-09 18:08:18 +07:00
Julien Veyssier 3621a6b4ec avoid requests to opengraph image if no host detected
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2023-06-09 10:37:58 +07:00
Ferdinand Thiessen e532419b15 fix(apache): Serve `mjs` (module javascript) as static files
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-06-07 15:19:44 +07:00
Julien Veyssier 633e9513e2
shorten oauth2 client names before resizing the column
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2023-06-06 15:27:46 +07:00
Julien Veyssier b2a75fcbfb
drop the oauth2_clients trusted column, delete unsupported clients and their access tokens
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2023-06-06 15:27:46 +07:00
Christoph Wurst 872c181c74
chore: Drop dead private methods in /lib
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-06 11:01:58 +07:00
Julius Härtl 3846ec2899
Merge pull request #38322 from nextcloud/bugfix/noid/throw-early-app-container 2023-06-06 08:41:08 +07:00
Simon L 702196dd86
Merge pull request #38478 from nextcloud/backport/38440/master
[master] fix: Catch Deadlock properly as execute throws Doctrine exceptions not our wrapped ones
2023-06-05 23:22:40 +07:00
Arthur Schiwon ffa30ce89b
Merge pull request #38524 from nextcloud/chore/app/clear-unused-cache-key
chore(app): Do not clear unused cache key
2023-06-05 17:48:44 +07:00
Daniel Kesselberg a2afc7b6a9
refactor: migrate OC_EventSource to dependency injection
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-06-03 21:42:51 +07:00
Joas Schilling fa4f476f01
Merge pull request #38545 from nextcloud/bugfix/noid/symfony/event-dispatcher-upgrade-preparation
fix(dispatcher): Migrate to OCP event dispatcher before symfony/event…
2023-06-02 09:50:58 +07:00
Christoph Wurst c0263b91d4
Merge pull request #38585 from nextcloud/feature/ocp/send-message-with-subject-body
feat(ocp): Allow sending emails with subject and body
2023-06-02 09:14:46 +07:00
Joas Schilling 6d076c1ee9
fix(dispatcher): Migrate to OCP event dispatcher before symfony/event-dispatcher upgrade
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-06-02 08:08:24 +07:00
Robin Appelman 9f1d497a0b
Merge pull request #38261 from fsamapoor/replace_strpos_calls_in_lib_private
Refactors "strpos" calls in  lib/private to improve code readability.
2023-06-01 23:10:00 +07:00
Robin Appelman e81fdfefab
Merge pull request #38568 from rawtaz/fix-redis-empty-password
redis: Do not try to authenticate with non-string password/user
2023-06-01 22:11:55 +07:00
Christoph Wurst 7f8f792558
feat(ocp): Allow sending emails with subject and body
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-01 18:10:05 +07:00
Leo R. Lundgren c52aaa3647 redis: Do not try to authenticate with non-string password/user
Signed-off-by: Leo R. Lundgren <leo@finalresort.org>
2023-06-01 13:08:57 +07:00