Commit Graph

82 Commits (feat/database/query-result-fetch-associative-fetch-num)

Author SHA1 Message Date
Arthur Schiwon 603a659a37
fix(autoloader): no apcu no side effects
apcu lead to side effects especially with app management and (soft)
inter-dependencies, and lead also to 500 server errors. While we could
add management to clear apcu cache in many cases (may stil leave edge
cases) the performance benefit is marginally as also class maps are
already cached in opcache. Hence, the simple and effective way to go is
to not use apcu for autoloading.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-09-08 16:55:39 +07:00
Git'Fellow 7306960f2c
Fix lint
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-08-13 00:21:54 +07:00
Git'Fellow 9237fba27b
Remove check for very old PGsql
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-08-13 00:15:18 +07:00
Faraz Samapoor e7cc7653b8 Refactors "strpos" calls in lib/private to improve code readability.
Signed-off-by: Faraz Samapoor <fsamapoor@gmail.com>
2023-05-15 15:17:19 +07:00
jld3103 04d840211f
Remove version check for ancient libxml version
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-05-05 19:07:55 +07:00
Arthur Schiwon bb4b34ff69 Read mtime of version.php only once
- in most cases it would read again in \OC_Util::loadVersion anyway
- remove some unused use statements

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-04-21 14:10:47 +07:00
Côme Chilliet 426c0341ff
Use typed version of IConfig::getSystemValue as much as possible
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-05 12:50:08 +07:00
Côme Chilliet 7a628c0361
Fix 32bits bigint support in Util/OC_Helper
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:30 +07:00
Côme Chilliet f5c361cf44
composer run cs:fix
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:45:08 +07:00
Julius Härtl 5e416c529e
Use proper storage method for writing skeleton files
otherwise the filecache will have a wrong size for skeleton files

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-10-27 08:47:32 +07:00
Carl Schwan 92a5a8f075 Cleanup tags and Share component
- Port to LoggerInterface
- Use IDBConnection and IQueryBuilder instead of raw SQL and OC_DB
- Use IEventListener instead of hooks
- Remove the now unused OC_DB and OC_DB_StatementWrapper legacy utils

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-09-29 15:15:28 +07:00
Carl Schwan d61efdff6c
Fix quota type to int
Change the quota to int from float, since the quota is a number of bits
and a bits can not be splitted.

Fix #34010

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-09-12 09:26:04 +07:00
Carl Schwan 53169890d6 Fix psalm errors fron the end of the baseline file
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-16 10:58:26 +07:00
Valdnet 71e31c3b86
l10n: Correct a typo
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-04-28 08:30:49 +07:00
Valdnet cb18220147
l10n: Fix code
Issue: #32171.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-04-27 09:04:00 +07:00
John Molakvoæ 036f871d01
Merge pull request #31492 from nextcloud/fix/check-secret-configured 2022-04-26 17:28:51 +07:00
Carl Schwan a29251e02d Allow to disable password policy enforcement for selected groups
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Co-authored-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-04-05 17:04:17 +07:00
Carl Schwan 0e58c113a5 Only check if secret is set if the nextcloud is installed
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-03-09 14:39:59 +07:00
Carl Schwan e6161af662 Also check for instanceid and passwordhash
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-03-09 13:36:06 +07:00
Carl Schwan 7496bf3461 Require the secret config to be configured
If it's not configured the instance will look like it is working but
various features will silently break (end to end encryption, setting
alternate email and probably more).

One issue is that changing the secret from empty to something will
break various other stuff (app token). I don't think there is a good way
to solve this issue other than breaking early instead of having to
handle a painful migration later on.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-03-08 23:11:08 +07:00
Robin Appelman 5c0fe93498
move teardown logic to SetupManager
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-04 16:29:50 +07:00
Robin Appelman 15ff65c12f
start moving filesystem setup logic to it's own place
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-04 16:29:47 +07:00
Robin Appelman 8b7c8447a0
move root mount setup to mountproviders
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-24 17:21:42 +07:00
Robin Appelman de260001f1
handle setupFS with null user
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-09 16:01:36 +07:00
Robin Appelman b799fd40e9
dont mark fs as setup when no user is active
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-09 16:01:31 +07:00
Robin Appelman 1ab58eff0f
pass user object during fs init
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-09 16:01:24 +07:00
Robin Appelman 0217949715
only setup part of the filesystem for appdata requests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-09 16:01:21 +07:00
John Molakvoæ 73e3d06781
Merge pull request #30855 from nextcloud/psalm/theming 2022-01-27 20:04:02 +07:00
Louis Chemineau 04c9de7312 Add deprecation notice to script & addScript func
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-27 11:04:30 +07:00
Carl Schwan e3a12b3482
Fix psalm issues in theming app
After this change, we are down to only one psalm warning for this app
and related to the Application.php. This also make composer
psam:update-baseline not silently ignore new errors.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-26 14:26:58 +07:00
Valdnet 5cb51916de
l10n: Add a text string to translation
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-12-20 08:52:12 +07:00
Valdnet bd1264ef7f
l10n: Add <code>
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-12-15 17:50:18 +07:00
Valdnet 4f99385311
l10n: Add <code>
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-12-15 17:47:41 +07:00
Valdnet ebc3169105
l10n: Separate words and add dots
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-12-15 17:37:00 +07:00
John Molakvoæ e296417ca2
Merge pull request #29527 from nextcloud/rakekniven-patch-1 2021-12-04 12:08:16 +07:00
John Molakvoæ (skjnldsv) 71a3528510
Allow scripts prioritization based on other apps
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-12-02 20:00:46 +07:00
John Molakvoæ c624c7eb5d
Merge pull request #29966 from nextcloud/feat/remove-isIE 2021-11-30 14:04:05 +07:00
John Molakvoæ (skjnldsv) a325141545
Remove isIE and associated legacy scripts
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-11-30 13:03:08 +07:00
MichaIng 0d749b7e9a Remove iconv from dependencies and tests
which is not used anymore since: https://github.com/nextcloud/server/pull/29470

Signed-off-by: MichaIng <micha@dietpi.com>
2021-11-30 02:33:12 +07:00
Naoto Kobayashi 6fc8694324 OC_Util::isNonUTF8Locale: fix lint error
Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
2021-11-16 21:05:43 +07:00
Naoto Kobayashi c42c972ab0 OC_Util::isSetLocaleWorking: fix typo
Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
2021-11-16 00:46:21 +07:00
Naoto Kobayashi e9b414fbe3 OC_Util: Add fallbacks to check if current locale is UTF8
Using escapeshellcmd to get current locale causes error
if the function is disabled.

Add fallbacks to prevent the error.

Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
2021-11-16 00:40:52 +07:00
Naoto Kobayashi d2eb5aaa6d Check whether setlocale works only after setlocale
Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
2021-11-14 09:18:59 +07:00
Naoto Kobayashi 455bff5c17 Fix missing setlocale with php 8
When php version = 8, basename('§') does not bug even if LC_ALL is non-UTF-8 locale.
This cause OC_Util::isSetLocaleWorking() to skip setlocale("C.UTF-8").

Fix it by using escapeshellcmd instead of basename.

Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
2021-11-14 09:18:59 +07:00
rakekniven b7d0babcb8
Added dot at end of sentence.
The full message in the UI is composed by a few strings. Therefore the single parts needs an dot at the end.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2021-11-02 22:11:31 +07:00
Daniel Rudolf aa455e71d9
Merge branch 'master' into enhancement/noid/IURLGenerator-linkToDefaultPageUrl 2021-08-04 18:52:55 +07:00
Daniel Rudolf e16bf707aa
Fix UtilTest::testDefaultApps()
Oh wow... This definitly was no best practice... 😒

Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-07-01 16:00:29 +07:00
Daniel Rudolf 2c7186a15f
Remove \OC::$server->getURLGenerator() usage
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-07-01 15:12:15 +07:00
Gary Kim b78f3a57d1
Migrate HintException to OCP
Signed-off-by: Gary Kim <gary@garykim.dev>
2021-06-30 15:28:02 +07:00
Daniel Rudolf 0df68f0697
Remove unused imports
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-06-30 16:48:22 +07:00