Commit Graph

363 Commits (feat/database/query-result-fetch-associative-fetch-num)

Author SHA1 Message Date
Hamid Dehnavi ea06cf2f39 Convert isset ternary to null coalescing operator
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
2023-09-28 17:44:19 +07:00
Robin Appelman 64f62f7cfd
Merge pull request #39863 from nextcloud/sharing-mask-wrapper
move share permission logic to storage wrapper
2023-09-04 14:05:14 +07:00
John Molakvoæ (skjnldsv) f828dce597
Fix sharing creation insert and get
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2023-09-02 10:25:24 +07:00
Benjamin Gaussorgues 303dadfaa9
sharebymail: remove ILogger and upgrade to PHP 8 syntax
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-08-30 18:36:29 +07:00
Côme Chilliet 24ad2e2dc4 Use nullsafe call syntax instead of additionnal check
Co-authored-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2023-08-28 09:40:12 +07:00
Côme Chilliet 8c9aa9a919 Set files_sharing:hide_disabled_user_shares to 'yes' to hide shares from disabled users
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-08-28 09:40:12 +07:00
Robin Appelman e73889a240 cleanup di for share permissions wrapper
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-08-16 15:25:05 +07:00
Joas Schilling cebf93d4d2
fix: Remove legacy dispatcher from share manager
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:20 +07:00
Joas Schilling 22e033b628
feat!: Migrate Share accepted event to typed event
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:20 +07:00
Joas Schilling 8ad94cbfda
feat!: Migrate unShare events to typed events
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:20 +07:00
Joas Schilling 44b810bfbd
feat!: Migrate Sharing events to typed events
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:19 +07:00
Joas Schilling c67c067ee7
fix: Move Sharing events to IEventDispatcher
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:53 +07:00
Benjamin Gaussorgues 45b3f6e2b3
Migrate federated file sharing to PSR LoggerInterface
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-07-07 09:00:35 +07:00
Faraz Samapoor e7cc7653b8 Refactors "strpos" calls in lib/private to improve code readability.
Signed-off-by: Faraz Samapoor <fsamapoor@gmail.com>
2023-05-15 15:17:19 +07:00
Côme Chilliet 426c0341ff
Use typed version of IConfig::getSystemValue as much as possible
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-05 12:50:08 +07:00
jld3103 d9f8522003
Fix types for reading and writing config values
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-04-05 09:08:56 +07:00
Robin Appelman 3473fa3187
also set the node when re-using existing share on share create
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-03 16:40:47 +07:00
Arthur Schiwon 28e7235f87
hide shared files located in group folder's trash bin
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-03-28 14:13:12 +07:00
Michiel de Jong c0e84cb512 Add SHARE_TYPE_SCIENCEMESH
Signed-off-by: Michiel de Jong <michiel@unhosted.org>
2023-03-08 16:46:55 +07:00
Louis Chemineau 4ab3c16403 Pluggable share provider
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-02-02 15:41:26 +07:00
Côme Chilliet f5c361cf44
composer run cs:fix
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:45:08 +07:00
Joas Schilling 2f7a1fca5f
Merge pull request #34477 from nextcloud/bugfix/noid/sharee-recommendations-show-group-id
Show group name instead of group id as recommendation
2022-12-09 22:39:28 +07:00
Joas Schilling 3dee71db20
Fix PHP CS
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-10-20 11:45:24 +07:00
Joas Schilling 9982909bc6
Also catch in getProvider
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-10-20 10:03:10 +07:00
Joas Schilling 40d8ed9edb
Don't crash with outdated share provider
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-10-20 09:21:15 +07:00
Carl Schwan 60313683e2 Fix checkpassword undocummented null parameter
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-17 12:38:21 +07:00
Joas Schilling 99953a859b
Show group name instead of group id as recommendation
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-10-08 16:05:52 +07:00
Carl Schwan 92a5a8f075 Cleanup tags and Share component
- Port to LoggerInterface
- Use IDBConnection and IQueryBuilder instead of raw SQL and OC_DB
- Use IEventListener instead of hooks
- Remove the now unused OC_DB and OC_DB_StatementWrapper legacy utils

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-09-29 15:15:28 +07:00
Carl Schwan a1011bad6c
Use bigger slice in share provider
Probably won't make a big difference as it is unlikely a user has > 100
shares but this make sure we use the same code in spreed where the
change has a bigger impact.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-16 11:17:27 +07:00
Julien Veyssier e251e0c314
don't reduce file public link permissions if public upload is not enabled
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2022-08-01 15:00:51 +07:00
Carl Schwan 7b723813ce
Multiple fixes
- Fix tests
- Use non deprecated event stuff
- Add a bit of type hinting to the new stuff
- More safe handling of instanceOfStorage (share might not be the first
  wrapper)
- Fix resharing

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-31 19:37:59 +07:00
Vincent Petry bbb5043c07
Inherit hide download from share attributes
When resharing by link, if the download permission was removed through
share attributes, convert it to the hide download flag.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:54:13 +07:00
Vincent Petry 2ee659e547
Fix view-only code after code review comments
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:24 +07:00
Vincent Petry dbbc426f75
Attempt to fix sqlite json issue
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:23 +07:00
Vincent Petry 03b1791cca
Fix share attribute related tests + code style
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:22 +07:00
Vincent Petry a95c19e14b
Add share attributes + prevent download permission
Makes it possible to store download permission

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:22 +07:00
luz paz 368f83095d Fix typos in lib/private subdirectory
Found via `codespell -q 3 -S l10n -L jus ./lib/private`

Signed-off-by: luz paz <luzpaz@github.com>
2022-07-27 08:52:17 +07:00
Louis Chemineau f525067930 Add argument to getSharesInFolder enable deep share lookup
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-07-26 12:17:46 +07:00
Louis Chemineau 0fb4ecadae Recursively fetch subshares
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-07-26 12:17:46 +07:00
Louis Chemineau ce7b6ffed2 Prevent column name conflict between tables
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-07-26 12:17:46 +07:00
Carl Schwan d5c23dbb9f Move CappedMemoryCache to OCP
This is an helpful helper that should be used in more place than just
server and this is already the case with groupfodlers, deck, user_oidc
and more using it, so let's make it public

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-14 15:54:31 +07:00
Louis Chemineau 347ca20f4e Rename setting name to reduce its length
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-06-27 11:04:17 +07:00
Carl Schwan 5c84d3781e
Merge pull request #32185 from nextcloud/fix/default-share-provider-oracle
Fix getting shares in a folder on Oracle
2022-05-12 20:58:05 +07:00
Carl Schwan 81500bf837 Fix getting shares in a folder on Orache
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-12 15:03:25 +07:00
Louis Chemineau e8ab298d2c Use email settings in DAV search
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-04-19 16:23:08 +07:00
Louis Chemineau 70c56b411e Use share setting in DAV search
shareapi_restrict_user_enumeration_full_match_ignore_second_display_name was introduced to ignore second display name during search from the share panel. But this setting was not respected by search from the calendar application. This fix it.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-04-19 12:51:57 +07:00
Vincent Petry 82f1344d33
Adjust settings for mail link password
Rename the settings and invert the meaning.
Increase default interval to one hour.
Changed the interval to be a number of seconds, to align with other
setting styles.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-04-14 14:13:47 +07:00
Vincent Petry 2c2b238008
Default to permanent link passwords
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-04-13 16:11:15 +07:00
Vincent Petry f5c8fa4f11
Properly reset pw expiration
When requesting a new password for share by mail link, now we correctly
reset the expiration date.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-04-13 15:46:30 +07:00
Vincent Petry 483741ff36
Merge pull request #31220 from nextcloud/enhancement/31005/temporary-passwords
Temporary passwords for public non-anonymous protected shares (ie: files shared with an email recipient).
2022-04-12 09:46:31 +07:00