4d2217073a
fix(comments): Use provided offset in best effort when loading comments
...
When we didn't find the "$lastKnownComment" the whole condition was ignored.
Now we still use the ID as an offset.
This is required as a fall-back for expired messages in Talk
and deleted comments in other apps.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-09-18 20:09:32 +07:00
7aa97dcc23
Throw if creation date is read before inserting into database
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-06-20 12:14:57 +07:00
9725d00329
Cleanup comments code
...
- Fix various psalm issues
- Add as much typing as possible while preserving stable API
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2023-06-20 10:55:20 +07:00
7ab50ab010
Update expire_date column of table comments
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2023-04-26 11:29:56 +07:00
e9295f739e
Split the comments ids by chunks
...
Split the comments ids by chunks to prevent error with Oracle database
that can't do a query with more than 1000 parameters.
https://github.com/nextcloud/spreed/issues/8287
Signed-off-by: Vitor Mattos <vitor@php.rio>
2023-03-01 13:08:17 +07:00
f5c361cf44
composer run cs:fix
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:45:08 +07:00
3f4fed3550
Fix forwarding the object id when searching comments
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-11-16 12:08:34 +07:00
7a0648757a
Delete comments that expired now
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-07-25 11:30:20 +07:00
c98e44507d
Merge pull request #32865 from nextcloud/bugfix/remove-unecessary-row
...
Remove unecessary row and make compatible with db schema
2022-07-08 23:11:10 +07:00
198224bf7a
Allow to expire comments of multiple objects with one call
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-07-01 15:59:29 +07:00
c59b0c2ff7
Add comments expire date
...
https://github.com/nextcloud/spreed/pull/7327
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-06-15 11:58:29 +07:00
45cdb36d5c
Remove unecessary row and make compatible with db schema
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-06-13 13:35:34 +07:00
5b82ad0b30
Create query parameters on correct objects to make debugging easier
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-23 13:02:36 +07:00
4e0595fb0f
Fix JSON error when comment has no reactions
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-09 09:53:49 +07:00
0d87335751
Merge pull request #31703 from nextcloud/techdebt/noid/emojihelper-interface
...
Emojihelper interface
2022-04-29 18:31:29 +07:00
7c85f8dea4
Make the order of reactions reliable
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-28 16:13:41 +07:00
a75a22f3ac
Increase check if support reactions
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-04-28 07:09:44 +07:00
902476fa20
Extract the EmojiService from user status and add an OCP interface
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-28 07:09:44 +07:00
367be7c55f
Allow reactions also with other combined emojis
...
Honerful copying the EmojiService from UserStatus for now
I think this should be put into a decent place and then reused,
but I couldn't find somethin short term before beta1
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-24 15:13:09 +07:00
d05dca0c1c
Simplify comment search in special cases
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-18 09:22:16 +07:00
8ec7c5c8ae
Update ICommentsManager with reaction methods
...
Fix psalm errors
Reorder methods and remove return null
Use best pattern on docblock
Goals: update https://github.com/ChristophWurst/nextcloud_composer/ with reaction methods.
The script
https://github.com/ChristophWurst/nextcloud_composer/blob/master/build.sh
only get lib/public classes
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-02-03 12:52:18 +07:00
e8c66d0f89
Merge pull request #30794 from nextcloud/techdebt/noid/allow-to-get-comments-with-verb
...
Allow to get comments with a given set of verbs
2022-01-28 16:41:42 +07:00
1ceba64863
Allow to get comments with a given set of verbs
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-21 13:42:04 +07:00
b9f74584a1
Fix check after change from string to mb_string
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:39:41 +07:00
c9f2f00777
Fix CS
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-21 08:39:40 +07:00
ecb98f772e
Throw if trying to save reaction without support
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-21 08:39:40 +07:00
e0b89cd576
Only check mb_strlen()
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-21 08:39:40 +07:00
d850dc0220
Remove order from groupConcat as it is not working everywhere
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-21 08:39:39 +07:00
189f9f96ce
Limit the summary and sort it afterwards
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-21 08:39:39 +07:00
f071b4dfbb
Fix groupConcat and ordering on Oracle
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:39:39 +07:00
f7cd995612
Order the reaction summary, improvements on validations
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:39:39 +07:00
1ce894a50c
Disable reactions if database don't support utf8mb4
...
Fix column size
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:39:37 +07:00
898e87fe1a
Rename vars and move logic to method
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:37:07 +07:00
a7c0868a4c
Prevent violate constraint
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:37:06 +07:00
1dda03e1b5
Rename vars
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:37:05 +07:00
9efbc9c1d5
Add comments reactions
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:37:04 +07:00
2166cfde9e
Allow to count comments with multiple verbs
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-26 12:29:44 +07:00
1018eb4411
Fix SQL type error
...
Fixing the following SQL error encountered with PostgreSQL:
SQLSTATE[42883]: Undefined function: 7 ERROR:
No operator matches the given name and argument types. You might need to add explicit type casts.
This prevented the Nextcloud apps/files page to show the files and directories. See #27881
2021-08-17 15:10:38 +07:00
215aef3cbd
Update php licenses
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +07:00
6578a93463
Merge pull request #27053 from nextcloud/bugfix/noid/dont-throw-when-comments-is-disabled
...
Don't throw when comments is disabled
2021-06-02 15:40:51 +07:00
c0c5340f4e
Fix populating the array and closing the cursors
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-01 09:15:34 +07:00
a50eba16ad
Fix Oracle query limit compliance in Comments
...
Signed-off-by: Simounet <contact@simounet.net>
2021-05-28 08:48:01 +07:00
5ae5729664
Don't throw when comments is disabled
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-21 12:04:23 +07:00
d89a75be0b
Update all license headers for Nextcloud 21
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-16 18:48:22 +07:00
ede7510854
Add a function to get the unread count for multiple objects in one go
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-04 11:01:21 +07:00
2dd50b4adc
Fix return type
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-21 11:02:05 +07:00
6400221fba
Less magic
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-21 09:47:40 +07:00
d462439a63
Get the last comment date for a list of actors (to allow sorting mention suggestions e.g.)
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-21 09:18:51 +07:00
89651c5233
Allow to search on multiple objects with one query
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-21 09:16:42 +07:00
326640462b
Add methods to get the number of comments and last comment since a date
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-21 09:15:38 +07:00
Joas Schilling
Côme Chilliet
Carl Schwan
Vitor Mattos
blizzz
Joas Schilling
Mátyás Jani
John Molakvoæ (skjnldsv)
Simounet
Christoph Wurst