Commit Graph

2027 Commits (feat/allow-decrypt-all-with-encryption-disabled)

Author SHA1 Message Date
Carl Schwan 7a43bf26ca refactor(dbal): Migrate away from Type::getName
Instead use Type::lookupName

Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-10-10 16:13:09 +07:00
Arthur Schiwon fbd29bcf7f
fix(LDAP): properly disable are require TLS certificate verification
- the old approach lead connection issues, as ldap_set_option was called
  too late. Specifically it needs to be called before ldap_connect and set
  globally!
- The old approach also connected it to the ldapTLS configuration, which
  has a misleading naming. It indicates StartTLS usage only, not plain TLS
  connections.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2025-10-09 20:22:37 +07:00
Carl Schwan cb82a9ef04 refactor(preview): Cleanup a bit the public interface
* Remove old IProvider interface, it's been deprecated since 17.0.0 (8
  years)
* Add type hinting to the IPreview interface and mark it as consumeable
  only
* Remove unused arguments from GeneratorHelper

Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-10-09 17:41:13 +07:00
Côme Chilliet 48c2dd6279
Merge pull request #55517 from nextcloud/carl/cron-service
refactor: Move cron setup to a service
2025-10-09 09:52:34 +07:00
Benjamin Gaussorgues 3aa0c23e40
Merge pull request #54543 from nextcloud/preview-db-rework 2025-10-08 16:39:23 +07:00
Kate fcbb8be904
Merge pull request #55514 from nextcloud/carl/more-old-execute 2025-10-08 10:30:46 +07:00
Daniel db3e845d19
Merge pull request #55557 from nextcloud/refactor/use-iemailaddressvalidator
refactor: use IEmailValidator.isValid instead of IMailer.validateEmailAddress
2025-10-07 19:15:32 +07:00
Côme Chilliet e739898cc7
Merge pull request #55400 from nextcloud/carl/remove-legacy-search-provider
refactor: Remove legacy search provider
2025-10-07 16:51:12 +07:00
Côme Chilliet b984e329fc
Merge pull request #55574 from nextcloud/carl/view-deprecated
chore: Explicitely mark \OC\Files\View as internal
2025-10-07 16:07:36 +07:00
dependabot[bot] bb6a265c55
build(deps-dev): bump behat/behat in /build/integration
Bumps [behat/behat](https://github.com/Behat/Behat) from 3.24.1 to 3.25.0.
- [Release notes](https://github.com/Behat/Behat/releases)
- [Changelog](https://github.com/Behat/Behat/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Behat/Behat/compare/v3.24.1...v3.25.0)

---
updated-dependencies:
- dependency-name: behat/behat
  dependency-version: 3.25.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-10-06 21:13:30 +07:00
Carl Schwan f450cda3aa chore: Explicitely mark \OC\Files\View as internal
It's in OC and should not be used at all. Marking it as internal will
at least prevent new code to use it.

Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-10-06 15:49:55 +07:00
Carl Schwan 9d7fbb1b86 refactor: Move cron setup to a service
This will allow in the future the following things:

- Create unit tests for it
- Make cron.php a occ command
- Make webcron a proper controller

Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-10-06 15:28:43 +07:00
Carl Schwan bfc7d5dd9f feat(preview): Implement scanning for previews
This work similarly to the move preview job to migrate the previews to
the new DB table and also reuse some code.

So when we are finding files in appdata/preview, try adding them to the
oc_previews table and delete them from the oc_filecache table.

Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-10-06 13:37:15 +07:00
Carl Schwan 324b54b863 refactor(preview): Cleanup the implementation of the new preview backend
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-10-06 13:37:15 +07:00
Carl Schwan bba9667882 perf(preview): Adapt BackgroundCleanupJob to new previews table
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-10-06 13:37:15 +07:00
Andy Scherzinger 40286b2fe2
Merge pull request #55481 from nextcloud/carl/fix-psalm-easy
refactor: Fix some easy psalm issues in Files
2025-10-06 12:11:02 +07:00
Joas Schilling 6dec53a6bc
Merge pull request #55472 from nextcloud/carl/fix-encryption-commands
refactor: fix psalm issues from encryption commands
2025-10-06 10:47:10 +07:00
Côme Chilliet 38d455800c
Merge pull request #55482 from nextcloud/carl/fix-search
refactor: Port away from search
2025-10-06 10:45:52 +07:00
Daniel Kesselberg 83a691709c
refactor: use IEmailValidator.isValid instead of IMailer.validateEmailAddress
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-10-04 21:54:22 +07:00
Carl Schwan 9e848551be refactor: Port away from more IQueryBuilder::execute
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-10-02 14:40:28 +07:00
Carl Schwan 34cd91cc86 refactor: Fix some easy psalm issues in Files
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-10-02 13:34:47 +07:00
Ferdinand Thiessen af5d538b03
chore: create ESLint baseline for hard-to-fix errors
WE NEED TO EMPTY THIS!

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-10-02 13:19:43 +07:00
Ferdinand Thiessen 91f3b6b4ee
chore: adjust code to new codestyle
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-10-02 13:19:42 +07:00
Ferdinand Thiessen 1d580e886f
chore(dev-deps): use ESLint v9
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-10-02 10:48:38 +07:00
Carl Schwan ce02a5b27c refactor: Port away from search
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-10-01 16:32:22 +07:00
Kate 7e8926011d
Merge pull request #55463 from nextcloud/fix/user-group-manager-return-type 2025-10-01 16:30:23 +07:00
Carl Schwan a3442be054 refactor: fix psalm issues from encryption commands
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-10-01 16:07:41 +07:00
Carl Schwan aa1f5312a5 refactor: Remove legacy search provider
Last usage was in the comment app

Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-10-01 13:36:25 +07:00
provokateurin 51a493cbe7
fix(IGroupManager): Use correct return type for search method
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-10-01 13:14:05 +07:00
provokateurin fb4348e3bc
fix(IUserManager): Fix deprecation of search method
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-10-01 12:08:58 +07:00
Côme Chilliet d36fc65c75
Merge pull request #55396 from nextcloud/carl/dashboard-appconfig
refactor: Port dashboard app to IAppConfig
2025-10-01 11:10:59 +07:00
Ferdinand Thiessen 31571476d3 refactor(files_external): migrate Ajax with `OC_JSON` to proper controller
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-09-30 20:19:21 +07:00
Côme Chilliet c6d148344a
chore: Fix the last psalm issues in lib/private/Template
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-09-29 12:32:26 +07:00
Côme Chilliet 73447618e7
chore: Run rector on lib/private/Template folder and cleanup more typing
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-09-29 12:23:37 +07:00
Carl Schwan 76736cf9d7 refactor: Port dashboard app to IAppConfig
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-09-29 10:22:46 +07:00
provokateurin 504eae65bd
refactor: Apply rector Nextcloud 27 set
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-09-28 11:45:52 +07:00
provokateurin d59338b377
refactor: Apply rector Nextcloud 26 set
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-09-28 11:45:52 +07:00
provokateurin 6a12fbc4f3
refactor: Run rector
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-09-27 18:52:58 +07:00
provokateurin bfb4fe8f86
fix(core): Stop abusing the cache for avatar upload
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-09-25 13:08:14 +07:00
Joas Schilling 00f589e765
Merge pull request #55140 from nextcloud/carl/cleanup-workflowengine-app
refactor(psalm): Fix most issues with the workflowengine
2025-09-22 11:51:13 +07:00
dependabot[bot] fdea3a5290
build(deps-dev): bump behat/behat in /build/integration
Bumps [behat/behat](https://github.com/Behat/Behat) from 3.24.0 to 3.24.1.
- [Release notes](https://github.com/Behat/Behat/releases)
- [Changelog](https://github.com/Behat/Behat/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Behat/Behat/compare/v3.24.0...v3.24.1)

---
updated-dependencies:
- dependency-name: behat/behat
  dependency-version: 3.24.1
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-09-20 01:13:13 +07:00
Hamza fa1dd4a717
fix: make sure default contact exists by default
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-09-17 10:57:36 +07:00
Carl Schwan 6154bfa823 chore(psalm): Fix most issues with the workflowengine
This found a real bug where we were catching an Doctrine exception
instead of a OCP\DB\Exception. This will be backported separately.

Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-09-17 09:57:10 +07:00
Kate 1f46274c4b
Merge pull request #55136 from nextcloud/test/integration/ocs-permission-check 2025-09-16 17:56:58 +07:00
Kate ddc272402d
Merge pull request #55135 from nextcloud/chore/remove-oc-cappedmemorycache 2025-09-16 14:38:48 +07:00
Carl Schwan 8555f98e32 refactor: Port External\Manager to the query builder
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-09-16 11:36:12 +07:00
Kate 0baaebd413
Merge pull request #54916 from nextcloud/artonge/feat/run_integration_tests_as_www-data 2025-09-16 10:35:22 +07:00
provokateurin 4a693208b7
test(integration): Check ocs share permission for correct folder
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-09-16 10:10:43 +07:00
provokateurin b1a398afb0
chore: Remove unused \OC\Cache\CappedMemoryCache
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-09-16 10:08:19 +07:00
Ferdinand Thiessen fdd22c264e
Merge pull request #55086 from nextcloud/carl/port-away-changeColumn
refactor: Port away from changeColumn
2025-09-15 15:17:34 +07:00
dependabot[bot] 6a731dcce6
build(deps-dev): bump behat/behat in /build/integration
Bumps [behat/behat](https://github.com/Behat/Behat) from 3.23.0 to 3.24.0.
- [Release notes](https://github.com/Behat/Behat/releases)
- [Changelog](https://github.com/Behat/Behat/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Behat/Behat/compare/v3.23.0...v3.24.0)

---
updated-dependencies:
- dependency-name: behat/behat
  dependency-version: 3.24.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-09-13 01:12:58 +07:00
Carl Schwan 0e7d5dce1c refactor: Port away from changeColumn
Replace by the drop-in replacement modifyColumn

Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-09-12 18:05:19 +07:00
Ferdinand Thiessen 6cdf098378
Merge pull request #54316 from nextcloud/feat/add-encryption-integration-tests
feat(encryption): Add integration tests for occ commands and fix them
2025-09-10 18:08:37 +07:00
Ferdinand Thiessen 62cbd20298
Merge pull request #54962 from nextcloud/chore/update-master-dbal
chore(deps): update `doctrine/dbal` to v3.10.2
2025-09-10 12:04:09 +07:00
Ferdinand Thiessen 5003a35a37
chore(deps): update `doctrine/dbal` to v3.10.2
* [ ] https://github.com/nextcloud/3rdparty/pull/2134
* Fixes the problem with MariaDB 11 and `vector` keyword, see https://github.com/nextcloud/recognize/issues/1352

| Production Changes | From  | To      | Compare                                                        |
|--------------------|-------|---------|----------------------------------------------------------------|
| doctrine/cache     | 2.2.0 | REMOVED |                                                                |
| doctrine/dbal      | 3.9.4 | 3.10.2  | [...](https://github.com/doctrine/dbal/compare/3.9.4...3.10.2) |

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-09-10 11:11:19 +07:00
nextcloud-command 5de9502b55 fix(security): Update CA certificate bundle
Signed-off-by: GitHub <noreply@github.com>
2025-09-10 02:32:22 +07:00
Côme Chilliet 55ad42ad95
feat(encryption): Add integration tests for occ commands
Add tests for encrypt-all and decrypt-all.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-09-09 11:46:10 +07:00
Louis Chemineau 9b5d11845a
feat(files_trashbin): Refactor expire background job to support parallel run
- Follow-up of #51600

The original PR introduced the possibility to continue an `ExpireTrash` job by saving the offset. This was to prevent having to start over the whole user list when the job crashed or was killed.

But on big instances, one process is not enough to go through all the users in a timely manner. Supporting parallel run allows covering more ground faster.

This PR introduced this possibility. We are now storing the offset right away to allow another parallel job to pick up the task at that point. We are arbitrarily cutting the user list in chunk of 10 to not drastically overflow the 30 minutes time limit.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-09-08 12:33:25 +07:00
Louis Chemineau 4db473c86e
feat(test): Run behat tests as www-data
Composer does not like being run as root.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-09-05 11:59:46 +07:00
Andy Scherzinger 3f5c2cdd88
Merge pull request #54645 from nextcloud/carl/modernize-custom-property-backend
refactor(CustomPropertiesBackend): Modernize class
2025-09-05 01:06:21 +07:00
Maxence Lange 0b82442d94 feat(since-checker): check statement for /lib/public/migration/attributes
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2025-09-03 22:27:59 +07:00
Carl Schwan b303185126 refactor(CustomPropertiesBackend): Modernize class
- Use query builder
- Add chunking
- Add type hinting where we can
- Use match expression

Signed-off-by: Carl Schwan <carl.schwan@nextclound.com>
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-09-03 14:28:26 +07:00
Daniel Kesselberg a37ed05b8f
fix(comments): use showFile route to reference files with a matching comment
The files.view.index route with dir and scrollto is deprecated and
opening the actual does not work anymore.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-09-03 10:58:52 +07:00
Daniel Kesselberg e80d89b7a1
Revert "fix(comments): use showFile route to reference files with a matching comment"
This reverts commit 317cd25497.
2025-09-02 21:34:49 +07:00
Daniel Kesselberg 317cd25497
fix(comments): use showFile route to reference files with a matching comment
The files.view.index route with dir and scrollto is deprecated and
opening the actual does not work anymore.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-09-02 21:34:03 +07:00
Ferdinand Thiessen 9ba4150a18
fix(dav): ensure moving or copying a file is possible
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-09-02 16:23:47 +07:00
Carl Schwan 76dc41ea18 fix(psalm): Fix ParamNameMismatch with IRepairStep::run
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-08-29 14:31:46 +07:00
Joas Schilling 3df6d90a4c
Revert "perf(base): Stop setting up the FS for every basic auth request" 2025-08-28 17:11:31 +07:00
Richard Steinmetz 40117dced3
Merge pull request #54426 from nextcloud/perf/prevent-fetching-account
perf: prevent fetching a principal's user account if the data is not needed
2025-08-28 16:59:38 +07:00
Richard Steinmetz 5b254ea39a
perf: prevent fetching a principal's user account if the data is not needed
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-08-28 14:13:29 +07:00
John Molakvoæ d785bcdc6e
Merge pull request #53920 from nextcloud/revert-53918-revert-53141-perf/files/setup-fs-basic-auth-request 2025-08-28 14:12:57 +07:00
Kate a1709f576e
Merge pull request #54627 from nextcloud/fix/ocs/accept-header 2025-08-28 14:03:23 +07:00
provokateurin e38dfef0dc chore: Remove unused \OC\Cache\CappedMemoryCache
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2025-08-28 09:32:51 +07:00
provokateurin 5057d5fcc5 fix(core): Stop abusing the cache for avatar upload
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-08-28 09:28:11 +07:00
provokateurin d5c15d4d2f test(integration): Check ocs share permission for correct folder
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-08-28 09:28:10 +07:00
dependabot[bot] 025e081530
build(deps-dev): bump guzzlehttp/guzzle in /build/integration
Bumps [guzzlehttp/guzzle](https://github.com/guzzle/guzzle) from 7.9.3 to 7.10.0.
- [Release notes](https://github.com/guzzle/guzzle/releases)
- [Changelog](https://github.com/guzzle/guzzle/blob/7.10/CHANGELOG.md)
- [Commits](https://github.com/guzzle/guzzle/compare/7.9.3...7.10.0)

---
updated-dependencies:
- dependency-name: guzzlehttp/guzzle
  dependency-version: 7.10.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-08-28 08:51:04 +07:00
Richard Steinmetz b7dc720848
feat: calendar federation
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-08-27 17:14:15 +07:00
provokateurin aab11d35d3
fix(OCS): Add IRequest::getFormat to determine the response Content-Type the same way everywhere
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-08-26 09:50:03 +07:00
skjnldsv ce41a2d727 chore: add `window.d.ts` to release ignore list
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-08-20 16:21:34 +07:00
Ferdinand Thiessen f933a41a5a chore: adjust webpack plugin to also extract inline asset licenses
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-08-19 16:01:30 +07:00
Kate 4edfef4dd5
Merge pull request #53895 from nextcloud/fix/cleanup-updater-class 2025-08-19 17:40:15 +07:00
Daniel 09607f40eb
Merge pull request #53834 from nextcloud/feat/imailaddressvalidator
feat(ocp): add email address validator
2025-08-19 09:38:51 +07:00
Daniel f7a7ae46ab
Merge pull request #54464 from nextcloud/jtr-fix-dav-direct-server-propfind-typo
chore(dav): Fix typo in property name
2025-08-19 09:33:05 +07:00
provokateurin 3ae53e3d2a
chore(psalm): Update baseline
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-08-19 08:44:15 +07:00
Ferdinand Thiessen 6c003eda5c
Merge pull request #54483 from nextcloud/feat/fetch-user-timezone
feat(IDateTimeZone): allow to fetch timezone of specified user
2025-08-18 20:36:46 +07:00
Côme Chilliet 8ccf87f7a2
chore: update psalm baseline
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-08-18 17:09:41 +07:00
Ferdinand Thiessen f7e0f3f241
feat(IDateTimeZone): allow to fetch timezone of specified user
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-08-18 14:26:52 +07:00
Ferdinand Thiessen 866ccae542
docs(IConfig): fix wrong doc block type for `$key` on `setAppValue`
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-08-18 13:24:18 +07:00
Ferdinand Thiessen d5e2432bcd
fix: resolve invalid usage of `AppConfig::getValue`
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-08-18 13:24:18 +07:00
Ferdinand Thiessen 1c85548f86
feat(AppConfig): cache app config in local cache if available
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-08-18 13:24:18 +07:00
Josh 43df12f148
chore: update psalm-baseline.xml
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-08-16 07:58:10 +07:00
Daniel Kesselberg 336c6d2957
feat(ocp): add email address validator
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-08-14 18:34:36 +07:00
nextcloud-command 248adf535c fix(security): Update CA certificate bundle
Signed-off-by: GitHub <noreply@github.com>
2025-08-14 02:43:58 +07:00
Joas Schilling 57f09b642e
fix(container): Reduce general deprecation spam on all requests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-08-09 11:53:30 +07:00
Ferdinand Thiessen d31be348af chore: add deprecated `IAccountManager::PROPERTY_TWITTER` to psalm baseline
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-08-08 08:06:45 +07:00
yemkareems aa227f1c55 feat: add bluesky to accounts, show the same in profile edit and visibility option, in view profile and also in sharing tab
Signed-off-by: yemkareems <yemkareems@gmail.com>
2025-08-08 08:06:45 +07:00
Ferdinand Thiessen c67bdf02f0
chore: add missing license ref for new fonts
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-08-06 13:12:57 +07:00
Joas Schilling ff3043346a
Merge pull request #54196 from nextcloud/enh/noid/taskprocessing-lazy-config
[TaskProcessing] Load and store some config keys lazily
2025-08-05 12:28:34 +07:00
Joas Schilling 78dcf3744d
Revert "feat: Implement Directory Check"
This reverts commit feae8ba16a.
2025-08-05 11:18:50 +07:00
Julien Veyssier 282bedcfb0
fix(taskprocessing): remove unused psalm baseline entries
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2025-08-04 10:11:24 +07:00
Robin Windey feae8ba16a feat: Implement Directory Check
* Partially implements #27591

Signed-off-by: Robin Windey <ro.windey@gmail.com>
2025-08-01 09:43:59 +07:00
John Molakvoæ 64b1428552
Merge pull request #54008 from nextcloud/dependabot/composer/build/integration/behat/behat-3.23.0 2025-08-01 09:39:08 +07:00
Ferdinand Thiessen 2e5ddea8fb
chore(files_sharing): remove leftover of legacy files ui
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-07-31 21:09:43 +07:00
provokateurin 746e5917c7
fix(IShare): Add missing getParent and setParent methods
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-07-29 11:27:04 +07:00
provokateurin 665a38573c
fix(IShareProvider): Add missing getChildren method to the interface
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-07-29 10:26:33 +07:00
Kate aca5361e86
Merge pull request #53944 from nextcloud/chore/too-many-arguments 2025-07-28 10:49:52 +07:00
Joas Schilling a3b2557486
chore(OCP): Migrate lib/Config/ to new attributes
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-07-25 16:17:35 +07:00
provokateurin 5bd626bd40
chore: Fix all method calls with too many arguments
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-07-22 12:34:49 +07:00
dependabot[bot] b1a8e01c3f
build(deps-dev): bump behat/behat in /build/integration
Bumps [behat/behat](https://github.com/Behat/Behat) from 3.22.0 to 3.23.0.
- [Release notes](https://github.com/Behat/Behat/releases)
- [Changelog](https://github.com/Behat/Behat/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Behat/Behat/compare/v3.22.0...v3.23.0)

---
updated-dependencies:
- dependency-name: behat/behat
  dependency-version: 3.23.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-07-19 01:19:00 +07:00
Ferdinand Thiessen a18e61a1e5
feat(files_sharing): add config option for extending link-share permissions
This allows the admin to control the behavior whether link shares with
READ permissions should be extended to also gain SHARE permissions,
allowing users (public share receivers) to add the share to their cloud.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-07-17 16:59:36 +07:00
nextcloud-command 8c48b82437 fix(security): Update CA certificate bundle
Signed-off-by: GitHub <noreply@github.com>
2025-07-16 02:44:58 +07:00
provokateurin ea6f0a7b19
build: Update psalm baseline
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-07-14 09:54:47 +07:00
John Molakvoæ 2b50d9b2c5
Revert "perf(base): Stop setting up the FS for every basic auth request" 2025-07-11 17:07:44 +07:00
John Molakvoæ 6f0255d82a
Merge pull request #53141 from nextcloud/perf/files/setup-fs-basic-auth-request 2025-07-11 15:25:10 +07:00
Arthur Schiwon b61757a9e7
Merge pull request #53897 from nextcloud/fix/noid/krb-fallback
fix(Krb): switch away from deprecated and broken KerberosApacheAuth()
2025-07-11 09:58:47 +07:00
John Molakvoæ 1bc1902476
Merge pull request #53887 from nextcloud/fix/lower-email-case 2025-07-11 09:03:05 +07:00
Arthur Schiwon fd799afc17
fix(Krb): switch away from deprecated and broken KerberosApacheAuth()
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2025-07-10 23:21:16 +07:00
Daniel Calviño Sánchez d4e9a8ac33
Merge pull request #53501 from nextcloud/fix-theming-for-disabled-accounts
fix: Fix theming for disabled accounts
2025-07-10 20:47:48 +07:00
Daniel Calviño Sánchez 01766b18f8 fix: Fix theming for disabled accounts
The Theming app injects the stylesheets for the different themes in the
"<header>" element of the page, and those stylesheets are then loaded by
the browser from a "Controller" (a plain "Controller", not an
"OCSController"). The stylesheets, in turn, may also get some images
(like the background) also from the "Controller".

When handling a request to "index.php" it is checked whether the user is
logged in and, if not, a login is tried. A disabled user is explicitly
seen as not logged in, so a login is always tried in that case, but
disabled users are also explicitly prevented to log in, so the login
also fails. Due to that trying to get any of the themed stylesheets or
images with a disabled account (to be able to show the "Account
disabled" error page) fails with an HTTP status 401.

To solve that, and to avoid touching this basic logic as much as
possible, the login exception is now ignored (if the user is disabled)
for some specific requests to the Theming app.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2025-07-10 15:19:01 +07:00
Côme Chilliet da20bbb44d
chore: update psalm baseline
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-07-10 11:40:27 +07:00
skjnldsv 027471b146 fix: force lowercase emails
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-07-10 09:10:01 +07:00
Kate 3da74810b5
Merge pull request #53537 from nextcloud/fix/cleanup-dependencyanalyser 2025-07-09 13:16:55 +07:00
Joas Schilling d717dd9850
feat(OCP): Consumable vs. Implementable public API
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-07-09 10:24:10 +07:00
Côme Chilliet adb6f00051
chore: update psalm baseline
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-07-09 10:15:00 +07:00
Côme Chilliet 7bdfd94246
chore: update psalm baseline
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-07-08 13:32:15 +07:00
provokateurin 90705520c7
chore: Remove unused \OC\Cache\CappedMemoryCache
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-07-08 11:39:33 +07:00
provokateurin 24f7a2e680
fix(core): Stop abusing the cache for avatar upload
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-07-08 11:38:59 +07:00
Robin Appelman 1620a0c051
chore: add rector DataProviderAnnotationToAttributeRector
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-07-01 22:45:06 +07:00
Robin Appelman 259f1fe9bd
chore: add phpunit StaticDataProviderClassMethodRector rector rule
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-07-01 22:45:01 +07:00
Ferdinand Thiessen 5981b7eb51
chore: apply new CSFixer rules
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

# Conflicts:
#	apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +07:00
John Molakvoæ bd00b75b29
Merge pull request #53671 from nextcloud/fix/read-only-share-download 2025-07-01 15:11:06 +07:00
provokateurin 2e5ccc7123
fix(files): Always transfer incoming shares when doing ownership transfer to prevent broken reshares
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-07-01 08:23:53 +07:00
Joas Schilling 60b8384e48
Merge branch 'master' into remove-x-xss-protection 2025-06-30 21:32:22 +07:00
Daniel Kesselberg de54bdb06b
fix: handle ambiguous IResponse.getBody return types
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-06-30 11:50:11 +07:00
Daniel Kesselberg 3d0fb7e603
docs(http): Update return type for getBody
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-06-30 11:50:10 +07:00
skjnldsv 9806a9830c feat(files_sharing): allow viewing files with download disabled
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-06-26 11:47:53 +07:00
Daniel Kesselberg 53fb05e2d0
fix(nullcache): make get compliant with the interface
The interface defines ICacheEntry|false, thus we should not return null.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-06-26 09:54:48 +07:00
Richard Steinmetz b6af06d2e0
fix: revive always storing lowercased email addresses
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-06-24 13:53:08 +07:00
Richard Steinmetz 960b3ec0eb refactor(dav): move shared logic to a dedicated example contact service
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-06-19 23:46:00 +07:00
Côme Chilliet f314d930be
Merge pull request #52916 from nextcloud/fix/cache-ldap-configuration-prefixes
fix(user_ldap): Store the list of used configuration prefixed in appconfig
2025-06-19 11:57:15 +07:00
Ferdinand Thiessen 35a27b5fd5
fix(FilenameValidator): use `_` as default replacement for invalid chars
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-06-18 09:44:57 +07:00
Daniel Kesselberg 6254354f27
test(dav): add integration test for principal property search
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-06-17 11:19:24 +07:00
invario 2b58f74cc8
Fix: Remove X-XSS-Protection use, check and recommendation
Co-authored-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: invario <67800603+invario@users.noreply.github.com>
2025-06-13 16:12:27 +07:00
Robin Appelman 3cc34ac29d
chore: add UseSpecificWillMethodRector to rector configuration
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-06-12 18:33:43 +07:00
Robin Appelman de74745ab6
chore: add tests to rector configuration
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-06-12 18:31:40 +07:00
Côme Chilliet b9949b2381
chore: update psalm baseline
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-06-10 16:08:52 +07:00
Daniel Kesselberg 55bca1e5db fix: use logical operator instead of bitwise
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-06-10 13:55:53 +07:00
Côme Chilliet 231916d403
Merge pull request #52538 from nextcloud/feat/use-php84-lazy-objects
Use PHP 8.4 lazy ghosts for Dependency injection
2025-06-10 10:45:12 +07:00
Stephan Orbaugh 04118afdab
Merge pull request #53287 from nextcloud/feat/test-app-routes
feat(tests): Test application enabling/disabling and routes
2025-06-06 13:00:02 +07:00
Côme Chilliet a42ef7d633
fix: Fix psalm issue and update baseline
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-06-05 20:51:18 +07:00
Côme Chilliet ba53147e10
chore: update psalm baseline
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-06-05 18:20:05 +07:00
Côme Chilliet 580911dc89
chore: Disable appstore from integration tests
This avoids spamming the appstore server and getting banned from CI runs

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-06-05 16:23:07 +07:00
Côme Chilliet a15c473ae2
feat(tests): Test application enabling/disabling and routes
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-06-05 15:12:28 +07:00
skjnldsv e41e8de0e2 fix(dav): file drop nickname
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-06-05 09:09:17 +07:00
Ferdinand Thiessen 0a982374ec
refactor(core): migrate core application to `IBootstrap`
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-06-02 15:58:25 +07:00
Robin Appelman 7599162c7b feat: move primary object store configuration to a single place
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-05-28 15:32:31 +07:00
nextcloud-command 3f36d868ac fix(security): Update CA certificate bundle
Signed-off-by: GitHub <noreply@github.com>
2025-05-21 02:37:29 +07:00
Joas Schilling 9637fe6474
Revert "fix(files_sharing): Filter own shares that are reshares" 2025-05-19 17:16:39 +07:00
Kate 13f23061e8
Merge pull request #52891 from nextcloud/chore/nix-flake 2025-05-19 11:51:22 +07:00
provokateurin 7c6602cd8d
fix(files_sharing): Filter own shares that are reshares
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-19 08:18:16 +07:00
Kate 249e33fcd6
Merge pull request #52901 from nextcloud/chore/remove-dead-code-files 2025-05-19 07:02:41 +07:00
Kate 6b4f5c567c
Merge pull request #52848 from nextcloud/fix/cleanup-servercontainer 2025-05-19 07:02:11 +07:00
provokateurin 0c2cc0e9e1
chore: Add nix flake with development shell
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-18 13:59:32 +07:00
Ferdinand Thiessen e2a331f53d
Merge pull request #52890 from nextcloud/chore/move-stream-copy-implementation
chore: move streamCopy implementation from `OC_Helper` to `OCP\Files`
2025-05-17 12:01:44 +07:00
Ferdinand Thiessen bd91db8e20
chore: deprecate OC_Helper::copyr
Inline it into Installer as needed.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-16 17:32:45 +07:00
Ferdinand Thiessen e693a5d4a5
fix(dav): correctly handle uploading folders with same name as a file
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-16 14:38:41 +07:00
Ferdinand Thiessen 3ab905dbfa
Merge pull request #52893 from nextcloud/chore/remove-files-templates
chore: remove files file templates deprecated since v18 and provided by richdocuments
2025-05-16 14:36:06 +07:00
Ferdinand Thiessen 4a9dc6c64d
refactor: move tag handling from files handler to files_sharing
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-16 13:09:03 +07:00
Ferdinand Thiessen 01db539d0a
chore: move streamCopy implementation from `OC_Helper` to `OCP\Files`
The function was already there but called the legacy version.
So moved the implementation and migrated all usages of it.
Sadly the interface was slightly different so adjusted it to be
compatible with both legacy and the OCP one.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-16 13:03:05 +07:00
Ferdinand Thiessen 1b7e04d317
chore: remove files file templates deprecated since v18 and provided by richdocuments
- leftover from https://github.com/nextcloud/server/pull/17559
- The file templates are already provided in a non-deprecated way by
  richdocuments.
- The template manager used here is deprecated for 14 versions now...

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-16 12:45:55 +07:00
Kate fc9310feef
Merge pull request #52885 from nextcloud/fix/docblock-color
fix(OCP\Color): use correct doc block type
2025-05-16 12:41:51 +07:00
Côme Chilliet 369900e5a5
fix: Remove deprecated getters from Server that were previously removed from public interface
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-16 10:49:01 +07:00
Côme Chilliet 998062d342
fix: Cleanup share ProviderFactory to correctly use DI instead of deprecated getters
Ideally circles and talk should migrate to calling registerProvider and
 core would not need to use their OCA classes like currently.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-16 10:48:03 +07:00
Ferdinand Thiessen 2986fead40
chore: ignore 3rdparty while psalm linting
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-15 18:38:38 +07:00
Ferdinand Thiessen aabb4e547a
fix(OCP\Color): use correct doc block type
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-15 18:35:14 +07:00
Ferdinand Thiessen 74bded74a3
refactor: migrate from OC to OCP in public interfaces
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-15 16:17:47 +07:00
Kate 4aa4972550
Merge pull request #52870 from nextcloud/chore/remove-get-storage 2025-05-15 16:04:45 +07:00
Ferdinand Thiessen 54eaad76c0
chore!(\OCP\Files): remove deprecated static `getStorage` method
Was deprecated since Nextcloud 14 and is not used anymore.
Removing allows us to clean the OCP psalm baseline.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-15 14:18:28 +07:00
provokateurin 63ba61487b
chore(AppFramework): Remove unused RouteConfig class and migrate tests to RouteParser
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-15 13:57:14 +07:00
provokateurin 0f2f4aab5c
feat(psalm): Mark all usage of deprecated code as error
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-15 11:48:40 +07:00
provokateurin 3b42c92d69
refactor: Extend rector to ocs/ and ocs-provider/
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-15 10:30:03 +07:00
provokateurin 6d6d83d3d9
refactor: Extend rector to all top-level files
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-15 10:30:02 +07:00
Kate 8ecadfa6bf
Merge pull request #52820 from nextcloud/refactor/rector-core 2025-05-15 01:42:15 +07:00
Côme Chilliet 300964ec4b
Merge pull request #52840 from nextcloud/fix/remove-broken-versions-routes
fix(files_versions): Remove routes leading to deleted ajax files
2025-05-15 00:19:30 +07:00
provokateurin 82fb8f8508
refactor: Extend rector to core/
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-15 00:16:54 +07:00
Côme Chilliet baae99eaad
Merge pull request #52667 from nextcloud/fix/improve-init-profiling
Improve init profiling
2025-05-14 22:57:55 +07:00
Côme Chilliet 6974015e39
fix: Update psalm baseline to remove fixed issue
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-14 22:29:55 +07:00
John Molakvoæ ae63945736
Merge pull request #52544 from nextcloud/chore/drop-deprecated-account-scopes 2025-05-14 22:15:01 +07:00
Côme Chilliet 0c56605497
fix: Fix psalm issue and update baseline
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-14 19:18:31 +07:00
Ferdinand Thiessen 1b273b8c2c
chore(IAccountManager): remove deprecated visibility constants
Those constants are not used anywhere anymore and are deprecated for
more than ten versions. So its time to cleanup the interface.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-14 19:15:24 +07:00
Côme Chilliet f6f83430a9 chore: Update psalm baseline to remove fixed issue
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-13 23:37:52 +07:00
Côme Chilliet 20c6d1a7e9
feat: Improve init a bit, and add more profiling steps
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-13 16:08:49 +07:00
John Molakvoæ (skjnldsv) 4495794a0b
feat(dav): allow uploading folders to public shares
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2025-05-13 16:03:20 +07:00
dependabot[bot] 70db2a4c9e
build(deps-dev): bump behat/behat in /build/integration
Bumps [behat/behat](https://github.com/Behat/Behat) from 3.21.1 to 3.22.0.
- [Release notes](https://github.com/Behat/Behat/releases)
- [Changelog](https://github.com/Behat/Behat/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Behat/Behat/compare/v3.21.1...v3.22.0)

---
updated-dependencies:
- dependency-name: behat/behat
  dependency-version: 3.22.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-05-10 01:22:38 +07:00
Louis 1c518a291d
Merge pull request #52360 from nextcloud/artonge/fix/use_preview_api_for_blurhash_generation 2025-05-06 14:12:50 +07:00
Ferdinand Thiessen c668703021
Merge pull request #51608 from nextcloud/feat/sanitize-filenames-command
feat(files): add command to automatically rename filenames
2025-05-05 15:47:30 +07:00
Louis Chemineau 867be352f3
fix(blurhash): Use preview API to generate the previews
This allows to benefit from all the checks done by the preview API.
This also use the newly introduced `cacheResult` argument to limit disk usage.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-05-05 11:13:31 +07:00
Ferdinand Thiessen 226ad23a1a
feat(files): add command to automatically rename filenames
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-30 16:32:07 +07:00
Ferdinand Thiessen 0e50ba839c
test: ignore git-ignored files from tests
Fix running `npm run test` when your development setup has other apps
checked out - like having the viewer app installed locally in `apps`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-29 10:15:29 +07:00
dependabot[bot] 20347c216d
build(deps-dev): bump behat/behat in /build/integration
Bumps [behat/behat](https://github.com/Behat/Behat) from 3.21.0 to 3.21.1.
- [Release notes](https://github.com/Behat/Behat/releases)
- [Changelog](https://github.com/Behat/Behat/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Behat/Behat/compare/v3.21.0...v3.21.1)

---
updated-dependencies:
- dependency-name: behat/behat
  dependency-version: 3.21.1
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-04-26 01:42:32 +07:00
Joas Schilling 9ed33cf6aa
feat(profile): Add an API to get the profile field data
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-04-23 12:38:18 +07:00
dependabot[bot] 32d90b528c
build(deps-dev): bump behat/behat in /build/integration
Bumps [behat/behat](https://github.com/Behat/Behat) from 3.20.0 to 3.21.0.
- [Release notes](https://github.com/Behat/Behat/releases)
- [Changelog](https://github.com/Behat/Behat/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Behat/Behat/compare/v3.20.0...v3.21.0)

---
updated-dependencies:
- dependency-name: behat/behat
  dependency-version: 3.21.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-04-22 12:56:17 +07:00
Julius Knorr 12490b2837
Merge pull request #52099 from nextcloud/perf/excimer
Built in profiling capabilities with excimer
2025-04-22 14:50:14 +07:00
Ferdinand Thiessen b4255a9652
fix(dav): allow uploading of files with long filenames
A filename must be less or equal 255 characters, but when adding the
`.part` and `.ocfiletransfer` extensions we might overflow this limit.
So we should also use filename hashes for uploading when the file has a
long filename, similar like when we are uploading to the user storage
directly.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-22 11:09:25 +07:00
Julius Knorr 3fc9a99521 perf: Add config options to trigger individual and sample profiling using excimer
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2025-04-22 08:57:02 +07:00
Côme Chilliet fb724416ba
Merge pull request #52178 from nextcloud/fix/remove-app.php-loading
fix: Remove support for app.php loading
2025-04-17 16:39:43 +07:00
Daniel Kesselberg fa8b389b6e
ci: add check to ensure composer-bin is not accidentally committed
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-04-15 13:20:37 +07:00
John Molakvoæ fbb77270c2
Merge pull request #50905 from nextcloud/fix/rate-limit-share-creation 2025-04-15 10:57:50 +07:00
skjnldsv 75063cd71b test: enable rate limiting for ratelimiting.feature
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-04-15 10:31:02 +07:00
Joas Schilling 59d1a49acc
test: Disable ratelimit as tests trigger it
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-04-15 08:45:50 +07:00
skjnldsv 6a0d92dedf fix(files_sharing): expireDate null tests
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-04-14 22:46:52 +07:00
Côme Chilliet 12b1342316
chore: Update psalm baseline
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-04-14 14:51:22 +07:00
John Molakvoæ dd32639fa9
Merge pull request #51838 from nextcloud/feat/cleanup-oc-util-methods
Mark all methods of OC_Util as deprecated
2025-04-08 21:47:31 +07:00
Côme Chilliet b42a13f5df
chore: Update psalm baseline
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-04-07 18:22:13 +07:00
Ferdinand Thiessen 16188cd767 chore: adjust copyright year
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-07 14:40:37 +07:00
Ferdinand Thiessen 7b321ba4f2 fix(profile): ensure correct base address
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-07 14:40:37 +07:00
Ferdinand Thiessen 4a64cf54ba ci: test that all apps are enabled for psalm
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-07 14:40:37 +07:00
Ferdinand Thiessen c0212af7fa
chore: lint files_reminders using psalm
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-07 10:56:16 +07:00
dependabot[bot] 654dd66515
build(deps-dev): bump behat/behat in /build/integration
Bumps [behat/behat](https://github.com/Behat/Behat) from 3.19.0 to 3.20.0.
- [Release notes](https://github.com/Behat/Behat/releases)
- [Changelog](https://github.com/Behat/Behat/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Behat/Behat/compare/v3.19.0...v3.20.0)

---
updated-dependencies:
- dependency-name: behat/behat
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-04-02 18:10:42 +07:00
Daniel Kesselberg f8a45703d7
chore: remove scrutinizer
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-04-02 15:27:26 +07:00
Ferdinand Thiessen 97ad171d32
refactor(IMimeTypeDetector): use consistent capitalization
- use consistantly `mimeType` as it is called MIME type
- fix issues where implementation and interface had different parameter
  names (this is an issue since PHP has named parameters).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-02 13:22:16 +07:00
gavine99 ed6d76ec8d
fix(notifications): Change notification app orders
The notification manager always calls notify() of the 'main' notifications app
before other notify apps, and calls other functions for other notifications apps
before the 'main' notification app

Signed-off-by: gavine99 <github@xymail.tk>
2025-04-01 12:27:24 +07:00
dependabot[bot] e9ec5d12c1
chore(deps-dev): bump guzzlehttp/guzzle in /build/integration
Bumps [guzzlehttp/guzzle](https://github.com/guzzle/guzzle) from 7.9.2 to 7.9.3.
- [Release notes](https://github.com/guzzle/guzzle/releases)
- [Changelog](https://github.com/guzzle/guzzle/blob/7.9/CHANGELOG.md)
- [Commits](https://github.com/guzzle/guzzle/compare/7.9.2...7.9.3)

---
updated-dependencies:
- dependency-name: guzzlehttp/guzzle
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-03-29 02:41:52 +07:00
Côme Chilliet da9b6e376d fix(tests): Sort activities by id to get the last one
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-25 15:43:09 +07:00
Côme Chilliet 140aba1f16 feat: Add context and test steps for activity in sharing
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-25 15:43:09 +07:00
Côme Chilliet a57f694e8d feat: add integration test for sharing activity
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-25 15:43:09 +07:00
provokateurin 95df189595
feat(openapi): Generate merged spec for all apps
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-24 16:38:17 +07:00
provokateurin 3732be59fd
fix(build): Also fail OpenAPI generation for untracked specs
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-24 16:18:02 +07:00
Côme Chilliet 5ed5bef1ba chore: Update OCP baseline
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-20 10:54:50 +07:00
Ferdinand Thiessen 92795b2091
chore(test): use consistent tabs for indention in behat tests
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-19 20:59:08 +07:00
John Molakvoæ 4df9ab4033
Merge pull request #51403 from nextcloud/chore/drop-jsdoc
chore(dev-deps): Drop dependency on jsdoc
2025-03-12 08:48:25 +07:00
Ferdinand Thiessen 251a19d6ea
chore(dev-deps): Drop dependency on jsdoc
It is not used anymore and it yields not usable documentation anymore.
This is a leftover from like 11 years ago.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 18:36:41 +07:00
Ferdinand Thiessen 00d08a4f69
fix(lookup-server): disable lookup server for non-global scale setups
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 14:26:47 +07:00
Côme Chilliet 253628ad5a fix: Fix psalm issues and add missing methods to ITemplate interface
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-06 15:49:25 +07:00
Côme Chilliet 71dc34c03c fix: Deprecate OC_Template, add proper template manager instead
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-06 15:49:25 +07:00
Louis Chemineau c2f2f21673
feat: Support deleting metadata from WebDAV
The `$value` will be `null` if the update is wrapped inside a `<d:remove>...</d:remove>` block.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-03-04 12:34:11 +07:00
Stephan Orbaugh 3bc3d03048
Merge pull request #51000 from nextcloud/fix/federatedfilesharing/group-cleanup
fix(FederatedShareProvider): Delete external shares when groups are deleted or users removed from a group
2025-03-03 16:29:10 +07:00
Kate a9a839c40f
Merge pull request #51194 from nextcloud/refactor/tempmanager
refactor(TempManager): Simplify and unify implementations and remove legacy behavior
2025-03-03 16:17:34 +07:00
provokateurin eaa1b54d98
build(integration): Disable password_policy app
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-03 12:51:39 +07:00
provokateurin dd47daa4a8
fix(Share20): Convert broken hooks to IEventListener
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-03 12:49:01 +07:00
provokateurin 8acfc0f0f2
refactor(TempManager): Simplify and unify implementations and remove legacy behavior
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-03 11:11:12 +07:00
Ferdinand Thiessen c82337f3b9
fix: incorrect types detected by updated stubs
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-27 19:07:39 +07:00
Ferdinand Thiessen 0be4239c41
chore: Update php intl stub for PHP 8.0+
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-27 19:06:44 +07:00
Côme Chilliet 485f3f495e
fix: Fix test by scanning group before using it
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-27 12:39:15 +07:00
nextcloud-command 11d36e7607 fix(security): Update CA certificate bundle
Signed-off-by: GitHub <noreply@github.com>
2025-02-26 02:31:09 +07:00
Joas Schilling 0fc355aa1e
ci(autochecks): Run some autochecks also on non-PHP files
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-02-21 12:12:29 +07:00
dependabot[bot] eb3c639c6b bump behat/behat from 3.18.1 to 3.19.0 in /build/integration
---
updated-dependencies:
- dependency-name: behat/behat
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-02-18 14:31:46 +07:00
Côme Chilliet e757b649b7
fix: Fix psalm taint false-positives by small refactorings
Mostly make it clear that we trust admin input or that we correctly
 escape strings.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 18:08:23 +07:00
Côme Chilliet 640dbd0b5e
fix: Fix false-positive psalm taint errors when outputting plain text
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:26:23 +07:00
Côme Chilliet 7c907223d2
fix: Fix psalm taint false-positive by escaping trusted input
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:26:22 +07:00