Merge pull request #7075 from nextcloud/remove-unused-variables

Remove unused variables

apps/dav/lib/DAV/SystemPrincipalBackend.php

@@ -164,7 +164,7 @@ class SystemPrincipalBackend extends AbstractBackend {
 	 * @return array
 	 */
 	function getGroupMembership($principal) {
-		list($prefix, $name) = \Sabre\Uri\split($principal);
+		list($prefix, ) = \Sabre\Uri\split($principal);
 
 		if ($prefix === 'principals/system') {
 			$principal = $this->getPrincipalByPath($principal);

apps/dav/tests/unit/CalDAV/Search/Request/CalendarSearchReportTest.php

@@ -201,7 +201,7 @@ XML;
 </nc:calendar-search>
 XML;
 
-		$result = $this->parse($xml);
+		$this->parse($xml);
 	}
 
 	/**

apps/dav/tests/unit/CardDAV/SyncServiceTest.php

@@ -81,7 +81,7 @@ class SyncServiceTest extends TestCase {
 		$logger = $this->getMockBuilder(ILogger::class)->disableOriginalConstructor()->getMock();
 		$accountManager = $this->getMockBuilder(AccountManager::class)->disableOriginalConstructor()->getMock();
 		$ss = new SyncService($backend, $userManager, $logger, $accountManager);
-		$book = $ss->ensureSystemAddressBookExists('principals/users/adam', 'contacts', []);
+		$ss->ensureSystemAddressBookExists('principals/users/adam', 'contacts', []);
 	}
 
 	public function testUpdateAndDeleteUser() {

apps/files/js/detailsview.js

@@ -78,9 +78,6 @@
 			this._detailFileInfoViews = [];
 
 			this._dirty = true;
-
-			// uncomment to add some dummy tabs for testing
-			//this._addTestTabs();
 		},
 
 		_onClose: function(event) {
@@ -102,21 +99,6 @@
 			this.selectTab(tabId);
 		},
 
-		_addTestTabs: function() {
-			for (var j = 0; j < 2; j++) {
-				var testView = new OCA.Files.DetailTabView({id: 'testtab' + j});
-				testView.index = j;
-				testView.getLabel = function() { return 'Test tab ' + this.index; };
-				testView.render = function() {
-					this.$el.empty();
-					for (var i = 0; i < 100; i++) {
-						this.$el.append('<div>Test tab ' + this.index + ' row ' + i + '</div>');
-					}
-				};
-				this._tabViews.push(testView);
-			}
-		},
-
 		template: function(vars) {
 			if (!this._template) {
 				this._template = Handlebars.compile(TEMPLATE);

apps/files/js/favoritesfilelist.js

@@ -66,7 +66,6 @@ $(document).ready(function() {
 			},
 
 			reload: function() {
-				var tagName = OC.TAG_FAVORITE;
 				this.showMask();
 				if (this._reloadCall) {
 					this._reloadCall.abort();

apps/files/lib/Command/Scan.php

@@ -322,7 +322,7 @@ class Scan extends Base {
 	 * @return string
 	 */
 	protected function formatExecTime() {
-		list($secs, $tens) = explode('.', sprintf("%.1f", ($this->execTime)));
+		list($secs, ) = explode('.', sprintf("%.1f", ($this->execTime)));
 
 		# if you want to have microseconds add this:   . '.' . $tens;
 		return date('H:i:s', $secs);

apps/files/lib/Command/ScanAppData.php

@@ -260,7 +260,7 @@ class ScanAppData extends Base {
 	 * @return string
 	 */
 	protected function formatExecTime() {
-		list($secs, $tens) = explode('.', sprintf("%.1f", ($this->execTime)));
+		list($secs, ) = explode('.', sprintf("%.1f", ($this->execTime)));
 
 		# if you want to have microseconds add this:   . '.' . $tens;
 		return date('H:i:s', $secs);

lib/private/legacy/files.php

@@ -340,7 +340,7 @@ class OC_Files {
 	 *
 	 * @param int $size file size in bytes
 	 * @param array $files override '.htaccess' and '.user.ini' locations
-	 * @return bool false on failure, size on success
+	 * @return bool|int false on failure, size on success
 	 */
 	public static function setUploadLimit($size, $files = []) {
 		//don't allow user to break his config

lib/public/AppFramework/Db/Mapper.php

@@ -244,7 +244,7 @@ abstract class Mapper {
 			}
 		}
 
-		$result = $query->execute();
+		$query->execute();
 
 		return $query;
 	}