sascha
/
nextcloud-server
mirror of https://github.com/nextcloud/server.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

feat: Serialize event data and author userid to webhook 

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
pull/45475/head
Côme Chilliet 2024-05-23 15:41:55 +07:00 committed by Côme Chilliet
parent 8d18607f80
commit d835d23e3a
1 changed files with 45 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
lib/private/EventDispatcher/WebhookCaller.php
Unescape Escape View File

@ -28,10 +28,14 @@ namespace OC\EventDispatcher;
use OCP\EventDispatcher\Event;
use OCP\Http\Client\IClientService;
use OCP\IUserSession;
use Psr\Log\LoggerInterface;
class WebhookCaller {
public function __construct(
private IClientService $clientService,
private IUserSession $userSession,
private LoggerInterface $logger,
) {
}
@ -42,12 +46,47 @@ class WebhookCaller {
array $options,
): void {
$client = $this->clientService->newClient();
$client->request($method, $uri, $options + ['query' => ['event' => $event::class]]);
if (!isset($options['body'])) {
$options['body'] = json_encode([
'event' => $this->serializeEvent($event),
'userid' => $this->userSession->getUser()?->getUID() ?? null,
]);
}
try {
$response = $client->request($method, $uri, $options + ['query' => ['event' => $event::class]]);
$statusCode = $response->getStatusCode();
if ($statusCode >= 200 && $statusCode < 300) {
$this->logger->warning('Webhook returned unexpected status code '.$statusCode, ['body' => $response->getBody()]);
} else {
$this->logger->debug('Webhook returned status code '.$statusCode, ['body' => $response->getBody()]);
}
} catch (\Exception $e) {
$this->logger->error('Webhook call failed: '.$e->getMessage(), ['exception' => $e]);
}
}
/**
* TODO:
* Serialization of the event
* Timeout or async
*/
private function serializeEvent(Event $event): array|\JsonSerializable {
if ($event instanceof \JsonSerializable) {
return $event;
} else {
/* Event is not serializable, we fallback to reflection to still send something */
$data = [];
$ref = new \ReflectionClass($event);
foreach ($ref->getMethods() as $method) {
if (str_starts_with($method->getName(), 'get')) {
$key = strtolower(substr($method->getName(), 3));
$value = $method->invoke($event);
if ($value instanceof \OCP\Files\FileInfo) {
$value = [
'id' => $value->getId(),
'path' => $value->getPath(),
];
}
$data[$key] = $value;
}
}
$this->logger->debug('Webhook had to use fallback to serialize event '.$event::class);
return $data;
}
}
}