sascha
/
nextcloud-server
mirror of https://github.com/nextcloud/server.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(user_ldap): Correctly cache that user exists to avoid a request on mapping new user 

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
pull/46114/head
Côme Chilliet 2024-07-09 09:27:10 +07:00
parent 4fb1d2f3e5
commit d2bc636a79
No known key found for this signature in database
GPG Key ID: A3E2F658B28C760A
3 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
apps/user_ldap/lib/Access.php
Unescape Escape View File

@ -734,6 +734,7 @@ class Access extends LDAPUtility {
*/
public function cacheUserExists(string $ocName): void {
$this->connection->writeToCache('userExists' . $ocName, true);
$this->connection->writeToCache('userExistsOnLDAP' . $ocName, true);
}
/**

2
apps/user_ldap/lib/User/Manager.php
Unescape Escape View File

@ -265,9 +265,7 @@ class Manager {
if ($this->isDeletedUser($id)) {
return true;
}
$this->logger->debug('username2dn({id})', ['id' => $id]);
$dn = $this->access->username2dn($id);
$this->logger->debug('end username2dn({id})', ['id' => $id]);
if ($dn !== false) {
return true;
}

2
apps/user_ldap/lib/User_LDAP.php
Unescape Escape View File

@ -463,7 +463,6 @@ class User_LDAP extends BackendUtility implements IUserBackend, UserInterface, I
$this->access->connection->writeToCache($cacheKey, $displayName);
}
if ($user instanceof OfflineUser) {
/** @var OfflineUser $user */
$displayName = $user->getDisplayName();
}
return $displayName;
@ -610,7 +609,6 @@ class User_LDAP extends BackendUtility implements IUserBackend, UserInterface, I
$uuid,
true
);
$this->access->cacheUserExists($username);
} else {
$this->logger->warning(
'Failed to map created LDAP user with userid {userid}, because UUID could not be determined',