sascha
/
nextcloud-server
mirror of https://github.com/nextcloud/server.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(dav): file request guest nickname encoding 

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
pull/49226/head
skjnldsv 2024-11-12 12:45:16 +07:00 committed by nextcloud-command
parent de1c175d39
commit bfe8f8af40
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
apps/dav/lib/Files/Sharing/FilesDropPlugin.php
Unescape Escape View File

@ -64,7 +64,7 @@ class FilesDropPlugin extends ServerPlugin {
// Extract the attributes for the file request
$isFileRequest = false;
$attributes = $this->share->getAttributes();
$nickName = $request->getHeader('X-NC-Nickname');
$nickName = $request->hasHeader('X-NC-Nickname') ? urldecode($request->getHeader('X-NC-Nickname')) : null;
if ($attributes !== null) {
$isFileRequest = $attributes->getAttribute('fileRequest', 'enabled') === true;
}

9
apps/files_sharing/src/public-file-request.ts
Unescape Escape View File

@ -3,12 +3,13 @@
* SPDX-License-Identifier: AGPL-3.0-or-later
*/
import { defineAsyncComponent } from 'vue'
import { getBuilder } from '@nextcloud/browser-storage'
import { getGuestNickname, setGuestNickname } from '@nextcloud/auth'
import { spawnDialog } from '@nextcloud/dialogs'
import { getUploader } from '@nextcloud/upload'
import { defineAsyncComponent } from 'vue'
import { spawnDialog } from '@nextcloud/dialogs'
import logger from './services/logger'
import { getBuilder } from '@nextcloud/browser-storage'
const storage = getBuilder('files_sharing').build()
@ -18,7 +19,7 @@ const storage = getBuilder('files_sharing').build()
*/
function registerFileRequestHeader(nickname: string) {
const uploader = getUploader()
uploader.setCustomHeader('X-NC-Nickname', nickname)
uploader.setCustomHeader('X-NC-Nickname', encodeURIComponent(nickname))
logger.debug('Nickname header registered for uploader', { headers: uploader.customHeaders })
}