sascha
/
nextcloud-server
mirror of https://github.com/nextcloud/server.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #56767 from nextcloud/backport/56729/stable32 

[stable32] fix(oracle): Add a warning for Oracle 11
pull/56778/head
Daniel 2025-12-01 16:53:26 +07:00 committed by GitHub
parent 8c09cdd07d baabe272f5
commit ae91cda87d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 36 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
apps/settings/lib/SetupChecks/SupportedDatabase.php
Unescape Escape View File

@ -26,6 +26,8 @@ class SupportedDatabase implements ISetupCheck {
private const MAX_MYSQL = '8.4';
private const MIN_POSTGRES = '13';
private const MAX_POSTGRES = '17';
private const MIN_ORACLE = '12.2';
private const MAX_ORACLE = '26';
public function __construct(
private IL10N $l10n,
@ -112,7 +114,29 @@ class SupportedDatabase implements ISetupCheck {
);
}
} elseif ($databasePlatform instanceof OraclePlatform) {
$version = 'Oracle';
$result = $this->connection->executeQuery('SELECT VERSION FROM PRODUCT_COMPONENT_VERSION');
$version = $result->fetchOne();
$result->closeCursor();
$versionLower = strtolower($version);
// we only care about X.Y not X.Y.Z differences
[$major, $minor, ] = explode('.', $versionLower);
$versionConcern = $major . '.' . $minor;
if (version_compare($versionConcern, self::MIN_ORACLE, '<') || version_compare($versionConcern, self::MAX_ORACLE, '>')) {
$extendedWarning = '';
if (version_compare($versionConcern, self::MIN_ORACLE, '<')) {
$extendedWarning = "\n" . $this->l10n->t('Nextcloud %d does not support your current version, so be sure to update the database before updating your Nextcloud Server.', [33]);
}
return SetupResult::warning(
$this->l10n->t(
'Oracle version "%1$s" detected. Oracle >=%2$s and <=%3$s is suggested for best performance, stability and functionality with this version of Nextcloud.',
[
$version,
self::MIN_ORACLE,
self::MAX_ORACLE,
])
. $extendedWarning
);
}
} elseif ($databasePlatform instanceof SqlitePlatform) {
return SetupResult::warning(
$this->l10n->t('SQLite is currently being used as the backend database. For larger installations we recommend that you switch to a different database backend. This is particularly recommended when using the desktop client for file synchronisation. To migrate to another database use the command line tool: "occ db:convert-type".'),

15
apps/settings/tests/SetupChecks/SupportedDatabaseTest.php
Unescape Escape View File

@ -41,11 +41,18 @@ class SupportedDatabaseTest extends TestCase {
}
public function testPass(): void {
$severities = [SetupResult::SUCCESS, SetupResult::INFO];
if ($this->connection->getDatabaseProvider() === IDBConnection::PLATFORM_SQLITE) {
/** SQlite always gets a warning */
$this->assertEquals(SetupResult::WARNING, $this->check->run()->getSeverity());
} else {
$this->assertContains($this->check->run()->getSeverity(), [SetupResult::SUCCESS, SetupResult::INFO]);
$severities = [SetupResult::WARNING];
} elseif ($this->connection->getDatabaseProvider(true) === IDBConnection::PLATFORM_ORACLE) {
$result = $this->connection->executeQuery('SELECT VERSION FROM PRODUCT_COMPONENT_VERSION');
$version = $result->fetchOne();
$result->closeCursor();
if (str_starts_with($version, '11.')) {
$severities = [SetupResult::WARNING];
}
}
$this->assertContains($this->check->run()->getSeverity(), $severities, 'Oracle 11 and SQLite expect a warning, other databases should be success or info only');
}
}