sascha
/
nextcloud-server
mirror of https://github.com/nextcloud/server.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #31219 from nextcloud/fix/performance-db-convert 

Improve performance when converting between DBs
pull/31353/head
blizzz 2022-02-24 23:25:41 +07:00 committed by GitHub
parent d7e55e272e db6927ee05
commit abbbae1fc8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 25 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
core/Command/Db/ConvertType.php
Unescape Escape View File

@ -353,27 +353,37 @@ class ConvertType extends Command implements CompletionAwareInterface {
$result = $query->execute();
while ($row = $result->fetch()) {
$progress->advance();
if (!$parametersCreated) {
foreach ($row as $key => $value) {
$insertQuery->setValue($key, $insertQuery->createParameter($key));
try {
$toDB->beginTransaction();
while ($row = $result->fetch()) {
$progress->advance();
if (!$parametersCreated) {
foreach ($row as $key => $value) {
$insertQuery->setValue($key, $insertQuery->createParameter($key));
}
$parametersCreated = true;
}
$parametersCreated = true;
}
foreach ($row as $key => $value) {
$type = $this->getColumnType($table, $key);
if ($type !== false) {
$insertQuery->setParameter($key, $value, $type);
} else {
$insertQuery->setParameter($key, $value);
foreach ($row as $key => $value) {
$type = $this->getColumnType($table, $key);
if ($type !== false) {
$insertQuery->setParameter($key, $value, $type);
} else {
$insertQuery->setParameter($key, $value);
}
}
$insertQuery->execute();
}
$insertQuery->execute();
$result->closeCursor();
$toDB->commit();
} catch (\Throwable $e) {
$toDB->rollBack();
throw $e;
}
$result->closeCursor();
}
$progress->finish();
$output->writeln('');
}