From a25797330b61bef892cbab333b953bcffcb39ab0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=B4me=20Chilliet?= Date: Mon, 18 Aug 2025 17:25:07 +0200 Subject: [PATCH] fix: Log that using an appinfo/install.php file is deprecated MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit appinfo/install.php is not part of the official documentation for application development but some apps are still using such a file. Log a message to deprecate this behavior, to be able to remove support for this later. Signed-off-by: Côme Chilliet --- lib/private/Installer.php | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/private/Installer.php b/lib/private/Installer.php index bb437b49db9..e40e77c8b50 100644 --- a/lib/private/Installer.php +++ b/lib/private/Installer.php @@ -558,8 +558,14 @@ class Installer { $queue->add($job); } - // Run appinfo/install.php - self::includeAppScript($appPath . '/appinfo/install.php'); + // Run deprecated appinfo/install.php if any + $appInstallScriptPath = $appPath . '/appinfo/install.php'; + if (file_exists($appInstallScriptPath)) { + $this->logger->warning('Using an appinfo/install.php file is deprecated. Application "{app}" still uses one.', [ + 'app' => $info['id'], + ]); + self::includeAppScript($appInstallScriptPath); + } \OC_App::executeRepairSteps($info['id'], $info['repair-steps']['install']);