From a6d2b205795f179d89639022b2461f39a5e49bcd Mon Sep 17 00:00:00 2001 From: Max Date: Wed, 4 Oct 2023 18:47:13 +0200 Subject: [PATCH] fix(cypress): runs on integration branches Empty `group`, `tag` and `ci-build-id` when `record` is false. When not using cypress cloud these need to be empty. Note that cypress expects strings for group and tag. Therefore `false` will be interpreted as `"false"`. Use an empty string instead. Signed-off-by: Max --- .github/workflows/cypress.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/cypress.yml b/.github/workflows/cypress.yml index b4e14ad0a8e..c0ec920044c 100644 --- a/.github/workflows/cypress.yml +++ b/.github/workflows/cypress.yml @@ -103,14 +103,14 @@ jobs: - name: Run ${{ matrix.containers == 'component' && 'component' || 'E2E' }} cypress tests uses: cypress-io/github-action@59810ebfa5a5ac6fcfdcfdf036d1cd4d083a88f2 # v6.5.0 with: - record: '${{ !!matrix.use-cypress-cloud }}' - parallel: '${{ !!matrix.use-cypress-cloud }}' + record: ${{ !!matrix.use-cypress-cloud }} + parallel: ${{ !!matrix.use-cypress-cloud }} # cypress run type component: ${{ matrix.containers == 'component' }} - group: ${{ matrix.use-cypress-cloud && matrix.containers == 'component' && 'Run component' || matrix.use-cypress-cloud || 'Run E2E' }} + group: ${{ matrix.use-cypress-cloud && matrix.containers == 'component' && 'Run component' || matrix.use-cypress-cloud && 'Run E2E' || '' }} # cypress env - ci-build-id: ${{ github.sha }}-${{ github.run_number }} - tag: ${{ matrix.use-cypress-cloud && github.event_name }} + ci-build-id: ${{ matrix.use-cypress-cloud && format('{0}-{1}', github.sha, github.run_number) || '' }} + tag: ${{ matrix.use-cypress-cloud && github.event_name || '' }} env: # Needs to be prefixed with CYPRESS_ CYPRESS_BRANCH: ${{ env.BRANCH }}