fix: rename params old path passed from before rename to after rename to have one log for rename event

Signed-off-by: yemkareems <yemkareems@gmail.com>
pull/45845/head
yemkareems 2024-06-13 17:35:15 +07:00
parent 3e355c4db1
commit 953358fdc8
2 changed files with 12 additions and 13 deletions

@ -26,6 +26,8 @@ use Psr\Log\LoggerInterface;
* @package OCA\AdminAudit\Actions
*/
class Files extends Action {
private array|null $renameParams = null;
/**
* Logs file read actions
*
@ -68,12 +70,7 @@ class Files extends Action {
);
return;
}
$this->log(
'File with id "%s" renamed from "%s"',
$params,
array_keys($params)
);
$this->renameParams = $params;
}
/**
@ -84,8 +81,10 @@ class Files extends Action {
public function afterRename(NodeRenamedEvent $event): void {
try {
$target = $event->getTarget();
$renameParams = $this->renameParams;
$params = [
'newid' => $target->getId(),
'oldpath' => $renameParams['oldpath'],
'newpath' => mb_substr($target->getInternalPath(), 5),
];
} catch (InvalidPathException|NotFoundException $e) {
@ -96,7 +95,7 @@ class Files extends Action {
}
$this->log(
'File with id "%s" renamed to "%s"',
'File renamed with id "%s" from "%s" to "%s"',
$params,
array_keys($params)
);

@ -181,16 +181,16 @@ class Application extends App implements IBootstrap {
);
$eventDispatcher->addListener(
NodeRenamedEvent::class,
function (NodeRenamedEvent $event) use ($fileActions) {
$fileActions->afterRename($event);
BeforeNodeRenamedEvent::class,
function (BeforeNodeRenamedEvent $event) use ($fileActions) {
$fileActions->beforeRename($event);
}
);
$eventDispatcher->addListener(
BeforeNodeRenamedEvent::class,
function (BeforeNodeRenamedEvent $event) use ($fileActions) {
$fileActions->beforeRename($event);
NodeRenamedEvent::class,
function (NodeRenamedEvent $event) use ($fileActions) {
$fileActions->afterRename($event);
}
);