sascha
/
nextcloud-server
mirror of https://github.com/nextcloud/server.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #47627 from nextcloud/fix/noid/link-ref-provider-size-check 

[LinkReferenceProvider] Better size check
pull/47635/head
Julien Veyssier 2024-09-02 12:33:21 +07:00 committed by GitHub
parent dc86ccf074 22bb42be0c
commit 873c42b0f1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
lib/public/Collaboration/Reference/LinkReferenceProvider.php
Unescape Escape View File

@ -122,7 +122,7 @@ class LinkReferenceProvider implements IReferenceProvider, IPublicReferenceProvi
$linkContentLength = $headResponse->getHeader('Content-Length');
if (is_numeric($linkContentLength) && (int)$linkContentLength > self::MAX_CONTENT_LENGTH) {
$this->logger->debug('Skip resolving links pointing to content length > 5 MiB');
$this->logger->debug('[Head] Skip resolving links pointing to content length > 5 MiB');
return;
}
@ -136,18 +136,28 @@ class LinkReferenceProvider implements IReferenceProvider, IPublicReferenceProvi
}
try {
$response = $client->get($reference->getId(), [ 'timeout' => 10 ]);
$response = $client->get($reference->getId(), [ 'timeout' => 10, 'stream' => true ]);
} catch (\Exception $e) {
$this->logger->debug('Failed to fetch link for obtaining open graph data', ['exception' => $e]);
return;
}
$responseBody = (string)$response->getBody();
$body = $response->getBody();
if (is_resource($body)) {
$responseContent = fread($body, self::MAX_CONTENT_LENGTH);
if (!feof($body)) {
$this->logger->debug('[Get] Skip resolving links pointing to content length > 5 MiB');
return;
}
} else {
$this->logger->error('[Get] Impossible to check content length');
return;
}
// OpenGraph handling
$consumer = new Consumer();
$consumer->useFallbackMode = true;
$object = $consumer->loadHtml($responseBody);
$object = $consumer->loadHtml($responseContent);
$reference->setUrl($reference->getId());