Refactor core/Command/Background

Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

core/Command/Background/Ajax.php

@@ -26,7 +26,7 @@
 namespace OC\Core\Command\Background;
 
 class Ajax extends Base {
-	protected function getMode() {
+	protected function getMode(): string {
 		return 'ajax';
 	}
 }

core/Command/Background/Base.php

@@ -45,7 +45,7 @@ abstract class Base extends Command {
 		parent::__construct();
 	}
 
-	protected function configure() {
+	protected function configure(): void {
 		$mode = $this->getMode();
 		$this
 			->setName("background:$mode")
@@ -59,6 +59,7 @@ abstract class Base extends Command {
 	 *
 	 * @param InputInterface $input
 	 * @param OutputInterface $output
+	 * @return int
 	 */
 	protected function execute(InputInterface $input, OutputInterface $output): int {
 		$mode = $this->getMode();

core/Command/Background/Cron.php

@@ -26,7 +26,7 @@
 namespace OC\Core\Command\Background;
 
 class Cron extends Base {
-	protected function getMode() {
+	protected function getMode(): string {
 		return 'cron';
 	}
 }

core/Command/Background/Job.php

@@ -58,6 +58,9 @@ class Job extends Command {
 		;
 	}
 
+	/**
+	 * @throws \ReflectionException
+	 */
 	protected function execute(InputInterface $input, OutputInterface $output): int {
 		$jobId = (int) $input->getArgument('job-id');
 
@@ -102,7 +105,10 @@ class Job extends Command {
 		return 0;
 	}
 
-	protected function printJobInfo(int $jobId, IJob $job, OutputInterface$output): void {
+	/**
+	 * @throws \ReflectionException
+	 */
+	protected function printJobInfo(int $jobId, IJob $job, OutputInterface $output): void {
 		$row = $this->jobList->getDetailsById($jobId);
 
 		$lastRun = new \DateTime();

core/Command/Background/WebCron.php

@@ -26,7 +26,7 @@
 namespace OC\Core\Command\Background;
 
 class WebCron extends Base {
-	protected function getMode() {
+	protected function getMode(): string {
 		return 'webcron';
 	}
 }