From 6edbeb7052fc0e5f8107716254ef66f1ae460987 Mon Sep 17 00:00:00 2001 From: Christopher Ng Date: Tue, 25 Mar 2025 14:31:44 -0700 Subject: [PATCH] fix(settings): Only change usercount if group can be found Signed-off-by: Christopher Ng --- apps/settings/src/store/users.js | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/apps/settings/src/store/users.js b/apps/settings/src/store/users.js index b7e6070ff56..65b154b1b35 100644 --- a/apps/settings/src/store/users.js +++ b/apps/settings/src/store/users.js @@ -159,6 +159,9 @@ const mutations = { state.userCount += user.enabled ? 1 : -1 // update Active Users count user.groups.forEach(userGroup => { const group = state.groups.find(groupSearch => groupSearch.id === userGroup) + if (!group) { + return + } group.disabled += user.enabled ? -1 : 1 // update group disabled count }) break @@ -167,9 +170,11 @@ const mutations = { state.userCount++ // increment Active Users count user.groups.forEach(userGroup => { - state.groups - .find(groupSearch => groupSearch.id === userGroup) - .usercount++ // increment group total count + const group = state.groups.find(groupSearch => groupSearch.id === userGroup) + if (!group) { + return + } + group.usercount++ // increment group total count }) break case 'remove': @@ -188,6 +193,9 @@ const mutations = { disabledGroup.usercount-- // decrement Disabled Users count user.groups.forEach(userGroup => { const group = state.groups.find(groupSearch => groupSearch.id === userGroup) + if (!group) { + return + } group.disabled-- // decrement group disabled count }) }