sascha
/
nextcloud-server
mirror of https://github.com/nextcloud/server.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(settings): Fix log file download return type 

Signed-off-by: provokateurin <kate@provokateurin.de>
pull/50089/head
provokateurin 2024-12-16 16:18:40 +07:00 committed by backportbot[bot]
parent 9de0452071
commit 6eb843cc57
3 changed files with 17 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
apps/settings/lib/Controller/LogSettingsController.php
Unescape Escape View File

@ -27,9 +27,7 @@ class LogSettingsController extends Controller {
/**
* download logfile
*
* @psalm-suppress MoreSpecificReturnType The value of Content-Disposition is not relevant
* @psalm-suppress LessSpecificReturnStatement The value of Content-Disposition is not relevant
* @return StreamResponse<Http::STATUS_OK, array{Content-Type: 'application/octet-stream', 'Content-Disposition': string}>
* @return StreamResponse<Http::STATUS_OK, array{Content-Type: 'application/octet-stream', 'Content-Disposition': 'attachment; filename="nextcloud.log"'}>
*
* 200: Logfile returned
*/
@ -38,11 +36,13 @@ class LogSettingsController extends Controller {
if (!$this->log instanceof Log) {
throw new \UnexpectedValueException('Log file not available');
}
$resp = new StreamResponse($this->log->getLogPath());
$resp->setHeaders([
'Content-Type' => 'application/octet-stream',
'Content-Disposition' => 'attachment; filename="nextcloud.log"',
]);
return $resp;
return new StreamResponse(
$this->log->getLogPath(),
Http::STATUS_OK,
[
'Content-Type' => 'application/octet-stream',
'Content-Disposition' => 'attachment; filename="nextcloud.log"',
],
);
}
}

5
apps/settings/openapi-administration.json
Unescape Escape View File

@ -44,7 +44,10 @@
"headers": {
"Content-Disposition": {
"schema": {
"type": "string"
"type": "string",
"enum": [
"attachment; filename=\"nextcloud.log\""
]
}
}
},

5
apps/settings/openapi-full.json
Unescape Escape View File

@ -221,7 +221,10 @@
"headers": {
"Content-Disposition": {
"schema": {
"type": "string"
"type": "string",
"enum": [
"attachment; filename=\"nextcloud.log\""
]
}
}
},