From 63fa7d93540fcc415d3a1069da4fb93f15ad08c0 Mon Sep 17 00:00:00 2001 From: acsfer Date: Sun, 25 Apr 2021 13:50:23 +0200 Subject: [PATCH] PHP 8+ deprecates openssl_free_key --- lib/private/Installer.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/private/Installer.php b/lib/private/Installer.php index 086afaa4755..7b9706f65af 100644 --- a/lib/private/Installer.php +++ b/lib/private/Installer.php @@ -309,7 +309,10 @@ class Installer { // Check if the signature actually matches the downloaded content $certificate = openssl_get_publickey($app['certificate']); $verified = (bool)openssl_verify(file_get_contents($tempFile), base64_decode($app['releases'][0]['signature']), $certificate, OPENSSL_ALGO_SHA512); - openssl_free_key($certificate); + // PHP 8+ deprecates openssl_free_key and automatically destroys the key instance when it goes out of scope + if ((PHP_VERSION_ID < 80000)) { + openssl_free_key($certificate); + } if ($verified === true) { // Seems to match, let's proceed