From deb2495f89697519e0468b29b94351d3ba99055b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= Date: Thu, 8 Mar 2018 14:07:49 +0100 Subject: [PATCH 1/2] Add automatic handling of MoveTargetOutOfBounds exceptions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit MoveTargetOutOfBounds exceptions are sometimes thrown instead of ElementNotVisible exceptions. This can happen when the Selenium2 driver for Mink moves the cursor on an element using the "moveto" method of the Webdriver session, for example, before clicking on an element. In that case, if the element is not visible, "moveto" would throw a MoveTargetOutOfBounds exception instead of an ElementNotVisible exception, so those cases are handled like ElementNotVisible exceptions. Note that MoveTargetOutOfBounds exceptions could be thrown too if the element was visible but "out of reach"; there is no problem in handling those cases as if the element was not visible, as the exception will be thrown again anyway once it is verified that the element is indeed visible. Signed-off-by: Daniel Calviño Sánchez --- .../features/core/ElementWrapper.php | 20 ++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/tests/acceptance/features/core/ElementWrapper.php b/tests/acceptance/features/core/ElementWrapper.php index f6ce176817b..c46ee140340 100644 --- a/tests/acceptance/features/core/ElementWrapper.php +++ b/tests/acceptance/features/core/ElementWrapper.php @@ -50,11 +50,22 @@ * exceptions; if the element is not visible it is waited for it to be visible * up to the timeout set to find it. * + * MoveTargetOutOfBounds exceptions are sometimes thrown instead of + * ElementNotVisible exceptions. This can happen when the Selenium2 driver for + * Mink moves the cursor on an element using the "moveto" method of the + * WebDriver session, for example, before clicking on an element. In that case, + * if the element is not visible, "moveto" would throw a MoveTargetOutOfBounds + * exception instead of an ElementNotVisible exception, so those cases are + * handled like ElementNotVisible exceptions. + * * Despite the automatic handling it is possible for the commands to throw those * exceptions when they are executed again; this class does not handle cases * like an element becoming stale several times in a row (uncommon) or an * element not becoming visible before the timeout expires (which would mean - * that the timeout is too short or that the test has to, indeed, fail). + * that the timeout is too short or that the test has to, indeed, fail). In a + * similar way, MoveTargetOutOfBounds exceptions would be thrown again if + * originally they were thrown because the element was visible but "out of + * reach". * * If needed, automatically handling failed commands can be disabled calling * "doNotHandleFailedCommands()"; as it returns the ElementWrapper it can be @@ -217,8 +228,9 @@ class ElementWrapper { * * If a StaleElementReference exception is thrown the wrapped element is * found again and, then, the command is executed again. If an - * ElementNotVisible exception is thrown it is waited for the wrapped - * element to be visible and, then, the command is executed again. + * ElementNotVisible or a MoveTargetOutOfBounds exception is thrown it is + * waited for the wrapped element to be visible and, then, the command is + * executed again. * * @param \Closure $commandCallback the command to execute. * @param string $errorMessage an error message that describes the failed @@ -233,6 +245,8 @@ class ElementWrapper { return $this->executeCommand($commandCallback, $errorMessage); } catch (\WebDriver\Exception\ElementNotVisible $exception) { $this->printFailedCommandMessage($exception, $errorMessage); + } catch (\WebDriver\Exception\MoveTargetOutOfBounds $exception) { + $this->printFailedCommandMessage($exception, $errorMessage); } $this->waitForElementToBeVisible(); From c1fa0f8b86cfdc7d779f815f71069f3e842b0ce9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= Date: Thu, 8 Mar 2018 14:54:01 +0100 Subject: [PATCH 2/2] Add automatic handling of NoSuchElement exceptions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit NoSuchElement exceptions are sometimes thrown instead of StaleElementReference exceptions. This can happen when the Selenium2 driver for Mink performs an action on an element through the WebDriver session instead of directly through the WebDriver element. In that case, if the element with the given ID does not exist, a NoSuchElement exception would be thrown instead of a StaleElementReference exception, so those cases are handled like StaleElementReference exceptions. Signed-off-by: Daniel Calviño Sánchez --- .../features/core/ElementWrapper.php | 22 ++++++++++++++----- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/tests/acceptance/features/core/ElementWrapper.php b/tests/acceptance/features/core/ElementWrapper.php index c46ee140340..6f814921125 100644 --- a/tests/acceptance/features/core/ElementWrapper.php +++ b/tests/acceptance/features/core/ElementWrapper.php @@ -38,6 +38,14 @@ * the element is stale it is found again using the same parameters to find it * in the first place. * + * NoSuchElement exceptions are sometimes thrown instead of + * StaleElementReference exceptions. This can happen when the Selenium2 driver + * for Mink performs an action on an element through the WebDriver session + * instead of directly through the WebDriver element. In that case, if the + * element with the given ID does not exist, a NoSuchElement exception would be + * thrown instead of a StaleElementReference exception, so those cases are + * handled like StaleElementReference exceptions. + * * ElementNotVisible exceptions are thrown when the command requires the element * to be visible but the element is not. Finding an element only guarantees that * (at that time) the element is attached to the DOM, but it does not provide @@ -200,8 +208,8 @@ class ElementWrapper { /** * Executes the given command. * - * If a StaleElementReference exception is thrown the wrapped element is - * found again and, then, the command is executed again. + * If a StaleElementReference or a NoSuchElement exception is thrown the + * wrapped element is found again and, then, the command is executed again. * * @param \Closure $commandCallback the command to execute. * @param string $errorMessage an error message that describes the failed @@ -216,6 +224,8 @@ class ElementWrapper { return $commandCallback(); } catch (\WebDriver\Exception\StaleElementReference $exception) { $this->printFailedCommandMessage($exception, $errorMessage); + } catch (\WebDriver\Exception\NoSuchElement $exception) { + $this->printFailedCommandMessage($exception, $errorMessage); } $this->element = $this->elementFinder->find(); @@ -226,10 +236,10 @@ class ElementWrapper { /** * Executes the given command on a visible element. * - * If a StaleElementReference exception is thrown the wrapped element is - * found again and, then, the command is executed again. If an - * ElementNotVisible or a MoveTargetOutOfBounds exception is thrown it is - * waited for the wrapped element to be visible and, then, the command is + * If a StaleElementReference or a NoSuchElement exception is thrown the + * wrapped element is found again and, then, the command is executed again. + * If an ElementNotVisible or a MoveTargetOutOfBounds exception is thrown it + * is waited for the wrapped element to be visible and, then, the command is * executed again. * * @param \Closure $commandCallback the command to execute.