Merge pull request #8594 from nextcloud/add-acceptance-tests-for-permissions-on-public-shared-folders
Add acceptance tests for permissions on public shared folderspull/8731/head
Morris Jobke
GitHub
commit
5924f9cb30
@ -0,0 +1,67 @@
|
||||
<?php
|
||||
|
||||
/**
|
||||
*
|
||||
* @copyright Copyright (c) 2018, Daniel Calviño Sánchez (danxuliu@gmail.com)
|
||||
*
|
||||
* @license GNU AGPL version 3 or any later version
|
||||
*
|
||||
* This program is free software: you can redistribute it and/or modify
|
||||
* it under the terms of the GNU Affero General Public License as
|
||||
* published by the Free Software Foundation, either version 3 of the
|
||||
* License, or (at your option) any later version.
|
||||
*
|
||||
* This program is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU Affero General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU Affero General Public License
|
||||
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
*
|
||||
*/
|
||||
|
||||
use Behat\Behat\Context\Context;
|
||||
use Behat\Behat\Hook\Scope\BeforeScenarioScope;
|
||||
|
||||
/**
|
||||
* Helper trait to set the ancestor of the file list.
|
||||
*
|
||||
* The FileListContext provides steps to interact with and check the behaviour
|
||||
* of a file list. However, the FileListContext does not know the right file
|
||||
* list ancestor that has to be used by the file list steps; this has to be set
|
||||
* from other contexts, for example, when the Files app or the public page for a
|
||||
* shared folder is opened.
|
||||
*
|
||||
* Contexts that "know" that certain file list ancestor has to be used by the
|
||||
* FileListContext steps should use this trait and call
|
||||
* "setFileListAncestorForActor" when needed.
|
||||
*/
|
||||
trait FileListAncestorSetter {
|
||||
|
||||
/**
|
||||
* @var FileListContext
|
||||
*/
|
||||
private $fileListContext;
|
||||
|
||||
/**
|
||||
* @BeforeScenario
|
||||
*/
|
||||
public function getSiblingFileListContext(BeforeScenarioScope $scope) {
|
||||
$environment = $scope->getEnvironment();
|
||||
|
||||
$this->fileListContext = $environment->getContext("FileListContext");
|
||||
}
|
||||
|
||||
/**
|
||||
* Sets the file list ancestor to be used in the file list steps performed
|
||||
* by the given actor.
|
||||
*
|
||||
* @param null|Locator $fileListAncestor the file list ancestor
|
||||
* @param Actor $actor the actor
|
||||
*/
|
||||
private function setFileListAncestorForActor($fileListAncestor, Actor $actor) {
|
||||
$this->fileListContext->setFileListAncestorForActor($fileListAncestor, $actor);
|
||||
}
|
||||
|
||||
}
|
||||
@ -0,0 +1,374 @@
|
||||
<?php
|
||||
|
||||
/**
|
||||
*
|
||||
* @copyright Copyright (c) 2018, Daniel Calviño Sánchez (danxuliu@gmail.com)
|
||||
*
|
||||
* @license GNU AGPL version 3 or any later version
|
||||
*
|
||||
* This program is free software: you can redistribute it and/or modify
|
||||
* it under the terms of the GNU Affero General Public License as
|
||||
* published by the Free Software Foundation, either version 3 of the
|
||||
* License, or (at your option) any later version.
|
||||
*
|
||||
* This program is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU Affero General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU Affero General Public License
|
||||
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
*
|
||||
*/
|
||||
|
||||
use Behat\Behat\Context\Context;
|
||||
|
||||
class FileListContext implements Context, ActorAwareInterface {
|
||||
|
||||
/**
|
||||
* @var Actor
|
||||
*/
|
||||
private $actor;
|
||||
|
||||
/**
|
||||
* @var array
|
||||
*/
|
||||
private $fileListAncestorsByActor;
|
||||
|
||||
/**
|
||||
* @var Locator
|
||||
*/
|
||||
private $fileListAncestor;
|
||||
|
||||
/**
|
||||
* @BeforeScenario
|
||||
*/
|
||||
public function initializeFileListAncestors() {
|
||||
$this->fileListAncestorsByActor = array();
|
||||
$this->fileListAncestor = null;
|
||||
}
|
||||
|
||||
/**
|
||||
* @param Actor $actor
|
||||
*/
|
||||
public function setCurrentActor(Actor $actor) {
|
||||
$this->actor = $actor;
|
||||
|
||||
if (array_key_exists($actor->getName(), $this->fileListAncestorsByActor)) {
|
||||
$this->fileListAncestor = $this->fileListAncestorsByActor[$actor->getName()];
|
||||
} else {
|
||||
$this->fileListAncestor = null;
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Sets the file list ancestor to be used in the steps performed by the
|
||||
* given actor from that point on (until changed again).
|
||||
*
|
||||
* This is meant to be called from other contexts, for example, when the
|
||||
* Files app or the public page for a shared folder are opened.
|
||||
*
|
||||
* The FileListAncestorSetter trait can be used to reduce the boilerplate
|
||||
* needed to set the file list ancestor from other contexts.
|
||||
*
|
||||
* @param null|Locator $fileListAncestor the file list ancestor
|
||||
* @param Actor $actor the actor
|
||||
*/
|
||||
public function setFileListAncestorForActor($fileListAncestor, Actor $actor) {
|
||||
$this->fileListAncestorsByActor[$actor->getName()] = $fileListAncestor;
|
||||
}
|
||||
|
||||
/**
|
||||
* @return Locator
|
||||
*/
|
||||
public static function mainWorkingIcon($fileListAncestor) {
|
||||
return Locator::forThe()->css(".mask.icon-loading")->
|
||||
descendantOf($fileListAncestor)->
|
||||
describedAs("Main working icon in file list");
|
||||
}
|
||||
|
||||
/**
|
||||
* @return Locator
|
||||
*/
|
||||
public static function createMenuButton($fileListAncestor) {
|
||||
return Locator::forThe()->css("#controls .button.new")->
|
||||
descendantOf($fileListAncestor)->
|
||||
describedAs("Create menu button in file list");
|
||||
}
|
||||
|
||||
/**
|
||||
* @return Locator
|
||||
*/
|
||||
private static function createMenuItemFor($fileListAncestor, $newType) {
|
||||
return Locator::forThe()->xpath("//div[contains(concat(' ', normalize-space(@class), ' '), ' newFileMenu ')]//span[normalize-space() = '$newType']/ancestor::li")->
|
||||
descendantOf($fileListAncestor)->
|
||||
describedAs("Create $newType menu item in file list");
|
||||
}
|
||||
|
||||
/**
|
||||
* @return Locator
|
||||
*/
|
||||
public static function createNewFolderMenuItem($fileListAncestor) {
|
||||
return self::createMenuItemFor($fileListAncestor, "New folder");
|
||||
}
|
||||
|
||||
/**
|
||||
* @return Locator
|
||||
*/
|
||||
public static function createNewFolderMenuItemNameInput($fileListAncestor) {
|
||||
return Locator::forThe()->css(".filenameform input")->
|
||||
descendantOf(self::createNewFolderMenuItem($fileListAncestor))->
|
||||
describedAs("Name input in create new folder menu item in file list");
|
||||
}
|
||||
|
||||
/**
|
||||
* @return Locator
|
||||
*/
|
||||
public static function rowForFile($fileListAncestor, $fileName) {
|
||||
return Locator::forThe()->xpath("//*[@id = 'fileList']//span[contains(concat(' ', normalize-space(@class), ' '), ' nametext ') and normalize-space() = '$fileName']/ancestor::tr")->
|
||||
descendantOf($fileListAncestor)->
|
||||
describedAs("Row for file $fileName in file list");
|
||||
}
|
||||
|
||||
/**
|
||||
* @return Locator
|
||||
*/
|
||||
public static function rowForFilePreceding($fileListAncestor, $fileName1, $fileName2) {
|
||||
return Locator::forThe()->xpath("//preceding-sibling::tr//span[contains(concat(' ', normalize-space(@class), ' '), ' nametext ') and normalize-space() = '$fileName1']/ancestor::tr")->
|
||||
descendantOf(self::rowForFile($fileListAncestor, $fileName2))->
|
||||
describedAs("Row for file $fileName1 preceding $fileName2 in file list");
|
||||
}
|
||||
|
||||
/**
|
||||
* @return Locator
|
||||
*/
|
||||
public static function favoriteMarkForFile($fileListAncestor, $fileName) {
|
||||
return Locator::forThe()->css(".favorite-mark")->
|
||||
descendantOf(self::rowForFile($fileListAncestor, $fileName))->
|
||||
describedAs("Favorite mark for file $fileName in file list");
|
||||
}
|
||||
|
||||
/**
|
||||
* @return Locator
|
||||
*/
|
||||
public static function notFavoritedStateIconForFile($fileListAncestor, $fileName) {
|
||||
return Locator::forThe()->css(".icon-star")->
|
||||
descendantOf(self::favoriteMarkForFile($fileListAncestor, $fileName))->
|
||||
describedAs("Not favorited state icon for file $fileName in file list");
|
||||
}
|
||||
|
||||
/**
|
||||
* @return Locator
|
||||
*/
|
||||
public static function favoritedStateIconForFile($fileListAncestor, $fileName) {
|
||||
return Locator::forThe()->css(".icon-starred")->
|
||||
descendantOf(self::favoriteMarkForFile($fileListAncestor, $fileName))->
|
||||
describedAs("Favorited state icon for file $fileName in file list");
|
||||
}
|
||||
|
||||
/**
|
||||
* @return Locator
|
||||
*/
|
||||
public static function mainLinkForFile($fileListAncestor, $fileName) {
|
||||
return Locator::forThe()->css(".name")->
|
||||
descendantOf(self::rowForFile($fileListAncestor, $fileName))->
|
||||
describedAs("Main link for file $fileName in file list");
|
||||
}
|
||||
|
||||
/**
|
||||
* @return Locator
|
||||
*/
|
||||
public static function renameInputForFile($fileListAncestor, $fileName) {
|
||||
return Locator::forThe()->css("input.filename")->
|
||||
descendantOf(self::rowForFile($fileListAncestor, $fileName))->
|
||||
describedAs("Rename input for file $fileName in file list");
|
||||
}
|
||||
|
||||
/**
|
||||
* @return Locator
|
||||
*/
|
||||
public static function shareActionForFile($fileListAncestor, $fileName) {
|
||||
return Locator::forThe()->css(".action-share")->
|
||||
descendantOf(self::rowForFile($fileListAncestor, $fileName))->
|
||||
describedAs("Share action for file $fileName in file list");
|
||||
}
|
||||
|
||||
/**
|
||||
* @return Locator
|
||||
*/
|
||||
public static function fileActionsMenuButtonForFile($fileListAncestor, $fileName) {
|
||||
return Locator::forThe()->css(".action-menu")->
|
||||
descendantOf(self::rowForFile($fileListAncestor, $fileName))->
|
||||
describedAs("File actions menu button for file $fileName in file list");
|
||||
}
|
||||
|
||||
/**
|
||||
* @return Locator
|
||||
*/
|
||||
public static function fileActionsMenu() {
|
||||
return Locator::forThe()->css(".fileActionsMenu")->
|
||||
describedAs("File actions menu in file list");
|
||||
}
|
||||
|
||||
/**
|
||||
* @return Locator
|
||||
*/
|
||||
private static function fileActionsMenuItemFor($itemText) {
|
||||
return Locator::forThe()->xpath("//a[normalize-space() = '$itemText']")->
|
||||
descendantOf(self::fileActionsMenu())->
|
||||
describedAs($itemText . " item in file actions menu in file list");
|
||||
}
|
||||
|
||||
/**
|
||||
* @return Locator
|
||||
*/
|
||||
public static function addToFavoritesMenuItem() {
|
||||
return self::fileActionsMenuItemFor("Add to favorites");
|
||||
}
|
||||
|
||||
/**
|
||||
* @return Locator
|
||||
*/
|
||||
public static function removeFromFavoritesMenuItem() {
|
||||
return self::fileActionsMenuItemFor("Remove from favorites");
|
||||
}
|
||||
|
||||
/**
|
||||
* @return Locator
|
||||
*/
|
||||
public static function detailsMenuItem() {
|
||||
return self::fileActionsMenuItemFor("Details");
|
||||
}
|
||||
|
||||
/**
|
||||
* @return Locator
|
||||
*/
|
||||
public static function renameMenuItem() {
|
||||
return self::fileActionsMenuItemFor("Rename");
|
||||
}
|
||||
|
||||
/**
|
||||
* @return Locator
|
||||
*/
|
||||
public static function viewFileInFolderMenuItem() {
|
||||
return self::fileActionsMenuItemFor("View in folder");
|
||||
}
|
||||
|
||||
/**
|
||||
* @Given I create a new folder named :folderName
|
||||
*/
|
||||
public function iCreateANewFolderNamed($folderName) {
|
||||
$this->actor->find(self::createMenuButton($this->fileListAncestor), 10)->click();
|
||||
|
||||
$this->actor->find(self::createNewFolderMenuItem($this->fileListAncestor), 2)->click();
|
||||
$this->actor->find(self::createNewFolderMenuItemNameInput($this->fileListAncestor), 2)->setValue($folderName . "\r");
|
||||
}
|
||||
|
||||
/**
|
||||
* @Given I enter in the folder named :folderName
|
||||
*/
|
||||
public function iEnterInTheFolderNamed($folderName) {
|
||||
$this->actor->find(self::mainLinkForFile($this->fileListAncestor, $folderName), 10)->click();
|
||||
}
|
||||
|
||||
/**
|
||||
* @Given I open the details view for :fileName
|
||||
*/
|
||||
public function iOpenTheDetailsViewFor($fileName) {
|
||||
$this->actor->find(self::fileActionsMenuButtonForFile($this->fileListAncestor, $fileName), 10)->click();
|
||||
|
||||
$this->actor->find(self::detailsMenuItem(), 2)->click();
|
||||
}
|
||||
|
||||
/**
|
||||
* @Given I rename :fileName1 to :fileName2
|
||||
*/
|
||||
public function iRenameTo($fileName1, $fileName2) {
|
||||
$this->actor->find(self::fileActionsMenuButtonForFile($this->fileListAncestor, $fileName1), 10)->click();
|
||||
|
||||
$this->actor->find(self::renameMenuItem(), 2)->click();
|
||||
|
||||
$this->actor->find(self::renameInputForFile($this->fileListAncestor, $fileName1), 10)->setValue($fileName2 . "\r");
|
||||
}
|
||||
|
||||
/**
|
||||
* @Given I mark :fileName as favorite
|
||||
*/
|
||||
public function iMarkAsFavorite($fileName) {
|
||||
$this->iSeeThatIsNotMarkedAsFavorite($fileName);
|
||||
|
||||
$this->actor->find(self::fileActionsMenuButtonForFile($this->fileListAncestor, $fileName), 10)->click();
|
||||
|
||||
$this->actor->find(self::addToFavoritesMenuItem(), 2)->click();
|
||||
}
|
||||
|
||||
/**
|
||||
* @Given I unmark :fileName as favorite
|
||||
*/
|
||||
public function iUnmarkAsFavorite($fileName) {
|
||||
$this->iSeeThatIsMarkedAsFavorite($fileName);
|
||||
|
||||
$this->actor->find(self::fileActionsMenuButtonForFile($this->fileListAncestor, $fileName), 10)->click();
|
||||
|
||||
$this->actor->find(self::removeFromFavoritesMenuItem(), 2)->click();
|
||||
}
|
||||
|
||||
/**
|
||||
* @When I view :fileName in folder
|
||||
*/
|
||||
public function iViewInFolder($fileName) {
|
||||
$this->actor->find(self::fileActionsMenuButtonForFile($this->fileListAncestor, $fileName), 10)->click();
|
||||
|
||||
$this->actor->find(self::viewFileInFolderMenuItem(), 2)->click();
|
||||
}
|
||||
|
||||
/**
|
||||
* @Then I see that the file list is eventually loaded
|
||||
*/
|
||||
public function iSeeThatTheFileListIsEventuallyLoaded() {
|
||||
if (!WaitFor::elementToBeEventuallyNotShown(
|
||||
$this->actor,
|
||||
self::mainWorkingIcon($this->fileListAncestor),
|
||||
$timeout = 10 * $this->actor->getFindTimeoutMultiplier())) {
|
||||
PHPUnit_Framework_Assert::fail("The main working icon for the file list is still shown after $timeout seconds");
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* @Then I see that it is not possible to create new files
|
||||
*/
|
||||
public function iSeeThatItIsNotPossibleToCreateNewFiles() {
|
||||
// Once a file list is loaded the "Create" menu button is always in the
|
||||
// DOM, so it is checked if it is visible or not.
|
||||
PHPUnit_Framework_Assert::assertFalse($this->actor->find(self::createMenuButton($this->fileListAncestor))->isVisible());
|
||||
}
|
||||
|
||||
/**
|
||||
* @Then I see that the file list contains a file named :fileName
|
||||
*/
|
||||
public function iSeeThatTheFileListContainsAFileNamed($fileName) {
|
||||
PHPUnit_Framework_Assert::assertNotNull($this->actor->find(self::rowForFile($this->fileListAncestor, $fileName), 10));
|
||||
}
|
||||
|
||||
/**
|
||||
* @Then I see that :fileName1 precedes :fileName2 in the file list
|
||||
*/
|
||||
public function iSeeThatPrecedesInTheFileList($fileName1, $fileName2) {
|
||||
PHPUnit_Framework_Assert::assertNotNull($this->actor->find(self::rowForFilePreceding($this->fileListAncestor, $fileName1, $fileName2), 10));
|
||||
}
|
||||
|
||||
/**
|
||||
* @Then I see that :fileName is marked as favorite
|
||||
*/
|
||||
public function iSeeThatIsMarkedAsFavorite($fileName) {
|
||||
PHPUnit_Framework_Assert::assertNotNull($this->actor->find(self::favoritedStateIconForFile($this->fileListAncestor, $fileName), 10));
|
||||
}
|
||||
|
||||
/**
|
||||
* @Then I see that :fileName is not marked as favorite
|
||||
*/
|
||||
public function iSeeThatIsNotMarkedAsFavorite($fileName) {
|
||||
PHPUnit_Framework_Assert::assertNotNull($this->actor->find(self::notFavoritedStateIconForFile($this->fileListAncestor, $fileName), 10));
|
||||
}
|
||||
|
||||
}
|
||||
@ -0,0 +1,78 @@
|
||||
<?php
|
||||
|
||||
/**
|
||||
*
|
||||
* @copyright Copyright (c) 2018, Daniel Calviño Sánchez (danxuliu@gmail.com)
|
||||
*
|
||||
* @license GNU AGPL version 3 or any later version
|
||||
*
|
||||
* This program is free software: you can redistribute it and/or modify
|
||||
* it under the terms of the GNU Affero General Public License as
|
||||
* published by the Free Software Foundation, either version 3 of the
|
||||
* License, or (at your option) any later version.
|
||||
*
|
||||
* This program is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU Affero General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU Affero General Public License
|
||||
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
*
|
||||
*/
|
||||
|
||||
/**
|
||||
* Helper class with common "wait for" functions.
|
||||
*/
|
||||
class WaitFor {
|
||||
|
||||
/**
|
||||
* Waits for the element to be visible.
|
||||
*
|
||||
* @param Actor $actor the Actor used to find the element.
|
||||
* @param Locator $elementLocator the locator for the element.
|
||||
* @param float $timeout the number of seconds (decimals allowed) to wait at
|
||||
* most for the element to be visible.
|
||||
* @param float $timeoutStep the number of seconds (decimals allowed) to
|
||||
* wait before checking the visibility again.
|
||||
* @return boolean true if the element is visible before (or exactly when)
|
||||
* the timeout expires, false otherwise.
|
||||
*/
|
||||
public static function elementToBeEventuallyShown(Actor $actor, Locator $elementLocator, $timeout = 10, $timeoutStep = 1) {
|
||||
$elementShownCallback = function() use ($actor, $elementLocator) {
|
||||
try {
|
||||
return $actor->find($elementLocator)->isVisible();
|
||||
} catch (NoSuchElementException $exception) {
|
||||
return false;
|
||||
}
|
||||
};
|
||||
|
||||
return Utils::waitFor($elementShownCallback, $timeout, $timeoutStep);
|
||||
}
|
||||
|
||||
/**
|
||||
* Waits for the element to be hidden (either not visible or not found in
|
||||
* the DOM).
|
||||
*
|
||||
* @param Actor $actor the Actor used to find the element.
|
||||
* @param Locator $elementLocator the locator for the element.
|
||||
* @param float $timeout the number of seconds (decimals allowed) to wait at
|
||||
* most for the element to be hidden.
|
||||
* @param float $timeoutStep the number of seconds (decimals allowed) to
|
||||
* wait before checking the visibility again.
|
||||
* @return boolean true if the element is hidden before (or exactly when)
|
||||
* the timeout expires, false otherwise.
|
||||
*/
|
||||
public static function elementToBeEventuallyNotShown(Actor $actor, Locator $elementLocator, $timeout = 10, $timeoutStep = 1) {
|
||||
$elementNotShownCallback = function() use ($actor, $elementLocator) {
|
||||
try {
|
||||
return !$actor->find($elementLocator)->isVisible();
|
||||
} catch (NoSuchElementException $exception) {
|
||||
return true;
|
||||
}
|
||||
};
|
||||
|
||||
return Utils::waitFor($elementNotShownCallback, $timeout, $timeoutStep);
|
||||
}
|
||||
|
||||
}
|
||||
Loading…
Reference in New Issue