sascha
/
nextcloud-server
mirror of https://github.com/nextcloud/server.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #21280 from owncloud/drop-unused-methods 

OC_Helper::makeURLAbsolute is not used anymore
remotes/origin/appinfo-object
Thomas Müller 2015-12-18 14:49:55 +07:00
parent 22d1b1285e 450e2f3bd3
commit 50e8773307
5 changed files with 15 additions and 182 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
lib/private/helper.php
Unescape Escape View File

@ -53,60 +53,6 @@ use Symfony\Component\Process\ExecutableFinder;
class OC_Helper {
private static $templateManager;
/**
* Creates an absolute url
* @param string $app app
* @param string $file file
* @param array $args array with param=>value, will be appended to the returned url
* The value of $args will be urlencoded
* @return string the url
*
* Returns a absolute url to the given app and file.
*/
public static function linkToAbsolute($app, $file, $args = array()) {
return OC::$server->getURLGenerator()->getAbsoluteURL(
OC::$server->getURLGenerator()->linkTo($app, $file, $args)
);
}
/**
* Makes an $url absolute
* @param string $url the url
* @return string the absolute url
* @deprecated Use \OC::$server->getURLGenerator()->getAbsoluteURL($url)
*
* Returns a absolute url to the given app and file.
*/
public static function makeURLAbsolute($url) {
return OC::$server->getURLGenerator()->getAbsoluteURL($url);
}
/**
* Creates an url for remote use
* @param string $service id
* @return string the url
*
* Returns a url to the given service.
*/
public static function linkToRemoteBase($service) {
return OC::$server->getURLGenerator()->linkTo('', 'remote.php') . '/' . $service;
}
/**
* Creates an absolute url for remote use
* @param string $service id
* @param bool $add_slash
* @return string the url
*
* Returns a absolute url to the given service.
*/
public static function linkToRemote($service, $add_slash = true) {
return OC::$server->getURLGenerator()->getAbsoluteURL(
self::linkToRemoteBase($service)
. (($add_slash && $service[strlen($service) - 1] != '/') ? '/' : '')
);
}
/**
* Creates an absolute url for public use
* @param string $service id

8
lib/private/util.php
Unescape Escape View File

@ -974,7 +974,7 @@ class OC_Util {
*/
public static function checkAppEnabled($app) {
if (!OC_App::isEnabled($app)) {
header('Location: ' . OC_Helper::linkToAbsolute('', 'index.php'));
header('Location: ' . \OCP\Util::linkToAbsolute('', 'index.php'));
exit();
}
}
@ -988,7 +988,7 @@ class OC_Util {
public static function checkLoggedIn() {
// Check if we are a user
if (!OC_User::isLoggedIn()) {
header('Location: ' . OC_Helper::linkToAbsolute('', 'index.php',
header('Location: ' . \OCP\Util::linkToAbsolute('', 'index.php',
[
'redirect_url' => \OC::$server->getRequest()->getRequestUri()
]
@ -1006,7 +1006,7 @@ class OC_Util {
public static function checkAdminUser() {
OC_Util::checkLoggedIn();
if (!OC_User::isAdminUser(OC_User::getUser())) {
header('Location: ' . OC_Helper::linkToAbsolute('', 'index.php'));
header('Location: ' . \OCP\Util::linkToAbsolute('', 'index.php'));
exit();
}
}
@ -1046,7 +1046,7 @@ class OC_Util {
}
if (!$isSubAdmin) {
header('Location: ' . OC_Helper::linkToAbsolute('', 'index.php'));
header('Location: ' . \OCP\Util::linkToAbsolute('', 'index.php'));
exit();
}
return true;

11
lib/public/util.php
Unescape Escape View File

@ -269,7 +269,10 @@ class Util {
* @since 4.0.0 - parameter $args was added in 4.5.0
*/
public static function linkToAbsolute( $app, $file, $args = array() ) {
return(\OC_Helper::linkToAbsolute( $app, $file, $args ));
$urlGenerator = \OC::$server->getURLGenerator();
return $urlGenerator->getAbsoluteURL(
$urlGenerator->linkTo($app, $file, $args)
);
}
/**
@ -279,7 +282,11 @@ class Util {
* @since 4.0.0
*/
public static function linkToRemote( $service ) {
return(\OC_Helper::linkToRemote( $service ));
$urlGenerator = \OC::$server->getURLGenerator();
$remoteBase = $urlGenerator->linkTo('', 'remote.php') . '/' . $service;
return $urlGenerator->getAbsoluteURL(
$remoteBase . (($service[strlen($service) - 1] != '/') ? '/' : '')
);
}
/**

4
settings/help.php
Unescape Escape View File

@ -34,11 +34,11 @@ OC_Util::addStyle( "settings", "settings" );
if(isset($_GET['mode']) and $_GET['mode'] === 'admin') {
$url=OC_Helper::linkToAbsolute( 'core', 'doc/admin/index.html' );
$url=\OCP\Util::linkToAbsolute( 'core', 'doc/admin/index.html' );
$style1='';
$style2=' active';
}else{
$url=OC_Helper::linkToAbsolute( 'core', 'doc/user/index.html' );
$url=\OCP\Util::linkToAbsolute( 'core', 'doc/user/index.html' );
$style1=' active';
$style2='';
}

120
tests/lib/helper.php
Unescape Escape View File

@ -243,126 +243,6 @@ class Test_Helper extends \Test\TestCase {
// Url generator methods
/**
* @small
* test absolute URL construction
* @dataProvider provideDocRootURLs
*/
function testMakeAbsoluteURLDocRoot($url, $expectedResult) {
\OC::$WEBROOT = '';
$result = \OC_Helper::makeURLAbsolute($url);
$this->assertEquals($expectedResult, $result);
}
/**
* @small
* test absolute URL construction
* @dataProvider provideSubDirURLs
*/
function testMakeAbsoluteURLSubDir($url, $expectedResult) {
\OC::$WEBROOT = '/owncloud';
$result = \OC_Helper::makeURLAbsolute($url);
$this->assertEquals($expectedResult, $result);
}
public function provideDocRootURLs() {
return array(
array('index.php', 'http://localhost/index.php'),
array('/index.php', 'http://localhost/index.php'),
array('/apps/index.php', 'http://localhost/apps/index.php'),
array('apps/index.php', 'http://localhost/apps/index.php'),
);
}
public function provideSubDirURLs() {
return array(
array('index.php', 'http://localhost/owncloud/index.php'),
array('/index.php', 'http://localhost/owncloud/index.php'),
array('/apps/index.php', 'http://localhost/owncloud/apps/index.php'),
array('apps/index.php', 'http://localhost/owncloud/apps/index.php'),
);
}
/**
* @small
* test linkToAbsolute URL construction
* @dataProvider provideDocRootAppAbsoluteUrlParts
*/
public function testLinkToAbsoluteDocRoot($app, $file, $args, $expectedResult) {
\OC::$WEBROOT = '';
$result = \OC_Helper::linkToAbsolute($app, $file, $args);
$this->assertEquals($expectedResult, $result);
}
/**
* @small
* test linkToAbsolute URL construction in sub directory
* @dataProvider provideSubDirAppAbsoluteUrlParts
*/
public function testLinkToAbsoluteSubDir($app, $file, $args, $expectedResult) {
\OC::$WEBROOT = '/owncloud';
$result = \OC_Helper::linkToAbsolute($app, $file, $args);
$this->assertEquals($expectedResult, $result);
}
/**
* @return array
*/
public function provideDocRootAppAbsoluteUrlParts() {
return array(
array('files', 'ajax/list.php', array(), 'http://localhost/index.php/apps/files/ajax/list.php'),
array('files', 'ajax/list.php', array('trut' => 'trat', 'dut' => 'dat'), 'http://localhost/index.php/apps/files/ajax/list.php?trut=trat&dut=dat'),
array('', 'index.php', array('trut' => 'trat', 'dut' => 'dat'), 'http://localhost/index.php?trut=trat&dut=dat'),
);
}
/**
* @return array
*/
public function provideSubDirAppAbsoluteUrlParts() {
return array(
array('files', 'ajax/list.php', array(), 'http://localhost/owncloud/index.php/apps/files/ajax/list.php'),
array('files', 'ajax/list.php', array('trut' => 'trat', 'dut' => 'dat'), 'http://localhost/owncloud/index.php/apps/files/ajax/list.php?trut=trat&dut=dat'),
array('', 'index.php', array('trut' => 'trat', 'dut' => 'dat'), 'http://localhost/owncloud/index.php?trut=trat&dut=dat'),
);
}
/**
* @small
* test linkToRemoteBase URL construction
*/
public function testLinkToRemoteBase() {
\OC::$WEBROOT = '';
$result = \OC_Helper::linkToRemoteBase('webdav');
$this->assertEquals('/remote.php/webdav', $result);
\OC::$WEBROOT = '/owncloud';
$result = \OC_Helper::linkToRemoteBase('webdav');
$this->assertEquals('/owncloud/remote.php/webdav', $result);
}
/**
* @small
* test linkToRemote URL construction
*/
public function testLinkToRemote() {
\OC::$WEBROOT = '';
$result = \OC_Helper::linkToRemote('webdav');
$this->assertEquals('http://localhost/remote.php/webdav/', $result);
$result = \OC_Helper::linkToRemote('webdav', false);
$this->assertEquals('http://localhost/remote.php/webdav', $result);
\OC::$WEBROOT = '/owncloud';
$result = \OC_Helper::linkToRemote('webdav');
$this->assertEquals('http://localhost/owncloud/remote.php/webdav/', $result);
$result = \OC_Helper::linkToRemote('webdav', false);
$this->assertEquals('http://localhost/owncloud/remote.php/webdav', $result);
}
/**
* @small
* test linkToPublic URL construction