From 49f22285708ed28bd443ff39fd1ec0060134157d Mon Sep 17 00:00:00 2001 From: Julius Knorr Date: Mon, 7 Apr 2025 20:47:11 +0200 Subject: [PATCH] fix: Proper order for checking path prefix for getting file by id from cache Signed-off-by: Julius Knorr --- lib/private/Files/Node/Root.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/private/Files/Node/Root.php b/lib/private/Files/Node/Root.php index 1686051131d..cf837cba397 100644 --- a/lib/private/Files/Node/Root.php +++ b/lib/private/Files/Node/Root.php @@ -384,7 +384,7 @@ class Root extends Folder implements IRootFolder { // scope the cache by user, so we don't return nodes for different users if ($this->user) { $cachedPath = $this->pathByIdCache->get($this->user->getUID() . '::' . $id); - if ($cachedPath && str_starts_with($path, $cachedPath)) { + if ($cachedPath && str_starts_with($cachedPath, $path)) { // getting the node by path is significantly cheaper than finding it by id $node = $this->get($cachedPath); // by validating that the cached path still has the requested fileid we can work around the need to invalidate the cached path