diff --git a/apps/dav/tests/unit/CalDAV/Reminder/BackendTest.php b/apps/dav/tests/unit/CalDAV/Reminder/BackendTest.php index 356acf2dd7f..561002ee59e 100644 --- a/apps/dav/tests/unit/CalDAV/Reminder/BackendTest.php +++ b/apps/dav/tests/unit/CalDAV/Reminder/BackendTest.php @@ -45,7 +45,7 @@ class BackendTest extends TestCase { $query = self::$realDatabase->getQueryBuilder(); $rows = $query->select('*') ->from('calendar_reminders') - ->execute() + ->executeQuery() ->fetchAll(); $this->assertCount(4, $rows); @@ -55,7 +55,7 @@ class BackendTest extends TestCase { $query = self::$realDatabase->getQueryBuilder(); $rows = $query->select('*') ->from('calendar_reminders') - ->execute() + ->executeQuery() ->fetchAll(); $this->assertCount(2, $rows); @@ -65,7 +65,7 @@ class BackendTest extends TestCase { $query = self::$realDatabase->getQueryBuilder(); $rows = $query->select('*') ->from('calendar_reminders') - ->execute() + ->executeQuery() ->fetchAll(); $this->assertCount(4, $rows); @@ -75,7 +75,7 @@ class BackendTest extends TestCase { $query = self::$realDatabase->getQueryBuilder(); $rows = $query->select('*') ->from('calendar_reminders') - ->execute() + ->executeQuery() ->fetchAll(); $this->assertCount(1, $rows); @@ -85,7 +85,7 @@ class BackendTest extends TestCase { $query = self::$realDatabase->getQueryBuilder(); $rows = $query->select('*') ->from('calendar_reminders') - ->execute() + ->executeQuery() ->fetchAll(); $this->assertCount(4, $rows); @@ -95,7 +95,7 @@ class BackendTest extends TestCase { $query = self::$realDatabase->getQueryBuilder(); $rows = $query->select('*') ->from('calendar_reminders') - ->execute() + ->executeQuery() ->fetchAll(); $this->assertCount(3, $rows); @@ -192,7 +192,7 @@ class BackendTest extends TestCase { $query = self::$realDatabase->getQueryBuilder(); $rows = $query->select('*') ->from('calendar_reminders') - ->execute() + ->executeQuery() ->fetchAll(); $this->assertCount(4, $rows); @@ -203,7 +203,7 @@ class BackendTest extends TestCase { $query = self::$realDatabase->getQueryBuilder(); $rows = $query->select('*') ->from('calendar_reminders') - ->execute() + ->executeQuery() ->fetchAll(); $this->assertCount(5, $rows); diff --git a/apps/dav/tests/unit/CalDAV/ResourceBooking/AbstractPrincipalBackendTestCase.php b/apps/dav/tests/unit/CalDAV/ResourceBooking/AbstractPrincipalBackendTestCase.php index 364bc74de49..03007d622df 100644 --- a/apps/dav/tests/unit/CalDAV/ResourceBooking/AbstractPrincipalBackendTestCase.php +++ b/apps/dav/tests/unit/CalDAV/ResourceBooking/AbstractPrincipalBackendTestCase.php @@ -462,7 +462,7 @@ abstract class AbstractPrincipalBackendTestCase extends TestCase { 'displayname' => $query->createNamedParameter('Beamer1'), 'group_restrictions' => $query->createNamedParameter('[]'), ]) - ->execute(); + ->executeStatement(); $query->insert($this->mainDbTable) ->values([ @@ -472,7 +472,7 @@ abstract class AbstractPrincipalBackendTestCase extends TestCase { 'displayname' => $query->createNamedParameter('TV1'), 'group_restrictions' => $query->createNamedParameter('[]'), ]) - ->execute(); + ->executeStatement(); $query->insert($this->mainDbTable) ->values([ @@ -482,7 +482,7 @@ abstract class AbstractPrincipalBackendTestCase extends TestCase { 'displayname' => $query->createNamedParameter('Beamer2'), 'group_restrictions' => $query->createNamedParameter('[]'), ]) - ->execute(); + ->executeStatement(); $id3 = $query->getLastInsertId(); $query->insert($this->mainDbTable) @@ -493,7 +493,7 @@ abstract class AbstractPrincipalBackendTestCase extends TestCase { 'displayname' => $query->createNamedParameter('TV2'), 'group_restrictions' => $query->createNamedParameter('[]'), ]) - ->execute(); + ->executeStatement(); $id4 = $query->getLastInsertId(); $query->insert($this->mainDbTable) @@ -504,7 +504,7 @@ abstract class AbstractPrincipalBackendTestCase extends TestCase { 'displayname' => $query->createNamedParameter('Beamer3'), 'group_restrictions' => $query->createNamedParameter('["foo", "bar"]'), ]) - ->execute(); + ->executeStatement(); $query->insert($this->mainDbTable) ->values([ @@ -514,7 +514,7 @@ abstract class AbstractPrincipalBackendTestCase extends TestCase { 'displayname' => $query->createNamedParameter('Pointer'), 'group_restrictions' => $query->createNamedParameter('["group1", "bar"]'), ]) - ->execute(); + ->executeStatement(); $id6 = $query->getLastInsertId(); $query->insert($this->metadataDbTable) @@ -523,34 +523,34 @@ abstract class AbstractPrincipalBackendTestCase extends TestCase { 'key' => $query->createNamedParameter('{http://nextcloud.com/ns}foo'), 'value' => $query->createNamedParameter('value1') ]) - ->execute(); + ->executeStatement(); $query->insert($this->metadataDbTable) ->values([ $this->foreignKey => $query->createNamedParameter($id3), 'key' => $query->createNamedParameter('{http://nextcloud.com/ns}meta2'), 'value' => $query->createNamedParameter('value2') ]) - ->execute(); + ->executeStatement(); $query->insert($this->metadataDbTable) ->values([ $this->foreignKey => $query->createNamedParameter($id4), 'key' => $query->createNamedParameter('{http://nextcloud.com/ns}meta1'), 'value' => $query->createNamedParameter('value1') ]) - ->execute(); + ->executeStatement(); $query->insert($this->metadataDbTable) ->values([ $this->foreignKey => $query->createNamedParameter($id4), 'key' => $query->createNamedParameter('{http://nextcloud.com/ns}meta3'), 'value' => $query->createNamedParameter('value3-old') ]) - ->execute(); + ->executeStatement(); $query->insert($this->metadataDbTable) ->values([ $this->foreignKey => $query->createNamedParameter($id6), 'key' => $query->createNamedParameter('{http://nextcloud.com/ns}meta99'), 'value' => $query->createNamedParameter('value99') ]) - ->execute(); + ->executeStatement(); } } diff --git a/apps/dav/tests/unit/CardDAV/CardDavBackendTest.php b/apps/dav/tests/unit/CardDAV/CardDavBackendTest.php index 9bc7e28f2c7..4e360ed31a3 100644 --- a/apps/dav/tests/unit/CardDAV/CardDavBackendTest.php +++ b/apps/dav/tests/unit/CardDAV/CardDavBackendTest.php @@ -549,7 +549,7 @@ class CardDavBackendTest extends TestCase { ->from('cards_properties') ->orderBy('name'); - $qResult = $query->execute(); + $qResult = $query->executeQuery(); $result = $qResult->fetchAll(); $qResult->closeCursor(); @@ -574,7 +574,7 @@ class CardDavBackendTest extends TestCase { $query->select('*') ->from('cards_properties'); - $qResult = $query->execute(); + $qResult = $query->executeQuery(); $result = $qResult->fetchAll(); $qResult->closeCursor(); @@ -598,7 +598,7 @@ class CardDavBackendTest extends TestCase { 'preferred' => $query->createNamedParameter(0) ] ); - $query->execute(); + $query->executeStatement(); $query = $this->db->getQueryBuilder(); $query->insert('cards_properties') @@ -611,7 +611,7 @@ class CardDavBackendTest extends TestCase { 'preferred' => $query->createNamedParameter(0) ] ); - $query->execute(); + $query->executeStatement(); $this->invokePrivate($this->backend, 'purgeProperties', [1, 1]); @@ -619,7 +619,7 @@ class CardDavBackendTest extends TestCase { $query->select('*') ->from('cards_properties'); - $qResult = $query->execute(); + $qResult = $query->executeQuery(); $result = $qResult->fetchAll(); $qResult->closeCursor(); @@ -642,7 +642,7 @@ class CardDavBackendTest extends TestCase { 'size' => $query->createNamedParameter(120) ] ); - $query->execute(); + $query->executeStatement(); $id = $query->getLastInsertId(); $this->assertSame($id, @@ -686,7 +686,7 @@ class CardDavBackendTest extends TestCase { 'size' => $query->createNamedParameter(120), ] ); - $query->execute(); + $query->executeStatement(); $vCardIds[] = $query->getLastInsertId(); } @@ -701,7 +701,7 @@ class CardDavBackendTest extends TestCase { 'preferred' => $query->createNamedParameter(0) ] ); - $query->execute(); + $query->executeStatement(); $query = $this->db->getQueryBuilder(); $query->insert($this->dbCardsPropertiesTable) ->values( @@ -713,7 +713,7 @@ class CardDavBackendTest extends TestCase { 'preferred' => $query->createNamedParameter(0) ] ); - $query->execute(); + $query->executeStatement(); $query = $this->db->getQueryBuilder(); $query->insert($this->dbCardsPropertiesTable) ->values( @@ -725,7 +725,7 @@ class CardDavBackendTest extends TestCase { 'preferred' => $query->createNamedParameter(0) ] ); - $query->execute(); + $query->executeStatement(); $query = $this->db->getQueryBuilder(); $query->insert($this->dbCardsPropertiesTable) ->values( @@ -737,7 +737,7 @@ class CardDavBackendTest extends TestCase { 'preferred' => $query->createNamedParameter(0) ] ); - $query->execute(); + $query->executeStatement(); $query = $this->db->getQueryBuilder(); $query->insert($this->dbCardsPropertiesTable) ->values( @@ -749,7 +749,7 @@ class CardDavBackendTest extends TestCase { 'preferred' => $query->createNamedParameter(0) ] ); - $query->execute(); + $query->executeStatement(); $result = $this->backend->search(0, $pattern, $properties, $options); @@ -795,7 +795,7 @@ class CardDavBackendTest extends TestCase { 'size' => $query->createNamedParameter(120), ] ); - $query->execute(); + $query->executeStatement(); $id = $query->getLastInsertId(); @@ -823,7 +823,7 @@ class CardDavBackendTest extends TestCase { 'size' => $query->createNamedParameter(120), ] ); - $query->execute(); + $query->executeStatement(); } $result = $this->backend->getContact(0, 'uri0'); @@ -856,7 +856,7 @@ class CardDavBackendTest extends TestCase { 'preferred' => $query->createNamedParameter(0) ] ) - ->execute(); + ->executeStatement(); $result = $this->backend->collectCardProperties(666, 'FN'); $this->assertEquals(['John Doe'], $result); diff --git a/apps/federation/tests/DbHandlerTest.php b/apps/federation/tests/DbHandlerTest.php index 5452a48fc4a..a8295ad665a 100644 --- a/apps/federation/tests/DbHandlerTest.php +++ b/apps/federation/tests/DbHandlerTest.php @@ -63,7 +63,7 @@ class DbHandlerTest extends TestCase { $query = $this->connection->getQueryBuilder()->select('*')->from($this->dbTable); - $qResult = $query->execute(); + $qResult = $query->executeQuery(); $result = $qResult->fetchAll(); $qResult->closeCursor(); $this->assertCount(1, $result); @@ -87,7 +87,7 @@ class DbHandlerTest extends TestCase { $query = $this->connection->getQueryBuilder()->select('*')->from($this->dbTable); - $qResult = $query->execute(); + $qResult = $query->executeQuery(); $result = $qResult->fetchAll(); $qResult->closeCursor(); $this->assertCount(2, $result); @@ -99,7 +99,7 @@ class DbHandlerTest extends TestCase { $this->dbHandler->removeServer($id2); $query = $this->connection->getQueryBuilder()->select('*')->from($this->dbTable); - $qResult = $query->execute(); + $qResult = $query->executeQuery(); $result = $qResult->fetchAll(); $qResult->closeCursor(); $this->assertCount(1, $result); @@ -175,7 +175,7 @@ class DbHandlerTest extends TestCase { $this->dbHandler->addServer('server1'); $query = $this->connection->getQueryBuilder()->select('*')->from($this->dbTable); - $qResult = $query->execute(); + $qResult = $query->executeQuery(); $result = $qResult->fetchAll(); $qResult->closeCursor(); $this->assertCount(1, $result); @@ -183,7 +183,7 @@ class DbHandlerTest extends TestCase { $this->dbHandler->addSharedSecret('http://server1', 'secret'); $query = $this->connection->getQueryBuilder()->select('*')->from($this->dbTable); - $qResult = $query->execute(); + $qResult = $query->executeQuery(); $result = $qResult->fetchAll(); $qResult->closeCursor(); $this->assertCount(1, $result); diff --git a/apps/files_external/tests/Service/StoragesServiceTestCase.php b/apps/files_external/tests/Service/StoragesServiceTestCase.php index 991921880e8..052bc578a18 100644 --- a/apps/files_external/tests/Service/StoragesServiceTestCase.php +++ b/apps/files_external/tests/Service/StoragesServiceTestCase.php @@ -315,7 +315,7 @@ abstract class StoragesServiceTestCase extends \Test\TestCase { ->from('storages') ->where($qb->expr()->eq('numeric_id', $qb->expr()->literal($numericId))); - $result = $storageCheckQuery->execute(); + $result = $storageCheckQuery->executeQuery(); $storages = $result->fetchAll(); $result->closeCursor(); $this->assertCount(0, $storages, 'expected 0 storages, got ' . json_encode($storages)); diff --git a/apps/files_sharing/lib/External/Manager.php b/apps/files_sharing/lib/External/Manager.php index 8157502baf4..3f87153d5da 100644 --- a/apps/files_sharing/lib/External/Manager.php +++ b/apps/files_sharing/lib/External/Manager.php @@ -703,7 +703,7 @@ class Manager { ) ) ); - $qb->execute(); + $qb->executeStatement(); } catch (\Doctrine\DBAL\Exception $ex) { $this->logger->emergency('Could not delete user shares', ['exception' => $ex]); return false; @@ -798,7 +798,7 @@ class Manager { ->orderBy('id', 'ASC'); try { - $result = $qb->execute(); + $result = $qb->executeQuery(); $shares = $result->fetchAll(); $result->closeCursor(); diff --git a/apps/files_sharing/tests/ExpireSharesJobTest.php b/apps/files_sharing/tests/ExpireSharesJobTest.php index 42bc5a4b659..6a79d132007 100644 --- a/apps/files_sharing/tests/ExpireSharesJobTest.php +++ b/apps/files_sharing/tests/ExpireSharesJobTest.php @@ -43,7 +43,8 @@ class ExpireSharesJobTest extends \Test\TestCase { $this->connection = Server::get(IDBConnection::class); // clear occasional leftover shares from other tests - $this->connection->executeUpdate('DELETE FROM `*PREFIX*share`'); + $qb = $this->connection->getQueryBuilder(); + $qb->delete('share')->executeStatement(); $this->user1 = $this->getUniqueID('user1_'); $this->user2 = $this->getUniqueID('user2_'); @@ -58,7 +59,8 @@ class ExpireSharesJobTest extends \Test\TestCase { } protected function tearDown(): void { - $this->connection->executeUpdate('DELETE FROM `*PREFIX*share`'); + $qb = $this->connection->getQueryBuilder(); + $qb->delete('share')->executeStatement(); $userManager = Server::get(IUserManager::class); $user1 = $userManager->get($this->user1); @@ -81,7 +83,7 @@ class ExpireSharesJobTest extends \Test\TestCase { $result = $qb->select('*') ->from('share') - ->execute(); + ->executeQuery(); while ($row = $result->fetch()) { $shares[] = $row; @@ -151,7 +153,7 @@ class ExpireSharesJobTest extends \Test\TestCase { ->where($qb->expr()->eq('id', $qb->createParameter('id'))) ->setParameter('id', $share['id']) ->setParameter('expiration', $expire) - ->execute(); + ->executeStatement(); $shares = $this->getShares(); $this->assertCount(1, $shares); diff --git a/apps/files_sharing/tests/Migration/SetPasswordColumnTest.php b/apps/files_sharing/tests/Migration/SetPasswordColumnTest.php index 3cbbad0f8bc..5b5c906f144 100644 --- a/apps/files_sharing/tests/Migration/SetPasswordColumnTest.php +++ b/apps/files_sharing/tests/Migration/SetPasswordColumnTest.php @@ -50,7 +50,7 @@ class SetPasswordColumnTest extends TestCase { private function cleanDB() { $query = $this->connection->getQueryBuilder(); - $query->delete($this->table)->execute(); + $query->delete($this->table)->executeStatement(); } public function testAddPasswordColumn(): void { @@ -80,7 +80,7 @@ class SetPasswordColumnTest extends TestCase { 'stime' => $query->createNamedParameter(time()), ]); - $this->assertSame(1, $query->execute()); + $this->assertSame(1, $query->executeStatement()); } } @@ -91,7 +91,7 @@ class SetPasswordColumnTest extends TestCase { $query = $this->connection->getQueryBuilder(); $query->select('*') ->from('share'); - $result = $query->execute(); + $result = $query->executeQuery(); $allShares = $result->fetchAll(); $result->closeCursor(); diff --git a/apps/files_sharing/tests/TestCase.php b/apps/files_sharing/tests/TestCase.php index 9a6935e46b6..0d2022ed341 100644 --- a/apps/files_sharing/tests/TestCase.php +++ b/apps/files_sharing/tests/TestCase.php @@ -122,15 +122,15 @@ abstract class TestCase extends \Test\TestCase { protected function tearDown(): void { $qb = Server::get(IDBConnection::class)->getQueryBuilder(); $qb->delete('share'); - $qb->execute(); + $qb->executeStatement(); $qb = Server::get(IDBConnection::class)->getQueryBuilder(); $qb->delete('mounts'); - $qb->execute(); + $qb->executeStatement(); $qb = Server::get(IDBConnection::class)->getQueryBuilder(); $qb->delete('filecache')->runAcrossAllShards(); - $qb->execute(); + $qb->executeStatement(); parent::tearDown(); } @@ -213,7 +213,7 @@ abstract class TestCase extends \Test\TestCase { ->where( $qb->expr()->eq('id', $qb->createNamedParameter($shareID)) ); - $result = $qb->execute(); + $result = $qb->executeQuery(); $share = $result->fetch(); $result->closeCursor(); diff --git a/apps/oauth2/tests/Db/ClientMapperTest.php b/apps/oauth2/tests/Db/ClientMapperTest.php index 2e8d20ad200..cf072118ae2 100644 --- a/apps/oauth2/tests/Db/ClientMapperTest.php +++ b/apps/oauth2/tests/Db/ClientMapperTest.php @@ -27,7 +27,7 @@ class ClientMapperTest extends TestCase { protected function tearDown(): void { $query = Server::get(IDBConnection::class)->getQueryBuilder(); - $query->delete('oauth2_clients')->execute(); + $query->delete('oauth2_clients')->executeStatement(); parent::tearDown(); } diff --git a/apps/sharebymail/tests/ShareByMailProviderTest.php b/apps/sharebymail/tests/ShareByMailProviderTest.php index 9a5116fb29c..be72e9e2df9 100644 --- a/apps/sharebymail/tests/ShareByMailProviderTest.php +++ b/apps/sharebymail/tests/ShareByMailProviderTest.php @@ -746,7 +746,7 @@ class ShareByMailProviderTest extends TestCase { ->from('share') ->where($qb->expr()->eq('id', $qb->createNamedParameter($id))); - $qResult = $qb->execute(); + $qResult = $qb->executeQuery(); $result = $qResult->fetchAll(); $qResult->closeCursor(); @@ -799,7 +799,7 @@ class ShareByMailProviderTest extends TestCase { ->from('share') ->where($qb->expr()->eq('id', $qb->createNamedParameter($id))); - $qResult = $qb->execute(); + $qResult = $qb->executeQuery(); $result = $qResult->fetchAll(); $qResult->closeCursor(); @@ -1031,7 +1031,7 @@ class ShareByMailProviderTest extends TestCase { $query->select('*')->from('share') ->where($query->expr()->eq('id', $query->createNamedParameter($id))); - $result = $query->execute(); + $result = $query->executeQuery(); $before = $result->fetchAll(); $result->closeCursor(); @@ -1044,7 +1044,7 @@ class ShareByMailProviderTest extends TestCase { $query->select('*')->from('share') ->where($query->expr()->eq('id', $query->createNamedParameter($id))); - $result = $query->execute(); + $result = $query->executeQuery(); $after = $result->fetchAll(); $result->closeCursor(); @@ -1067,7 +1067,7 @@ class ShareByMailProviderTest extends TestCase { $query = $this->connection->getQueryBuilder(); $query->select('*')->from('share'); - $result = $query->execute(); + $result = $query->executeQuery(); $before = $result->fetchAll(); $result->closeCursor(); @@ -1082,7 +1082,7 @@ class ShareByMailProviderTest extends TestCase { $query = $this->connection->getQueryBuilder(); $query->select('*')->from('share'); - $result = $query->execute(); + $result = $query->executeQuery(); $after = $result->fetchAll(); $result->closeCursor(); @@ -1156,7 +1156,7 @@ class ShareByMailProviderTest extends TestCase { */ $qb->setValue('file_target', $qb->createNamedParameter('')); - $qb->execute(); + $qb->executeStatement(); $id = $qb->getLastInsertId(); return (int)$id; diff --git a/apps/twofactor_backupcodes/tests/Db/BackupCodeMapperTest.php b/apps/twofactor_backupcodes/tests/Db/BackupCodeMapperTest.php index 19cab51969b..79006887a62 100644 --- a/apps/twofactor_backupcodes/tests/Db/BackupCodeMapperTest.php +++ b/apps/twofactor_backupcodes/tests/Db/BackupCodeMapperTest.php @@ -27,7 +27,7 @@ class BackupCodeMapperTest extends TestCase { $qb = $this->db->getQueryBuilder(); $qb->delete($this->mapper->getTableName()) ->where($qb->expr()->eq('user_id', $qb->createNamedParameter($this->testUID))); - $qb->execute(); + $qb->executeStatement(); } protected function setUp(): void { diff --git a/apps/user_status/tests/Unit/Db/UserStatusMapperTest.php b/apps/user_status/tests/Unit/Db/UserStatusMapperTest.php index ea4480489c7..ce920a02a8f 100644 --- a/apps/user_status/tests/Unit/Db/UserStatusMapperTest.php +++ b/apps/user_status/tests/Unit/Db/UserStatusMapperTest.php @@ -22,7 +22,7 @@ class UserStatusMapperTest extends TestCase { // make sure that DB is empty $qb = self::$realDatabase->getQueryBuilder(); - $qb->delete('user_status')->execute(); + $qb->delete('user_status')->executeStatement(); $this->mapper = new UserStatusMapper(self::$realDatabase); } diff --git a/apps/workflowengine/tests/ManagerTest.php b/apps/workflowengine/tests/ManagerTest.php index 1b28c13898d..4e547db387b 100644 --- a/apps/workflowengine/tests/ManagerTest.php +++ b/apps/workflowengine/tests/ManagerTest.php @@ -107,7 +107,7 @@ class ManagerTest extends TestCase { $query = $this->db->getQueryBuilder(); foreach (['flow_checks', 'flow_operations', 'flow_operations_scope'] as $table) { $query->delete($table) - ->execute(); + ->executeStatement(); } } diff --git a/build/psalm-baseline.xml b/build/psalm-baseline.xml index 1b38ed03855..306bf633f10 100644 --- a/build/psalm-baseline.xml +++ b/build/psalm-baseline.xml @@ -1628,8 +1628,6 @@ - -