fix(files): ensure proper headers lifecycle

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
pull/53872/head
skjnldsv 2025-07-08 23:06:39 +07:00
parent 58e1427ce9
commit 2fdd132325
1 changed files with 41 additions and 5 deletions

@ -12,6 +12,8 @@
import type { Folder, Header, View } from '@nextcloud/files'
import type { PropType } from 'vue'
import PQueue from 'p-queue'
import logger from '../logger.ts'
/**
@ -36,6 +38,14 @@ export default {
required: true,
},
},
setup() {
// Create a queue to ensure that the header is only rendered once at a time
const queue = new PQueue({ concurrency: 1 })
return {
queue,
}
},
computed: {
enabled() {
return this.header.enabled?.(this.currentFolder, this.currentView) ?? true
@ -46,19 +56,45 @@ export default {
if (!enabled) {
return
}
this.header.updated(this.currentFolder, this.currentView)
// If the header is enabled, we need to render it
logger.debug(`Enabled ${this.header.id} FilesListHeader`, { header: this.header })
this.queueUpdate(this.currentFolder, this.currentView)
},
currentFolder() {
this.header.updated(this.currentFolder, this.currentView)
currentFolder(folder: Folder) {
// This method can be used to queue an update of the header
// It will ensure that the header is only updated once at a time
this.queueUpdate(folder, this.currentView)
},
currentView(view: View) {
this.queueUpdate(this.currentFolder, view)
},
},
mounted() {
logger.debug(`Mounted ${this.header.id} FilesListHeader`, { header: this.header })
this.header.render(this.$refs.mount as HTMLElement, this.currentFolder, this.currentView)
const initialRender = () => this.header.render(this.$refs.mount as HTMLElement, this.currentFolder, this.currentView)
this.queue.add(initialRender).then(() => {
logger.debug(`Rendered ${this.header.id} FilesListHeader`, { header: this.header })
}).catch((error) => {
logger.error(`Error rendering ${this.header.id} FilesListHeader`, { header: this.header, error })
})
},
destroyed() {
logger.debug(`Destroyed ${this.header.id} FilesListHeader`, { header: this.header })
},
methods: {
queueUpdate(currentFolder: Folder, currentView: View) {
// This method can be used to queue an update of the header
// It will ensure that the header is only updated once at a time
this.queue.add(() => this.header.updated(currentFolder, currentView))
.then(() => {
logger.debug(`Updated ${this.header.id} FilesListHeader`, { header: this.header })
})
.catch((error) => {
logger.error(`Error updating ${this.header.id} FilesListHeader`, { header: this.header, error })
})
},
},
}
</script>