From 9ce8e1ddc7a842db32cc58530e2022238b6e35ea Mon Sep 17 00:00:00 2001 From: Roeland Jago Douma Date: Wed, 18 Mar 2015 14:29:01 +0100 Subject: [PATCH 1/2] OCS API should return fancy OC url * Also use the URLGenerator --- apps/files_sharing/api/local.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/apps/files_sharing/api/local.php b/apps/files_sharing/api/local.php index 87a8fbbb21f..3cf541b3fab 100644 --- a/apps/files_sharing/api/local.php +++ b/apps/files_sharing/api/local.php @@ -303,8 +303,7 @@ class Local { break; } } - $url = \OCP\Util::linkToPublic('files&t='.$token); - $data['url'] = $url; // '&' gets encoded to $amp; + $data['url'] = \OC::$server->getURLGenerator()->linkToRouteAbsolute('files_sharing.sharecontroller.showShare', ['token' => $token]); $data['token'] = $token; } else { From bdde2156da7639af39051f083df434e5298585dd Mon Sep 17 00:00:00 2001 From: Roeland Jago Douma Date: Fri, 20 Mar 2015 13:38:08 +0100 Subject: [PATCH 2/2] Added extra unit test --- apps/files_sharing/tests/api.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/apps/files_sharing/tests/api.php b/apps/files_sharing/tests/api.php index 371c94a8c88..4f9041ae27a 100644 --- a/apps/files_sharing/tests/api.php +++ b/apps/files_sharing/tests/api.php @@ -103,6 +103,11 @@ class Test_Files_Sharing_Api extends TestCase { // check if we have a token $this->assertTrue(is_string($data['token'])); + // check for correct link + $url = \OC::$server->getURLGenerator()->getAbsoluteURL('/index.php/s/' . $data['token']); + $this->assertEquals($url, $data['url']); + + $share = $this->getShareFromId($data['id']); $items = \OCP\Share::getItemShared('file', $share['item_source']);