sascha
/
nextcloud-server
mirror of https://github.com/nextcloud/server.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: don't return null for SharedStorage::getWrapperStorage with share recursion 

Signed-off-by: Robin Appelman <robin@icewind.nl>
pull/44323/head
Robin Appelman 2024-03-11 17:07:49 +07:00
parent 290ccdb684
commit 22596234fc
No known key found for this signature in database
GPG Key ID: 42B69D8A64526EFB
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
apps/files_sharing/lib/SharedStorage.php
Unescape Escape View File

@ -136,6 +136,16 @@ class SharedStorage extends \OC\Files\Storage\Wrapper\Jail implements ISharedSto
private function init() {
if ($this->initialized) {
if (!$this->storage) {
// marked as initialized but no storage set
// this is probably because some code path has caused recursion during the share setup
// we setup a "failed storage" so `getWrapperStorage` doesn't return null.
// If the share setup completes after this the "failed storage" will be overwritten by the correct one
$this->logger->warning('Possible share setup recursion detected');
$this->storage = new FailedStorage(['exception' => new \Exception('Possible share setup recursion detected')]);
$this->cache = new FailedCache();
$this->rootPath = '';
}
return;
}