Merge pull request #51927 from nextcloud/fix/tags-events

fix(systemtags): emit assign and unassign bulk tagging events

apps/systemtags/lib/Activity/Provider.php

@@ -286,7 +286,7 @@ class Provider implements IProvider {
 		if ($tagData === null) {
 			[$name, $status] = explode('|||', substr($parameter, 3, -3));
 			$tagData = [
-				'id' => '0',// No way to recover the ID
+				'id' => '0', // No way to recover the ID
 				'name' => $name,
 				'assignable' => $status === 'assignable',
 				'visible' => $status !== 'invisible',

lib/private/SystemTag/SystemTagObjectMapper.php

@@ -287,6 +287,7 @@ class SystemTagObjectMapper implements ISystemTagObjectMapper {
 		$currentObjectIds = $this->getObjectIdsForTags($tagId, $objectType);
 		$removedObjectIds = array_diff($currentObjectIds, $objectIds);
 		$addedObjectIds = array_diff($objectIds, $currentObjectIds);
+
 		$this->connection->beginTransaction();
 		$query = $this->connection->getQueryBuilder();
 		$query->delete(self::RELATION_TABLE)
@@ -324,6 +325,8 @@ class SystemTagObjectMapper implements ISystemTagObjectMapper {
 
 		$this->updateEtagForTags([$tagId]);
 		$this->connection->commit();
+
+		// Dispatch assign events for new object ids
 		foreach ($addedObjectIds as $objectId) {
 			$this->dispatcher->dispatch(MapperEvent::EVENT_ASSIGN, new MapperEvent(
 				MapperEvent::EVENT_ASSIGN,
@@ -332,6 +335,16 @@ class SystemTagObjectMapper implements ISystemTagObjectMapper {
 				[(int)$tagId]
 			));
 		}
+
+		// Dispatch unassign events for removed object ids
+		foreach ($removedObjectIds as $objectId) {
+			$this->dispatcher->dispatch(MapperEvent::EVENT_UNASSIGN, new MapperEvent(
+				MapperEvent::EVENT_UNASSIGN,
+				$objectType,
+				(string)$objectId,
+				[(int)$tagId]
+			));
+		}
 	}
 
 	/**