Merge pull request #51737 from nextcloud/fix/disable-reminder-invalid-nodes

fix(files_reminders): Fix reminder actions being displayed on invalid nodes

apps/files_reminders/src/actions/setReminderCustomAction.ts

@@ -18,8 +18,17 @@ export const action = new FileAction({
 	title: () => t('files_reminders', 'Set reminder at custom date & time'),
 	iconSvgInline: () => CalendarClockSvg,
 
-	enabled: (_nodes: Node[], view: View) => {
-		return view.id !== 'trashbin'
+	enabled: (nodes: Node[], view: View) => {
+		if (view.id === 'trashbin') {
+			return false
+		}
+		// Only allow on a single node
+		if (nodes.length !== 1) {
+			return false
+		}
+		const node = nodes.at(0)!
+		const dueDate = node.attributes['reminder-due-date']
+		return dueDate !== undefined
 	},
 
 	parent: SET_REMINDER_MENU_ID,

apps/files_reminders/src/actions/setReminderMenuAction.ts

@@ -16,8 +16,17 @@ export const action = new FileAction({
 	displayName: () => t('files_reminders', 'Set reminder'),
 	iconSvgInline: () => AlarmSvg,
 
-	enabled: (_nodes: Node[], view: View) => {
-		return view.id !== 'trashbin'
+	enabled: (nodes: Node[], view: View) => {
+		if (view.id === 'trashbin') {
+			return false
+		}
+		// Only allow on a single node
+		if (nodes.length !== 1) {
+			return false
+		}
+		const node = nodes.at(0)!
+		const dueDate = node.attributes['reminder-due-date']
+		return dueDate !== undefined
 	},
 
 	async exec() {

apps/files_reminders/src/actions/setReminderSuggestionActions.ts

@@ -74,11 +74,17 @@ const generateFileAction = (option: ReminderOption): FileAction|null => {
 		// Empty svg to hide the icon
 		iconSvgInline: () => '<svg></svg>',
 
-		enabled: (_nodes: Node[], view: View) => {
+		enabled: (nodes: Node[], view: View) => {
 			if (view.id === 'trashbin') {
 				return false
 			}
-			return Boolean(getDateTime(option.dateTimePreset))
+			// Only allow on a single node
+			if (nodes.length !== 1) {
+				return false
+			}
+			const node = nodes.at(0)!
+			const dueDate = node.attributes['reminder-due-date']
+			return dueDate !== undefined && Boolean(getDateTime(option.dateTimePreset))
 		},
 
 		parent: SET_REMINDER_MENU_ID,