From 10eda6552585dd9e223bf4da40f2c20ba52045d3 Mon Sep 17 00:00:00 2001
From: Ferdinand Thiessen <opensource@fthiessen.de>
Date: Thu, 31 Jul 2025 14:28:19 +0200
Subject: [PATCH] fix(AppMenu): ensure that aria attributes are set when needed

We hide **if** there is **no** notification.
We *do not* hide and *show the label* **if** there are notifications for
that application.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
---
 core/src/components/AppMenuIcon.vue | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/core/src/components/AppMenuIcon.vue b/core/src/components/AppMenuIcon.vue
index f2cee75e644..8e4ed607c4d 100644
--- a/core/src/components/AppMenuIcon.vue
+++ b/core/src/components/AppMenuIcon.vue
@@ -14,24 +14,25 @@
 </template>
 
 <script setup lang="ts">
-import type { INavigationEntry } from '../types/navigation'
+import type { INavigationEntry } from '../types/navigation.ts'
+
 import { n } from '@nextcloud/l10n'
 import { computed } from 'vue'
-
 import IconDot from 'vue-material-design-icons/Circle.vue'
 
 const props = defineProps<{
 	app: INavigationEntry
 }>()
 
-const ariaHidden = computed(() => String(props.app.unread > 0))
+// only hide if there are no unread notifications
+const ariaHidden = computed(() => !props.app.unread ? 'true' : undefined)
 
 const ariaLabel = computed(() => {
-	if (ariaHidden.value === 'true') {
-		return ''
+	if (!props.app.unread) {
+		return undefined
 	}
-	return props.app.name
-		+ (props.app.unread > 0 ? ` (${n('core', '{count} notification', '{count} notifications', props.app.unread, { count: props.app.unread })})` : '')
+
+	return `${props.app.name} (${n('core', '{count} notification', '{count} notifications', props.app.unread, { count: props.app.unread })})`
 })
 </script>