sascha
/
nextcloud-server
mirror of https://github.com/nextcloud/server.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(bfp): Trim meta data so it can still be stored 

Signed-off-by: Joas Schilling <coding@schilljs.com>
pull/55910/head
Joas Schilling 2025-10-22 15:45:21 +07:00
parent 7978ee82a4
commit 0f183ce8fe
No known key found for this signature in database
GPG Key ID: F72FA5B49FFA96B0
1 changed files with 22 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
lib/private/Security/Bruteforce/Backend/DatabaseBackend.php
Unescape Escape View File

@ -37,7 +37,8 @@ class DatabaseBackend implements IBackend {
$query->andWhere($query->expr()->eq('action', $query->createNamedParameter($action)));
if ($metadata !== null) {
$query->andWhere($query->expr()->eq('metadata', $query->createNamedParameter(json_encode($metadata))));
$trimmedMetaData = $this->trimMetaData($metadata);
$query->andWhere($query->expr()->eq('metadata', $query->createNamedParameter($trimmedMetaData)));
}
}
@ -64,7 +65,8 @@ class DatabaseBackend implements IBackend {
$query->andWhere($query->expr()->eq('action', $query->createNamedParameter($action)));
if ($metadata !== null) {
$query->andWhere($query->expr()->eq('metadata', $query->createNamedParameter(json_encode($metadata))));
$trimmedMetaData = $this->trimMetaData($metadata);
$query->andWhere($query->expr()->eq('metadata', $query->createNamedParameter($trimmedMetaData)));
}
}
@ -85,15 +87,32 @@ class DatabaseBackend implements IBackend {
'ip' => $ip,
'subnet' => $ipSubnet,
'action' => $action,
'metadata' => json_encode($metadata),
'metadata' => $metadata,
'occurred' => $timestamp,
];
$qb = $this->db->getQueryBuilder();
$qb->insert(self::TABLE_NAME);
foreach ($values as $column => $value) {
if ($column === 'metadata') {
$value = $this->trimMetaData($value);
}
$qb->setValue($column, $qb->createNamedParameter($value));
}
$qb->executeStatement();
}
protected function trimMetaData(array $metadata): string {
try {
$data = json_encode($metadata, JSON_THROW_ON_ERROR);
} catch (\JsonException) {
$data = 'INVALID';
}
$trimmed = substr($data, 0, 254);
if ($trimmed !== $data) {
$trimmed .= '…';
}
return $trimmed;
}
}