sascha
/
gitea
mirror of https://github.com/go-gitea/gitea.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
gitea/routers/web/repo
History
Lunny Xiao 6d0b24064a
Keeping consistent between UI and API about combined commit status state and fix some bugs (#34562) 
Extract from #34531 

## Move Commit status state to a standalone package

Move the state from `structs` to `commitstatus` package. It also
introduce `CommitStatusStates` so that the combine function could be
used from UI and API logic.

## Combined commit status Changed

This PR will follow Github's combined commit status. Before this PR,
every commit status could be a combined one.
According to
https://docs.github.com/en/rest/commits/statuses?apiVersion=2022-11-28#get-the-combined-status-for-a-specific-reference
> Additionally, a combined state is returned. The state is one of:
> failure if any of the contexts report as error or failure
> pending if there are no statuses or a context is pending
> success if the latest status for all contexts is success

This PR will follow that rule and remove the `NoBetterThan` logic. This
also fixes the inconsistent between UI and API. In the API convert
package, it has implemented this which is different from the UI. It also
fixed the missing `URL` and `CommitURL` in the API.

## `CalcCommitStatus` return nil if there is no commit statuses

The behavior of `CalcCommitStatus` is changed. If the parameter commit
statuses is empty, it will return nil. The reference places should check
the returned value themselves.
 		2025-06-09 04:05:33 +07:00
..
actions Add "View workflow file" to Actions list page (#34538) 2025-05-28 20:30:00 +07:00
setting Refactor some tests (#34580) 2025-06-03 01:26:19 +07:00
activity.go Do not show 500 error when default branch doesn't exist (#34096) 2025-04-01 21:39:00 +07:00
attachment.go Refactor error system (#33610) 2025-02-16 22:13:17 +07:00
blame.go Fix incorrect file links (#34189) 2025-04-13 12:27:31 +07:00
branch.go Add endpoint deleting workflow run (#34337) 2025-05-13 19:18:13 +07:00
cherry_pick.go Enable addtional linters (#34085) 2025-04-01 10:14:01 +07:00
code_frequency.go Hide activity contributors, recent commits and code frequrency left tabs if there is no code permission (#34053) 2025-03-28 21:04:40 +07:00
commit.go Keeping consistent between UI and API about combined commit status state and fix some bugs (#34562) 2025-06-09 04:05:33 +07:00
compare.go Fix bug when visiting comparation page (#34334) 2025-05-04 18:52:00 +07:00
contributors.go Fix incorrect ref commit ID usage (#33331) 2025-01-20 07:43:49 +07:00
download.go Refactor cache-control (#33861) 2025-03-13 07:04:50 +07:00
editor.go Only git operations should update `last changed` of a repository (#34388) 2025-05-11 19:18:46 +07:00
editor_test.go Enable testifylint rules (#34075) 2025-03-31 01:53:48 +07:00
find.go Refactor template & test related code (#32938) 2024-12-22 15:33:19 +07:00
fork.go Check user/org repo limit instead of doer (#34147) 2025-04-07 23:45:31 +07:00
githttp.go Uniform all temporary directories and allow customizing temp path (#32352) 2025-04-08 16:15:28 +07:00
githttp_test.go Enable testifylint rules (#34075) 2025-03-31 01:53:48 +07:00
helper.go Refactor error system (#33610) 2025-02-16 22:13:17 +07:00
issue.go Fix bug webhook milestone is not right. (#34419) 2025-05-11 23:56:24 +07:00
issue_comment.go When updating comment, if the content is the same, just return and not update the databse (#34422) 2025-05-11 18:53:23 +07:00
issue_content_history.go enable staticcheck QFxxxx rules (#34064) 2025-03-29 17:32:28 +07:00
issue_dependency.go Refactor error system (#33610) 2025-02-16 22:13:17 +07:00
issue_label.go Validate hex colors when creating/editing labels (#34623) 2025-06-07 11:25:08 +07:00
issue_label_test.go Validate hex colors when creating/editing labels (#34623) 2025-06-07 11:25:08 +07:00
issue_list.go Do not mutate incoming options to SearchRepositoryByName (#34553) 2025-06-02 17:33:25 +07:00
issue_lock.go Add API routes to lock and unlock issues (#34165) 2025-04-21 00:43:43 +07:00
issue_new.go Enable addtional linters (#34085) 2025-04-01 10:14:01 +07:00
issue_page_meta.go Fix PR's target branch dropdown (#33589) 2025-02-14 05:21:31 +07:00
issue_pin.go Move issue pin to an standalone table for querying performance (#33452) 2025-02-17 11:28:37 +07:00
issue_poster.go Support public code/issue access for private repositories (#33127) 2025-01-14 01:53:34 +07:00
issue_stopwatch.go Prepare common tmpl functions in a middleware (#33957) 2025-03-25 06:17:58 +07:00
issue_suggestions.go Rework suggestion backend (#33538) 2025-02-10 16:24:05 +07:00
issue_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +07:00
issue_timetrack.go Refactor error system (#33610) 2025-02-16 22:13:17 +07:00
issue_view.go Keeping consistent between UI and API about combined commit status state and fix some bugs (#34562) 2025-06-09 04:05:33 +07:00
issue_watch.go Refactor error system (#33610) 2025-02-16 22:13:17 +07:00
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +07:00
middlewares.go Refactor context repository (#33202) 2025-01-12 03:39:46 +07:00
migrate.go Refactor error system (#33610) 2025-02-16 22:13:17 +07:00
milestone.go feat: Add sorting by exclusive labels (issue priority) (#33206) 2025-04-10 17:18:07 +07:00
packages.go Refactor context repository (#33202) 2025-01-12 03:39:46 +07:00
patch.go Enable addtional linters (#34085) 2025-04-01 10:14:01 +07:00
projects.go feat: Add sorting by exclusive labels (issue priority) (#33206) 2025-04-10 17:18:07 +07:00
projects_test.go Clarify path param naming (#32969) 2024-12-24 13:47:45 +07:00
pull.go Fix possible pull request broken when leave the page immediately after clicking the update button (#34509) 2025-06-04 17:09:08 +07:00
pull_review.go enable staticcheck QFxxxx rules (#34064) 2025-03-29 17:32:28 +07:00
pull_review_test.go Refactor older tests to use testify (#33140) 2025-01-09 09:21:47 +07:00
recent_commits.go Hide activity contributors, recent commits and code frequrency left tabs if there is no code permission (#34053) 2025-03-28 21:04:40 +07:00
release.go Split GetLatestCommitStatus as two functions (#34535) 2025-05-26 19:00:22 +07:00
release_test.go Validate that the tag doesn't exist when creating a tag via the web (#33241) 2025-01-14 09:27:35 +07:00
render.go Refactor error system (#33610) 2025-02-16 22:13:17 +07:00
repo.go Do not mutate incoming options to SearchRepositoryByName (#34553) 2025-06-02 17:33:25 +07:00
search.go Improve issue & code search (#33860) 2025-03-13 11:07:48 +07:00
star.go Refactor web route handler (#33488) 2025-02-05 02:14:03 +07:00
topic.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +07:00
transfer.go Refactor web route handler (#33488) 2025-02-05 02:14:03 +07:00
treelist.go support the open-icon of folder (#34168) 2025-04-28 19:51:32 +07:00
treelist_test.go support the open-icon of folder (#34168) 2025-04-28 19:51:32 +07:00
view.go Split GetLatestCommitStatus as two functions (#34535) 2025-05-26 19:00:22 +07:00
view_file.go Fix incorrect file links (#34189) 2025-04-13 12:27:31 +07:00
view_home.go Fix repo broken check (#34444) 2025-05-13 08:18:45 +07:00
view_home_test.go Correctly handle submodule view and avoid throwing 500 error (#34121) 2025-04-06 09:38:08 +07:00
view_readme.go Fix incorrect file links (#34189) 2025-04-13 12:27:31 +07:00
view_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +07:00
watch.go Refactor web route handler (#33488) 2025-02-05 02:14:03 +07:00
webgit.go Support choose email when creating a commit via web UI (more) (#33445) 2025-01-31 02:36:18 +07:00
wiki.go Only git operations should update `last changed` of a repository (#34388) 2025-05-11 19:18:46 +07:00
wiki_test.go Only git operations should update `last changed` of a repository (#34388) 2025-05-11 19:18:46 +07:00