sascha
/
gitea
mirror of https://github.com/go-gitea/gitea.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
19,855 Commits
19 Branches
244 Tags
844 MiB
Commit Graph

3 Commits (4666bc17e453bef4d676e151fecd79392b51ff16)

Author SHA1 Message Date
wxiaoguang 0cbaa0b662
Remove incorrect "db.DefaultContext" usages (#35366) 2025-08-28 03:52:43 +07:00
RiceChuan dfd7594499
chore: use errors.New to replace fmt.Errorf with no parameters (#32800) 
use errors.New to replace fmt.Errorf with no parameters

Signed-off-by: RiceChuan <lc582041246@gmail.com>
 2024-12-12 12:26:11 +07:00
Jason Song a35714372d
Fix halfCommitter and WithTx (#22366) 
Related to #22362.

I overlooked that there's always `committer.Close()`, like:

```go
		ctx, committer, err := db.TxContext(db.DefaultContext)
		if err != nil {
			return nil
		}
		defer committer.Close()

		// ...

		if err != nil {
			return nil
		}

		// ...

		return committer.Commit()
```

So the `Close` of `halfCommitter` should ignore `commit and close`, it's
not a rollback.

See: [Why `halfCommitter` and `WithTx` should rollback IMMEDIATELY or
commit
LATER](https://github.com/go-gitea/gitea/pull/22366#issuecomment-1374778612).

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2023-01-09 12:19:19 +07:00