From a7b804626bf6c3dfda2b1f6c6b866fd6e1a23091 Mon Sep 17 00:00:00 2001 From: SBALAVIGNESH123 Date: Thu, 11 Dec 2025 02:52:51 +0530 Subject: [PATCH] style: apply gofumpt formatting Signed-off-by: SBALAVIGNESH123 --- models/actions/cross_repo_access.go | 5 ----- modules/actions/permission_checker.go | 1 - routers/api/v1/org/org_actions_permissions.go | 2 -- 3 files changed, 8 deletions(-) diff --git a/models/actions/cross_repo_access.go b/models/actions/cross_repo_access.go index f95c34a09c..5c1f1a91ad 100644 --- a/models/actions/cross_repo_access.go +++ b/models/actions/cross_repo_access.go @@ -72,7 +72,6 @@ func CheckCrossRepoAccess(ctx context.Context, sourceRepoID, targetRepoID int64) has, err := db.GetEngine(ctx). Where("source_repo_id = ? AND target_repo_id = ?", sourceRepoID, targetRepoID). Get(rule) - if err != nil { return 0, err } @@ -95,7 +94,6 @@ func CreateCrossRepoAccess(ctx context.Context, rule *ActionCrossRepoAccess) err Where("org_id = ? AND source_repo_id = ? AND target_repo_id = ?", rule.OrgID, rule.SourceRepoID, rule.TargetRepoID). Get(existing) - if err != nil { return err } @@ -128,7 +126,6 @@ func LinkPackageToRepo(ctx context.Context, packageID, repoID int64) error { has, err := db.GetEngine(ctx). Where("package_id = ? AND repo_id = ?", packageID, repoID). Get(existing) - if err != nil { return err } @@ -168,7 +165,6 @@ func GetPackageLinkedRepos(ctx context.Context, packageID int64) ([]int64, error err := db.GetEngine(ctx). Where("package_id = ?", packageID). Find(&links) - if err != nil { return nil, err } @@ -187,7 +183,6 @@ func GetRepoLinkedPackages(ctx context.Context, repoID int64) ([]int64, error) { err := db.GetEngine(ctx). Where("repo_id = ?", repoID). Find(&links) - if err != nil { return nil, err } diff --git a/modules/actions/permission_checker.go b/modules/actions/permission_checker.go index c6b2071319..96b8fd861c 100644 --- a/modules/actions/permission_checker.go +++ b/modules/actions/permission_checker.go @@ -49,7 +49,6 @@ func (pc *PermissionChecker) GetEffectivePermissions( isFromForkPR bool, workflowPermissions map[string]string, // From workflow YAML ) (*EffectivePermissions, error) { - // SECURITY: Fork PRs are ALWAYS restricted, regardless of any configuration // This prevents malicious PRs from accessing sensitive resources // Reference: https://github.com/go-gitea/gitea/pull/24554#issuecomment-1537040811 diff --git a/routers/api/v1/org/org_actions_permissions.go b/routers/api/v1/org/org_actions_permissions.go index 0348ac9e9b..84d1759443 100644 --- a/routers/api/v1/org/org_actions_permissions.go +++ b/routers/api/v1/org/org_actions_permissions.go @@ -155,8 +155,6 @@ func ListCrossRepoAccess(ctx *context.APIContext) { // https://github.com/go-gitea/gitea/issues/24635 // Permission check handled by reqOrgOwnership middleware - - rules, err := actions_model.ListCrossRepoAccessRules(ctx, ctx.Org.Organization.ID) if err != nil { ctx.APIErrorInternal(err)