sascha
/
gitea
mirror of https://github.com/go-gitea/gitea.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Refactor smal code snippeds in models/issues/pull.go (#35301) 

just code refactor nits
pull/35298/head^2
6543 2025-08-18 23:23:40 +07:00 committed by GitHub
parent 4ea8f33ae6
commit 57b8441745
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
models/issues/pull.go
Unescape Escape View File

@ -29,6 +29,8 @@ import (
var ErrMustCollaborator = util.NewPermissionDeniedErrorf("user must be a collaborator")
const reviewedBy = "Reviewed-by: "
// ErrPullRequestNotExist represents a "PullRequestNotExist" kind of error.
type ErrPullRequestNotExist struct {
ID int64
@ -348,7 +350,11 @@ type ReviewCount struct {
func (pr *PullRequest) GetApprovalCounts(ctx context.Context) ([]*ReviewCount, error) {
rCounts := make([]*ReviewCount, 0, 6)
sess := db.GetEngine(ctx).Where("issue_id = ?", pr.IssueID)
return rCounts, sess.Select("issue_id, type, count(id) as `count`").Where("official = ? AND dismissed = ?", true, false).GroupBy("issue_id, type").Table("review").Find(&rCounts)
return rCounts, sess.Select("issue_id, type, count(id) as `count`").
Where(builder.Eq{"official": true, "dismissed": false}).
GroupBy("issue_id, type").
Table("review").
Find(&rCounts)
}
// GetApprovers returns the approvers of the pull request
@ -392,7 +398,7 @@ func (pr *PullRequest) getReviewedByLines(ctx context.Context, writer io.Writer)
} else if review.Reviewer == nil {
continue
}
if _, err := writer.Write([]byte("Reviewed-by: ")); err != nil {
if _, err := writer.Write([]byte(reviewedBy)); err != nil {
return err
}
if _, err := writer.Write([]byte(review.Reviewer.NewGitSig().String())); err != nil {