From 5ef5ff00a43c60ecb03fef06656c2daaee9fbb50 Mon Sep 17 00:00:00 2001 From: Rindbee Date: Thu, 29 Jun 2023 16:03:21 +0200 Subject: [PATCH] Fix calling `TextureStorage::texture_3d_update()` could cause a crash (cherry picked from commit ebd2b9e299eca51c75a3e774a2c3f1eb8c22a46f) --- servers/rendering/renderer_rd/storage_rd/texture_storage.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/servers/rendering/renderer_rd/storage_rd/texture_storage.cpp b/servers/rendering/renderer_rd/storage_rd/texture_storage.cpp index 1aab52d1c3..3c08f2de90 100644 --- a/servers/rendering/renderer_rd/storage_rd/texture_storage.cpp +++ b/servers/rendering/renderer_rd/storage_rd/texture_storage.cpp @@ -1153,8 +1153,8 @@ void TextureStorage::texture_3d_update(RID p_texture, const Vector> & image = image->duplicate(); image->convert(tex->validated_format); } - all_data_size += images[i]->get_data().size(); - images.push_back(image); + all_data_size += image->get_data().size(); + images.write[i] = image; } all_data.resize(all_data_size); //consolidate all data here